[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417606#comment-16417606 ] ASF subversion and git services commented on ARTEMIS-1762: -- Commit 717bc8f09ab4e5cea4827c5f401af6abf7d91761 in activemq-artemis's branch refs/heads/1.x from [~nigro@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=717bc8f ] ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured (cherry picked from commit 3b8da88989f680fca0ef178312c017a6d0b14ff2) > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415677#comment-16415677 ] ASF GitHub Bot commented on ARTEMIS-1762: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1969 > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415675#comment-16415675 ] ASF subversion and git services commented on ARTEMIS-1762: -- Commit b89fa74f8ab431bfae06dff4a680ffebb5a0dd36 in activemq-artemis's branch refs/heads/master from [~nigro@gmail.com] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b89fa74 ] ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured It forces to use InVMNodeManager when no HA option is selected with JDBC persistence and includes the checks that the only valid JDBC HA options are SHARED_STORE_MASTER and SHARED_STORE_SLAVE. > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410934#comment-16410934 ] ASF GitHub Bot commented on ARTEMIS-1762: - Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1969 looks ok to me > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409674#comment-16409674 ] ASF GitHub Bot commented on ARTEMIS-1762: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1969 @andytaylor wdyt Re the checks on the HA policies? Seems safe enough? > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1762) JdbcNodeManager shouldn't be used if no HA is configured
[ https://issues.apache.org/jira/browse/ARTEMIS-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409662#comment-16409662 ] ASF GitHub Bot commented on ARTEMIS-1762: - GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1969 ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured It forces to use InVMNodeManager when no HA option is selected with JDBC persistence and includes the checks that the only valid JDBC HA options are SHARED_STORE_MASTER and SHARED_STORE_SLAVE. You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis no_jdbc_nm_no_ha Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1969.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1969 commit 17c138bf3d5d7784e3c5fb5709fcca15abc0d3a9 Author: Francesco Nigro Date: 2018-03-22T14:51:42Z ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured It forces to use InVMNodeManager when no HA option is selected with JDBC persistence and includes the checks that the only valid JDBC HA options are SHARED_STORE_MASTER and SHARED_STORE_SLAVE. > JdbcNodeManager shouldn't be used if no HA is configured > > > Key: ARTEMIS-1762 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1762 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.5.0 >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Fix For: 2.5.1 > > > JDBC based journal is using a JdbcNodeManager when no HA is configured: > should be better to not have it to avoid unneeded lock table creations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
