[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660779#comment-16660779 ] ASF subversion and git services commented on ARTEMIS-2096: -- Commit d72a7acbb7cdf842ab908a00cbecb8e2ca6b56e7 in activemq-artemis's branch refs/heads/2.6.x from [~gaohoward] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d72a7ac ] ARTEMIS-2135 Test multiple core consumers receiving amqp messages This test can verify an issue fixed by the commit: 7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096) The issue was reported later by users where messages sent by amqp clients are having their body size randomly being zero when received by multiple core consumers. This was also fixed on commit 48e0fc8f42346d96bc809593a150e05a586787e but that was exclusively on 2.6.x branch. (cherry picked from commit f4c93a2860f384ce87e3589012e5278399c550c3) > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660774#comment-16660774 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2383 > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660773#comment-16660773 ] ASF subversion and git services commented on ARTEMIS-2096: -- Commit f4c93a2860f384ce87e3589012e5278399c550c3 in activemq-artemis's branch refs/heads/master from [~gaohoward] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f4c93a2 ] ARTEMIS-2135 Test multiple core consumers receiving amqp messages This test can verify an issue fixed by the commit: 7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096) The issue was reported later by users where messages sent by amqp clients are having their body size randomly being zero when received by multiple core consumers. This was also fixed on commit 48e0fc8f42346d96bc809593a150e05a586787e but that was exclusively on 2.6.x branch. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660768#comment-16660768 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 @gaohoward this is actually ARTEMIS-2135, which I fixed in 2.6.x and added a test. Also verified that @tabish121 ' s refactoring fixed it.. but the actual issue for this test is ARTEMIS-2135. Which I had already fixed in 48e0fc8f42346d96bc809593a150e05a586787ee at 2.6.x. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659984#comment-16659984 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 @clebertsuconic I'll send a PR to 2.6.x but not cherry-pick from this. Because on 2.6.x the fix is by a different commit not the one I mentioned here. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659905#comment-16659905 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 ok will do. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659488#comment-16659488 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 @gaohoward - I wouldn't mention external JIRAs here... - Please find a more inclusive message.. when I do git log, a message such as "Adding a Test" doesn't help much. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656843#comment-16656843 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 agreed I'll remove the NO-JIRA. thx. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656838#comment-16656838 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/2383 This isn't really a NO-JIRA commit if you are adding a test against a specific JIRA is it? No reason I can see to put a NO-JIRA on this instead of just tagging against the JIRA that it is related to. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656824#comment-16656824 ] ASF GitHub Bot commented on ARTEMIS-2096: - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2383 NO-JIRA Adding a test for ARTEMIS-2096 This test can verify an issue fixed by the commit: 7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096) The issue was reported in: https://issues.jboss.org/browse/ENTMQBR-2034 but not reported in Artemis. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis c_2034 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2383 commit 89ef072d80d6d034be73244af05617b2bf3baf36 Author: Howard Gao Date: 2018-10-19T13:40:33Z NO-JIRA Adding a test for ARTEMIS-2096 This test can verify an issue fixed by the commit: 7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096) The issue was reported in: https://issues.jboss.org/browse/ENTMQBR-2034 but not reported in Artemis. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654238#comment-16654238 ] ASF subversion and git services commented on ARTEMIS-2096: -- Commit 48e0fc8f42346d96bc809593a150e05a586787ee in activemq-artemis's branch refs/heads/2.6.x from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=48e0fc8 ] ARTEMIS-2135 Race condition on getProtonMessage / getHeader causing NPE Test was added at commit 48d8a54135732b2b34251f571aa3a5cadc44d3a9 I did not use cherry-pick from master as this is no longer an issue in master after the refactoring done at ARTEMIS-2096. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645219#comment-16645219 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2361 > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645195#comment-16645195 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2361 @tabish121 can you review and merge it please? > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645194#comment-16645194 ] ASF GitHub Bot commented on ARTEMIS-2096: - GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2361 ARTEMIS-2096 Fixing DivertTopicToQueueTest This is fixing the test org.apache.activemq.artemis.tests.integration.amqp.DivertTopicToQueueTest This test was broken because the copy wouldn't use the Buffer view gotten by data.duplicate(). You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-2096 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2361 commit a454316f77b84570483092381016e8305cdeca0b Author: Clebert Suconic Date: 2018-10-10T16:09:40Z ARTEMIS-2096 Fixing DivertTopicToQueueTest This is fixing the test org.apache.activemq.artemis.tests.integration.amqp.DivertTopicToQueueTest This test was broken because the copy wouldn't use the Buffer view gotten by data.duplicate(). > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628763#comment-16628763 ] ASF subversion and git services commented on ARTEMIS-2096: -- Commit a851a8f93f30972d252f2bff0bb3d5847cfd7b5f in activemq-artemis's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a851a8f ] ARTEMIS-2096 Refactor AMQMessage abstraction Major refactoring of the AMQPMessage abstraction to resolve some issue of message corruption still present in the code and improve the API handling of message changes and re-encoding. Improves handling of decoding of message sections limiting the work to only the portions needed and ensuring the state data is always updated with what has been done. Fixes issues of corrupt state on copy of message or other changes in filters. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628766#comment-16628766 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2329 > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1662#comment-1662 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2329 I will run a full testsuite before merging this, given the number of line changes. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627767#comment-16627767 ] ASF GitHub Bot commented on ARTEMIS-2096: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2329 I hope this is not 2.6.x > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2096) AMQP: Refactoring AMQPMessage abstraction for better consistency and performance
[ https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627616#comment-16627616 ] ASF GitHub Bot commented on ARTEMIS-2096: - GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2329 ARTEMIS-2096 Refactor AMQMessage abstraction Major refactoring of the AMQPMessage abstraction to resolve some issue of message corruption still present in the code and improve the API handling of message changes and re-encoding. Improves handling of decoding of message sections limiting the work to only the portions needed and ensuring the state data is always updated with what has been done. Fixes issues of corrupt state on copy of message or other changes in filters. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-2096 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2329.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2329 commit ed7e7f206287db56f0c44c01fa2133c1fbd5c50d Author: Timothy Bish Date: 2018-09-25T16:22:19Z ARTEMIS-2096 Refactor AMQMessage abstraction Major refactoring of the AMQPMessage abstraction to resolve some issue of message corruption still present in the code and improve the API handling of message changes and re-encoding. Improves handling of decoding of message sections limiting the work to only the portions needed and ensuring the state data is always updated with what has been done. Fixes issues of corrupt state on copy of message or other changes in filters. > AMQP: Refactoring AMQPMessage abstraction for better consistency and > performance > > > Key: ARTEMIS-2096 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2096 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 2.7.0 > > > The AMQPMessage abstraction used to wrap the AMQP message section has some > inconsistencies in how it manages the underlying data and the decoded AMQP > section obtained from the Proton-J codec as well as issues with state being > maintained in the presence of changes to the message made through the public > facing Message APIs > A refactoring of the AMQPMessage class to better utilize the proton-j codec > to manage the message data and how it is parsed and re-encoded on change > needs to be done to ensure no corrupt messages are sent and that we are not > decoding and encoding sections of the message we are not intending to read or > change on the sever (We currently can decode message bodies or footer is a > few cases where we intend not to). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
