[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[Justin Bertram (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018988#comment-15018988
 ] 

Justin Bertram commented on ARTEMIS-297:


This looks resolved to me.  Can you confirm, [~martyntaylor]]?

> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991884#comment-14991884
 ] 

ASF GitHub Bot commented on ARTEMIS-297:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/237


> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990987#comment-14990987
 ] 

ASF GitHub Bot commented on ARTEMIS-297:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/234


> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990990#comment-14990990
 ] 

ASF GitHub Bot commented on ARTEMIS-297:


GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/237

ARTEMIS-297 Including acceptor name on logs

This is just so users will know the name of the acceptor that had the issue 
on logs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #237


commit 0ab72f584b80f56b6c4ae9c612aff61253851dfa
Author: Clebert Suconic 
Date:   2015-11-05T02:30:53Z

ARTEMIS-297 Including acceptor name on logs




> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989668#comment-14989668
 ] 

ASF GitHub Bot commented on ARTEMIS-297:


GitHub user mtaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/234

ARTEMIS-297 Handle Exceptions during server stop

Stopping the server should be able to handle exceptions thrown by
individual components.  Before this patch the stop method would throw
any raised exception and exit.  This can lead to partial shutdowns of
the server resulting in leaking threads.  This patch catches any
component exceptions and logs an appropriate error message, allowing the
server to properly shutdown.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-297

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #234


commit b965e7ac2ea5b93073bf20f12e1ea9cad20a1666
Author: Martyn Taylor 
Date:   2015-11-04T12:53:39Z

ARTEMIS-297 Handle Exceptions during server stop

Stopping the server should be able to handle exceptions thrown by
individual components.  Before this patch the stop method would throw
any raised exception and exit.  This can lead to partial shutdowns of
the server resulting in leaking threads.  This patch catches any
component exceptions and logs an appropriate error message, allowing the
server to properly shutdown.




> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-297) Handle exceptions during server stop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989705#comment-14989705
 ] 

ASF GitHub Bot commented on ARTEMIS-297:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/234#issuecomment-153762897
  
Had some inline comments.

Also please rebase against the latest merged I made please?


> Handle exceptions during server stop
> 
>
> Key: ARTEMIS-297
> URL: https://issues.apache.org/jira/browse/ARTEMIS-297
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Martyn Taylor
>
> The server stop method is quite brittle.  If any component throws an 
> exception during shutdown, the exception is thrown and the method exits.  
> Instead the stop method on the server should be able to handle such 
> exceptions and continue shutting down all components and eventually stop the 
> ExecutorServices.  Failure to do so can lead to leaking threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)