[jira] [Commented] (ARTEMIS-4449) [DOC] Fix url parameter separator in acceptor configuration

2023-10-02 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771139#comment-17771139
 ] 

ASF subversion and git services commented on ARTEMIS-4449:
--

Commit 8d48f8a373d03ea6cf84fe79c834934b0ec30684 in activemq-artemis's branch 
refs/heads/main from Nandor Soma Abonyi
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8d48f8a373 ]

ARTEMIS-4449 Fix url parameter separator in acceptor configuration

> [DOC] Fix url parameter separator in acceptor configuration
> ---
>
> Key: ARTEMIS-4449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4449
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Nandor Soma Abonyi
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When simply `&` is used in the xml configuration according to the 
> [documentation|#configuring-netty-ssl], `org.xml.sax.SAXParseException` will 
> occur. Instead `&` or simply `;` should be used. I prefer the latter as the 
> default configuration uses that character anyway.
> Tldr. In case of
> {code:java}
>  name="netty">tcp://localhost:61617?sslEnabled=true&keyStorePath=/path
>  {code}
> this error is raised:
> {code:java}
> Fatal Error] :182:83: The reference to entity "keyStorePath" must end with 
> the ';' delimiter.
> org.xml.sax.SAXParseException; lineNumber: 182; columnNumber: 83; The 
> reference to entity "keyStorePath" must end with the ';' delimiter.
> at 
> java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
> at 
> java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.readerToElement(XMLUtil.java:91)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.streamToElement(XMLUtil.java:64)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.urlToElement(XMLUtil.java:73)
> at 
> org.apache.activemq.artemis.core.config.FileDeploymentManager.readConfiguration(FileDeploymentManager.java:71)
> at 
> org.apache.activemq.artemis.integration.FileBroker.createComponents(FileBroker.java:120)
> at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:119)
> at 
> org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:214)
> at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:164)
> at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
> at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61) 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (ARTEMIS-4449) [DOC] Fix url parameter separator in acceptor configuration

2023-10-02 Thread Nandor Soma Abonyi (Jira) 


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771137#comment-17771137
 ] 

Nandor Soma Abonyi commented on ARTEMIS-4449:
-

I've opened a pull request to fix this: 
[https://github.com/apache/activemq-artemis/pull/4640]

As this is my first pull request in the activemq community, I'm not familiar 
with the processes here. Please tell me if I need to do anything differently.

> [DOC] Fix url parameter separator in acceptor configuration
> ---
>
> Key: ARTEMIS-4449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4449
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Nandor Soma Abonyi
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When simply `&` is used in the xml configuration according to the 
> [documentation|#configuring-netty-ssl], `org.xml.sax.SAXParseException` will 
> occur. Instead `&` or simply `;` should be used. I prefer the latter as the 
> default configuration uses that character anyway.
> Tldr. In case of
> {code:java}
>  name="netty">tcp://localhost:61617?sslEnabled=true&keyStorePath=/path
>  {code}
> this error is raised:
> {code:java}
> Fatal Error] :182:83: The reference to entity "keyStorePath" must end with 
> the ';' delimiter.
> org.xml.sax.SAXParseException; lineNumber: 182; columnNumber: 83; The 
> reference to entity "keyStorePath" must end with the ';' delimiter.
> at 
> java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
> at 
> java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.readerToElement(XMLUtil.java:91)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.streamToElement(XMLUtil.java:64)
> at 
> org.apache.activemq.artemis.utils.XMLUtil.urlToElement(XMLUtil.java:73)
> at 
> org.apache.activemq.artemis.core.config.FileDeploymentManager.readConfiguration(FileDeploymentManager.java:71)
> at 
> org.apache.activemq.artemis.integration.FileBroker.createComponents(FileBroker.java:120)
> at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:119)
> at 
> org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:214)
> at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:164)
> at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
> at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61) 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)