[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764289#comment-15764289
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit 63f723fe8d341be47fc03c1f16abd62f7e30ec91 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=63f723f ]

ARTEMIS-888 - default to false if header durable not set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764291#comment-15764291
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/938


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764290#comment-15764290
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit 63f723fe8d341be47fc03c1f16abd62f7e30ec91 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=63f723f ]

ARTEMIS-888 - default to false if header durable not set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764018#comment-15764018
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/938
  
These failures look unrelated


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763754#comment-15763754
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/938

ARTEMIS-888 - default to false if header durable not set

https://issues.apache.org/jira/browse/ARTEMIS-888

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #938


commit 63f723fe8d341be47fc03c1f16abd62f7e30ec91
Author: Andy Taylor 
Date:   2016-12-20T09:32:33Z

ARTEMIS-888 - default to false if header durable not set

https://issues.apache.org/jira/browse/ARTEMIS-888




> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[Andy Taylor (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763742#comment-15763742
 ] 

Andy Taylor commented on ARTEMIS-888:
-

thanks Tim I will get that fixed

> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[Timothy Bish (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15762441#comment-15762441
 ] 

Timothy Bish commented on ARTEMIS-888:
--

After a closer look and some testing the applied fix is still incorrect, the 
fix wrongly assumes that a Header with a null value for durable should set the 
message durability to Message.DEFAULT_DELIVERY_MODE which is of course 
PERSISTENT while the AMQP specification states the default for this field in 
false (non-durable).

The problematic code is here:

{code}
 if (header.getDurable() != null) {
jms.setBooleanProperty(JMS_AMQP_HEADER_DURABLE, true);
jms.setJMSDeliveryMode(header.getDurable().booleanValue() ? 
DeliveryMode.PERSISTENT : DeliveryMode.NON_PERSISTENT);
 } else {
jms.setJMSDeliveryMode(Message.DEFAULT_DELIVERY_MODE);
 }
{code}

And should be 

{code}
 if (header.getDurable() != null) {
jms.setBooleanProperty(JMS_AMQP_HEADER_DURABLE, true);
jms.setJMSDeliveryMode(header.getDurable().booleanValue() ? 
DeliveryMode.PERSISTENT : DeliveryMode.NON_PERSISTENT);
 } else {
jms.setJMSDeliveryMode(DeliveryMode.NON_PERSISTENT);
 }
{code}


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751345#comment-15751345
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit 3b75c954135fdc58b172a381403cb7daa223b602 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3b75c95 ]

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751346#comment-15751346
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit 3b75c954135fdc58b172a381403cb7daa223b602 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3b75c95 ]

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751347#comment-15751347
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/917


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750622#comment-15750622
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user andytaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/917
  
fixed


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750123#comment-15750123
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/917
  
@andytaylor there's a conflict now anyways after a merge I did for 
@jbertram .. can you fix it?


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749672#comment-15749672
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/917
  
This change seems to better address the underlying issue that was to be 
fixed, it does ignore the other fields in the Header which could be an issue if 
anyone were to apply the same types of checks for those being exactly preserved 
as opposed to their defaults being assumed. 


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749311#comment-15749311
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/917
  
@tabish121 can you take a look?


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748825#comment-15748825
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/917

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #917


commit 20e10595d55756c520746082139323129e606a6c
Author: Andy Taylor 
Date:   2016-12-14T16:09:36Z

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888




> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748693#comment-15748693
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/916


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748692#comment-15748692
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit 08e0c5e4f1c34b6fe82bf232ce87fd5bc774def4 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=08e0c5e ]

Revert "ARTEMIS-888 - AMQP headers arent always set"

This reverts commit d471f6b15fab7d7afad8e34635869df18ac0cef4.


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748573#comment-15748573
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user gemmellr commented on the issue:

https://github.com/apache/activemq-artemis/pull/915
  
Ideally a client would receive what it sends in most cases, though for the 
header there is scope for change given its a mutable section. The durability 
and priority wouldnt typically change of course. Theres no logical difference 
between e.g not having the header section, and having one without the priority 
field set, or having it set to 4 which is the default when not present. 
Similarly with the durability (which defaults to false unlike JMS).


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748477#comment-15748477
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/916

ARTEMIS-888 removed a rule, that is inconsistent with these teste, he…

…nce I'm removing them

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis artemis-888

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #916


commit b3e4a90cbd028dabf3a372c48fbb67438be56f78
Author: Clebert Suconic 
Date:   2016-12-14T14:34:56Z

ARTEMIS-888 removed a rule, that is inconsistent with these teste, hence 
I'm removing them




> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748452#comment-15748452
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user tabish121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/915
  
So what are you trying to fix here exactly?  If the values are defaults the 
there isn't actually a need to send the header and incur the overhead of 
encoding it.  Also since Artemis converts all incoming AMQP messages if the 
original message had no header then it'd be preferable to not add one even 
though the Header is technically mutable.  


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748447#comment-15748447
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit d471f6b15fab7d7afad8e34635869df18ac0cef4 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d471f6b ]

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748446#comment-15748446
 ] 

ASF subversion and git services commented on ARTEMIS-888:
-

Commit d471f6b15fab7d7afad8e34635869df18ac0cef4 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d471f6b ]

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748448#comment-15748448
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/915


> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-888) AMQP headers arent always set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748369#comment-15748369
 ] 

ASF GitHub Bot commented on ARTEMIS-888:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/915

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/915.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #915


commit 2759ddce3d3b03fe77d1d145b2e3f63a3921b92a
Author: Andy Taylor 
Date:   2016-12-14T13:43:19Z

ARTEMIS-888 - AMQP headers arent always set

https://issues.apache.org/jira/browse/ARTEMIS-888




> AMQP headers arent always set
> -
>
> Key: ARTEMIS-888
> URL: https://issues.apache.org/jira/browse/ARTEMIS-888
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 1.5.1
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> durable header gets ignored when false and priority gets ignored when the 
> default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)