[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032872#comment-15032872 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/254 > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032871#comment-15032871 ] ASF subversion and git services commented on ARTEMIS-93: Commit 3357ca5542f82912030d0620a9ff1301bf61a570 in activemq-artemis's branch refs/heads/master from [~ch...@die-schneider.net] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3357ca5 ] ARTEMIS-93 Add default config to feature > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031949#comment-15031949 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user cschneider commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160659926 Btw. I really like the Jenkins integration with the pull request. I must find out how to also support this in CXF, Aries and Karaf. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031923#comment-15031923 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160656945 I have no issues with the failed builds (I send failed builds myself all the time)... I was just letting you know about the -Pdev profile. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031908#comment-15031908 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user cschneider commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160655548 Ok for me to build with the profile. In any case you can ignore my pull requests until jenkins likes them :-) I will also make sure to then squash my commits into a single one so there is not to much noise in the commits. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031889#comment-15031889 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160652950 It's ok to add ignores on the rat check for such things. yeah. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031888#comment-15031888 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160652674 @cschneider I always preferred on by default, we disabled it because of discussions on the dev list... someone downloading the source distribution would prefer making changes without being bound to checkstyle and other things.. so it was "decided" devs should use the dev profile. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031861#comment-15031861 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user cschneider commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160649094 Sorry.. forgot to use the profile again. I will make sure I run it from now on. Btw. The checks only seem to take 10 seconds for the whole build. Wouldn't it make sense to include them in mvn install? In this case I excluded the org.apache.activemq.artemis.cfg from the rat check as I think it does not make sense to add a license to a 3 line cfg. Is this ok? > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031826#comment-15031826 ] ASF GitHub Bot commented on ARTEMIS-93: --- Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/254#issuecomment-160644417 when you build, you should do: mvn -Pdev install That will activate checks > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031802#comment-15031802 ] ASF GitHub Bot commented on ARTEMIS-93: --- GitHub user cschneider opened a pull request: https://github.com/apache/activemq-artemis/pull/254 ARTEMIS-93 Add default config to feature Adds default configs to the feature so a broker is created automatically when the feature is installed. This also fixes a bug in the feature file I introduced by placing the license header in the wrong position. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cschneider/activemq-artemis OSGi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #254 commit 6cb1a1c80ad17b0615a1ed68aa1071bff19ebf87 Author: Christian Schneider Date: 2015-11-30T14:02:04Z ARTEMIS-93 Add default config to feature > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976723#comment-14976723 ] Hiram Chirino commented on ARTEMIS-93: -- I think going non-uber adds even more requirements than the simple 'make artemis modular'. It adds the requirement that you have to support dynamically reloadable modules. Most DI systems seem to break down under that requirement since they expect the classes of injected instances to stay loaded. So I would just classify the non-uber requirement as nice to have if it can be done in a way that does not impact the maintainability of the broker much. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976699#comment-14976699 ] Justin Bertram commented on ARTEMIS-93: --- [~ch...@die-schneider.net], I think that would be great. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976672#comment-14976672 ] Christian Schneider commented on ARTEMIS-93: Are you interested that I help with the OSGi enabling? > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696533#comment-14696533 ] Christian Schneider commented on ARTEMIS-93: I fully agree with Dan. OSGi is al about modularity. So making each module a bundle will be much more in the spirit of OSGi. Like always the big problem is how to find and wire modules together. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.3.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.3.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638801#comment-14638801 ] Daniel Kulp commented on ARTEMIS-93: Please don't go that route... if OSGi support can be added properly without the uber jar, please do so. The uberjar is a major hack that had to be done due to problems (like packages in multiple jars). > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.1.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.1.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-93) OSGI support
[ https://issues.apache.org/jira/browse/ARTEMIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638774#comment-14638774 ] clebert suconic commented on ARTEMIS-93: What I believe we really need (based on what AMQ5 does) is a big Uber JAR only. > OSGI support > > > Key: ARTEMIS-93 > URL: https://issues.apache.org/jira/browse/ARTEMIS-93 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 1.1.0 >Reporter: clebert suconic >Priority: Critical > Fix For: 1.1.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
