[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=886297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886297 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 20/Oct/23 05:55 Start Date: 20/Oct/23 05:55 Worklog Time Spent: 10m Work Description: jbonofre commented on PR #700: URL: https://github.com/apache/activemq/pull/700#issuecomment-1772127159 It will be superseeded by another PR related to AMQ-9349 Issue Time Tracking --- Worklog Id: (was: 886297) Time Spent: 2h (was: 1h 50m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=886298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886298 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 20/Oct/23 05:55 Start Date: 20/Oct/23 05:55 Worklog Time Spent: 10m Work Description: jbonofre closed pull request #700: [AMQ-8316] Remove unused BrokerService methods URL: https://github.com/apache/activemq/pull/700 Issue Time Tracking --- Worklog Id: (was: 886298) Time Spent: 2h 10m (was: 2h) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=850873=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850873 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 14/Mar/23 11:08 Start Date: 14/Mar/23 11:08 Worklog Time Spent: 10m Work Description: cshannon merged PR #988: URL: https://github.com/apache/activemq/pull/988 Issue Time Tracking --- Worklog Id: (was: 850873) Time Spent: 1h 50m (was: 1h 40m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=850851=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850851 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 14/Mar/23 10:15 Start Date: 14/Mar/23 10:15 Worklog Time Spent: 10m Work Description: jbonofre commented on PR #988: URL: https://github.com/apache/activemq/pull/988#issuecomment-1467805680 @cshannon I committed your suggestions. Please let me know if I can squash & merge. Issue Time Tracking --- Worklog Id: (was: 850851) Time Spent: 1h 40m (was: 1.5h) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[
https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=850849=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850849
]
ASF GitHub Bot logged work on AMQ-8316:
---
Author: ASF GitHub Bot
Created on: 14/Mar/23 10:07
Start Date: 14/Mar/23 10:07
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #988:
URL: https://github.com/apache/activemq/pull/988#discussion_r1135294050
##
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+@Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+@Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+@Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+/**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+@Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+@Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+@Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+@Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+/**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+@Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+/**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+@Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=850845=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850845 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 14/Mar/23 09:58 Start Date: 14/Mar/23 09:58 Worklog Time Spent: 10m Work Description: jbonofre commented on PR #988: URL: https://github.com/apache/activemq/pull/988#issuecomment-1467772527 @cshannon can you please take a look ? Thanks ! Issue Time Tracking --- Worklog Id: (was: 850845) Time Spent: 1h 20m (was: 1h 10m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=669683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669683 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 25/Oct/21 17:55 Start Date: 25/Oct/21 17:55 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #700: URL: https://github.com/apache/activemq/pull/700#issuecomment-951164437 Resuming review on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 669683) Time Spent: 1h 10m (was: 1h) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=645993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645993 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 02/Sep/21 19:11 Start Date: 02/Sep/21 19:11 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #700: URL: https://github.com/apache/activemq/pull/700#issuecomment-911977951 @ehossack-aws it makes sense, thanks. I will take a look then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 645993) Time Spent: 1h (was: 50m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=645992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645992 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 02/Sep/21 19:06 Start Date: 02/Sep/21 19:06 Worklog Time Spent: 10m Work Description: ehossack-aws commented on pull request #700: URL: https://github.com/apache/activemq/pull/700#issuecomment-911974389 @mattrpav , @jbonofre I created a pull on the website to begin collecting changes for 5.17 - https://github.com/apache/activemq-website/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 645992) Time Spent: 50m (was: 40m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=640791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640791 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 23/Aug/21 17:49 Start Date: 23/Aug/21 17:49 Worklog Time Spent: 10m Work Description: ehossack-aws commented on a change in pull request #700: URL: https://github.com/apache/activemq/pull/700#discussion_r694184042 ## File path: activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java ## @@ -153,9 +153,7 @@ private boolean useLoggingForShutdownErrors; private boolean shutdownOnMasterFailure; private boolean shutdownOnSlaveFailure; -private boolean waitForSlave; private long waitForSlaveTimeout = DEFAULT_START_TIMEOUT; Review comment: I thnk so. I recall going through all the properties, but maybe I missed this one because the name was so similar - I can't find any references to it in the codebase or where an embedded broker might use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640791) Time Spent: 40m (was: 0.5h) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=640790=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640790 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 23/Aug/21 17:46 Start Date: 23/Aug/21 17:46 Worklog Time Spent: 10m Work Description: ehossack-aws commented on pull request #700: URL: https://github.com/apache/activemq/pull/700#issuecomment-903980616 > We probably should create a web page for 5.17.0 changes. This is going to remove config parameters from the XSD and generated xbean properties. I'll create a parallel PR for that later this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640790) Time Spent: 0.5h (was: 20m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=640396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640396 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 20/Aug/21 21:17 Start Date: 20/Aug/21 21:17 Worklog Time Spent: 10m Work Description: mattrpav commented on a change in pull request #700: URL: https://github.com/apache/activemq/pull/700#discussion_r693222941 ## File path: activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java ## @@ -153,9 +153,7 @@ private boolean useLoggingForShutdownErrors; private boolean shutdownOnMasterFailure; private boolean shutdownOnSlaveFailure; -private boolean waitForSlave; private long waitForSlaveTimeout = DEFAULT_START_TIMEOUT; Review comment: If waitForSlave can be removed, can waitForSlaveTimeout also be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640396) Time Spent: 20m (was: 10m) > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-8316) Remove deprecated BrokerService methods
[ https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=640389=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640389 ] ASF GitHub Bot logged work on AMQ-8316: --- Author: ASF GitHub Bot Created on: 20/Aug/21 20:55 Start Date: 20/Aug/21 20:55 Worklog Time Spent: 10m Work Description: ehossack-aws opened a new pull request #700: URL: https://github.com/apache/activemq/pull/700 This removes passiveSlave and waitForSlave which are no longer used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 640389) Remaining Estimate: 0h Time Spent: 10m > Remove deprecated BrokerService methods > > > Key: AMQ-8316 > URL: https://issues.apache.org/jira/browse/AMQ-8316 > Project: ActiveMQ > Issue Type: Sub-task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Legacy BrokerService methods are unused and should be removed > Methods targeted for removal: > isWaitForSlave() -- This message was sent by Atlassian Jira (v8.3.4#803005)
