[jira] [Work logged] (ARTEMIS-1691) JMS Bridge: After the FailureHandler exits, a bridge cannot be started full functional anymore

2024-04-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1691?focusedWorklogId=914774=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914774
 ]

ASF GitHub Bot logged work on ARTEMIS-1691:
---

Author: ASF GitHub Bot
Created on: 16/Apr/24 03:49
Start Date: 16/Apr/24 03:49
Worklog Time Spent: 10m 
  Work Description: clebertsuconic merged PR #4883:
URL: https://github.com/apache/activemq-artemis/pull/4883




Issue Time Tracking
---

Worklog Id: (was: 914774)
Time Spent: 20m  (was: 10m)

> JMS Bridge: After the FailureHandler exits, a bridge cannot be started full 
> functional anymore
> --
>
> Key: ARTEMIS-1691
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1691
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
> Environment: WildFly Servers.
>Reporter: Markus F
>Assignee: Justin Bertram
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> h4. Setup
> JMSBridge on server a pulls messages from a remote server B.
> failureRetryInterval = 1 sec
> maxRetries = 1
> h4. To Reproduce
> Restart the remote server (need to take more than one second.)
> JMS Bridge prints out:
> {noformat}
> JMS Bridge unable to set up connections, bridge will be stopped{noformat}
> After the remote server is up again, start the bridge again.
> JMS Bridge prints out:
> {noformat}
> Started JMS Bridge testbridge{noformat} 
> h4. Result:
> The bridge is started, but does still not consume messages. 
> h4. Reason
> In {{JMSBridgeImpl}} line 1624, the failed boolean parameter is checked. It 
> is not set to true anywhere outside the failure handlers ({{FailureHandler}} 
> and {{StartupFailureHandler}}) or on initial adding of the bridge.
> But the {{FailureHandler}} has already exited. So the bridge will wait all 
> time long for 500 ms in line 1626. 
> h4. Solution
> I would add a
> {code:java}
> failed = false;{code}
> after line 403.
> I don't know how the release process is handled here, if I can make a pull 
> request or something like that, I will do, if it is needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-1691) JMS Bridge: After the FailureHandler exits, a bridge cannot be started full functional anymore

2024-04-12 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1691?focusedWorklogId=914472=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914472
 ]

ASF GitHub Bot logged work on ARTEMIS-1691:
---

Author: ASF GitHub Bot
Created on: 12/Apr/24 20:36
Start Date: 12/Apr/24 20:36
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4883:
URL: https://github.com/apache/activemq-artemis/pull/4883

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 914472)
Remaining Estimate: 0h
Time Spent: 10m

> JMS Bridge: After the FailureHandler exits, a bridge cannot be started full 
> functional anymore
> --
>
> Key: ARTEMIS-1691
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1691
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.4.0
> Environment: WildFly Servers.
>Reporter: Markus F
>Assignee: Justin Bertram
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> h4. Setup
> JMSBridge on server a pulls messages from a remote server B.
> failureRetryInterval = 1 sec
> maxRetries = 1
> h4. To Reproduce
> Restart the remote server (need to take more than one second.)
> JMS Bridge prints out:
> {noformat}
> JMS Bridge unable to set up connections, bridge will be stopped{noformat}
> After the remote server is up again, start the bridge again.
> JMS Bridge prints out:
> {noformat}
> Started JMS Bridge testbridge{noformat} 
> h4. Result:
> The bridge is started, but does still not consume messages. 
> h4. Reason
> In {{JMSBridgeImpl}} line 1624, the failed boolean parameter is checked. It 
> is not set to true anywhere outside the failure handlers ({{FailureHandler}} 
> and {{StartupFailureHandler}}) or on initial adding of the bridge.
> But the {{FailureHandler}} has already exited. So the bridge will wait all 
> time long for 500 ms in line 1626. 
> h4. Solution
> I would add a
> {code:java}
> failed = false;{code}
> after line 403.
> I don't know how the release process is handled here, if I can make a pull 
> request or something like that, I will do, if it is needed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)