[jira] [Work logged] (ARTEMIS-2806) deployQueue missing address argument
[ https://issues.apache.org/jira/browse/ARTEMIS-2806?focusedWorklogId=450594=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450594 ] ASF GitHub Bot logged work on ARTEMIS-2806: --- Author: ASF GitHub Bot Created on: 24/Jun/20 19:35 Start Date: 24/Jun/20 19:35 Worklog Time Spent: 10m Work Description: asfgit closed pull request #3185: URL: https://github.com/apache/activemq-artemis/pull/3185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 450594) Time Spent: 50m (was: 40m) > deployQueue missing address argument > > > Key: ARTEMIS-2806 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2806 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.12.0 >Reporter: Qihong Xu >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > In ActiveMQServerControlImpl, deployQueue method is missing address argument > which results in creating non-matched addresses and queues. (For example, > using deployQueue to create a subscriber A_0 under existing address A, it > finally returns a new topic A_0 with a subscriber A_0 ) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2806) deployQueue missing address argument
[ https://issues.apache.org/jira/browse/ARTEMIS-2806?focusedWorklogId=446326=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446326 ] ASF GitHub Bot logged work on ARTEMIS-2806: --- Author: ASF GitHub Bot Created on: 16/Jun/20 06:58 Start Date: 16/Jun/20 06:58 Worklog Time Spent: 10m Work Description: qihongxu commented on pull request #3185: URL: https://github.com/apache/activemq-artemis/pull/3185#issuecomment-644571568 > We certainly want to fix this bug, but it's worth noting that all versions of `deployQueue` are deprecated so I recommend you migrate to `createQueue` as soon as possible. Furthermore, there are no actual tests for `deployQueue` which is almost certainly why this bug was not caught. Thanks for your advice! This bug is caught coincidently when we tried to upgrade some artemis servers to newer version. Although deployQueue is deprecated, I checked the commit log and found it was modified 2 months ago. We will migrate to createQueue in our projects. This pr is just for someone that might still use legacy methods as we do. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446326) Time Spent: 40m (was: 0.5h) > deployQueue missing address argument > > > Key: ARTEMIS-2806 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2806 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.12.0 >Reporter: Qihong Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > In ActiveMQServerControlImpl, deployQueue method is missing address argument > which results in creating non-matched addresses and queues. (For example, > using deployQueue to create a subscriber A_0 under existing address A, it > finally returns a new topic A_0 with a subscriber A_0 ) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2806) deployQueue missing address argument
[ https://issues.apache.org/jira/browse/ARTEMIS-2806?focusedWorklogId=446246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446246 ] ASF GitHub Bot logged work on ARTEMIS-2806: --- Author: ASF GitHub Bot Created on: 16/Jun/20 02:39 Start Date: 16/Jun/20 02:39 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #3185: URL: https://github.com/apache/activemq-artemis/pull/3185#issuecomment-644495829 We certainly want to fix this bug, but it's worth noting that all versions of `deployQueue` are deprecated so I recommend you migrate to `createQueue` as soon as possible. Furthermore, there are no actual tests for `deployQueue` which is almost certainly why this bug was not caught. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446246) Time Spent: 0.5h (was: 20m) > deployQueue missing address argument > > > Key: ARTEMIS-2806 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2806 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.12.0 >Reporter: Qihong Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > In ActiveMQServerControlImpl, deployQueue method is missing address argument > which results in creating non-matched addresses and queues. (For example, > using deployQueue to create a subscriber A_0 under existing address A, it > finally returns a new topic A_0 with a subscriber A_0 ) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2806) deployQueue missing address argument
[
https://issues.apache.org/jira/browse/ARTEMIS-2806?focusedWorklogId=446244=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446244
]
ASF GitHub Bot logged work on ARTEMIS-2806:
---
Author: ASF GitHub Bot
Created on: 16/Jun/20 02:36
Start Date: 16/Jun/20 02:36
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3185:
URL: https://github.com/apache/activemq-artemis/pull/3185#discussion_r440552355
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
##
@@ -952,6 +952,7 @@ public void deployQueue(final String address,
clearIO();
try {
server.createQueue(new QueueConfiguration(name)
+.setAddress(address)
.setName(name)
Review comment:
You can actually remove `setName(name)` as this is already taken care of
by passing `name` to the constructor. The bug here is that `setName(name)` is
actually called instead of `setAddress(address)`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 446244)
Time Spent: 20m (was: 10m)
> deployQueue missing address argument
>
>
> Key: ARTEMIS-2806
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2806
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.12.0
>Reporter: Qihong Xu
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In ActiveMQServerControlImpl, deployQueue method is missing address argument
> which results in creating non-matched addresses and queues. (For example,
> using deployQueue to create a subscriber A_0 under existing address A, it
> finally returns a new topic A_0 with a subscriber A_0 )
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2806) deployQueue missing address argument
[ https://issues.apache.org/jira/browse/ARTEMIS-2806?focusedWorklogId=446229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446229 ] ASF GitHub Bot logged work on ARTEMIS-2806: --- Author: ASF GitHub Bot Created on: 16/Jun/20 02:10 Start Date: 16/Jun/20 02:10 Worklog Time Spent: 10m Work Description: qihongxu opened a new pull request #3185: URL: https://github.com/apache/activemq-artemis/pull/3185 In ActiveMQServerControlImpl, deployQueue method is missing address argument which results in creating non-matched addresses and queues. (For example, using deployQueue to create a subscriber A_0 under existing address A, it finally returns a new topic A_0 with a subscriber A_0 ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 446229) Remaining Estimate: 0h Time Spent: 10m > deployQueue missing address argument > > > Key: ARTEMIS-2806 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2806 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.12.0 >Reporter: Qihong Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > In ActiveMQServerControlImpl, deployQueue method is missing address argument > which results in creating non-matched addresses and queues. (For example, > using deployQueue to create a subscriber A_0 under existing address A, it > finally returns a new topic A_0 with a subscriber A_0 ) -- This message was sent by Atlassian Jira (v8.3.4#803005)
