[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449687=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449687
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 23/Jun/20 08:38
Start Date: 23/Jun/20 08:38
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647997888
@Havret merged thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449687)
Time Spent: 2h 50m (was: 2h 40m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449686
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 23/Jun/20 08:37
Start Date: 23/Jun/20 08:37
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449686)
Time Spent: 2h 40m (was: 2.5h)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449571
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 23/Jun/20 00:49
Start Date: 23/Jun/20 00:49
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647841459
@michaelandrepearce cool.. I will start the release tomorrow. I will wait a
final review from you tomorrow, or if you don't merge it by then I will do it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449571)
Time Spent: 2.5h (was: 2h 20m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449496=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449496
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 21:15
Start Date: 22/Jun/20 21:15
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647772843
@michaelandrepearce @clebertsuconic I've pushed the changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449496)
Time Spent: 2h 20m (was: 2h 10m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449258
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 13:53
Start Date: 22/Jun/20 13:53
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647533882
@clebertsuconic setLastValueKey needs to be fixed, I believe @Havret is
looking to push a fix on that tonight or tomorrow.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449258)
Time Spent: 2h 10m (was: 2h)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449245
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 13:42
Start Date: 22/Jun/20 13:42
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647527301
LGTM...
@michaelandrepearce I'm not merging this as I'm not sure if you settled your
discussion here. if you could merge when done please.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449245)
Time Spent: 2h (was: 1h 50m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449075
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:28
Start Date: 22/Jun/20 08:28
Worklog Time Spent: 10m
Work Description: michaelpearce-gain edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
These are hard coded, because the QueueImpl doesnt support LVQ (theres a
special extended version, as such its not possible atm to update (you have to
remove and re add a queue currently) This is something though that could be
rolled into a single queue, and make it updateable, i had a poc a while back,
just never got time to finish it. And no one is shouting for it so like all
things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue
and back, without distruction.
In particular to the setLastValue(null), that should be
setLastValueKey(null) thats just a mistake in the move to queueConfig recently,
feel free to fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449075)
Time Spent: 1h 50m (was: 1h 40m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449074=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449074
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:27
Start Date: 22/Jun/20 08:27
Worklog Time Spent: 10m
Work Description: michaelpearce-gain edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ (theres a special extended
version, as such its not possible atm to update (you have to remove and re add
a queue currently) This is something though that could be rolled into a single
queue, and make it updateable, i had a poc a while back, just never got time to
finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue
and back, without distruction.
In particular to the setLastValue(null), that should be
setLastValueKey(null) thats just a mistake in the move to queueConfig recently,
feel free to fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449074)
Time Spent: 1h 40m (was: 1.5h)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449073
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:26
Start Date: 22/Jun/20 08:26
Worklog Time Spent: 10m
Work Description: michaelpearce-gain edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ, theres a special extended
version, as such its not possible atm to update (you have to remove and re add
a queue currently) This is something though that could be rolled into a single
queue, and make it updateable, i had a poc a while back, just never got time to
finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue
and back, without distruction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449073)
Time Spent: 1.5h (was: 1h 20m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449072=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449072
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:25
Start Date: 22/Jun/20 08:25
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ, theres a special extended
version, as such its not possible atm to update (you have to remove and re add
a queue currently) This is something though that could be rolled into a single
queue, and make it updateable, i had a poc a while back, just never got time to
finish it. And no one is shouting for it so like all things prioritised down.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449072)
Time Spent: 1h 20m (was: 1h 10m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449070
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:22
Start Date: 22/Jun/20 08:22
Worklog Time Spent: 10m
Work Description: brusdev commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647364727
@Havret I guess the second one should be .setLastValueKey(null). @jbertram
WDYT?
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 449070)
Time Spent: 1h 10m (was: 1h)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448876
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 21/Jun/20 07:52
Start Date: 21/Jun/20 07:52
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647093196
BTW, what's about with this -->
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448876)
Time Spent: 1h (was: 50m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448874=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448874
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 21/Jun/20 07:12
Start Date: 21/Jun/20 07:12
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647089134
Thanks Mike, fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448874)
Time Spent: 50m (was: 40m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448867=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448867
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 21/Jun/20 06:16
Start Date: 21/Jun/20 06:16
Worklog Time Spent: 10m
Work Description: michaelandrepearce edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can do it simpler with
filter == null ? null : filter.getFilterString():
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448867)
Time Spent: 40m (was: 0.5h)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448865
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 21/Jun/20 06:15
Start Date: 21/Jun/20 06:15
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can inline it by filter == null ? null : filter.getFilterString():
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448865)
Time Spent: 20m (was: 10m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448866=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448866
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 21/Jun/20 06:15
Start Date: 21/Jun/20 06:15
Worklog Time Spent: 10m
Work Description: michaelandrepearce edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647084241
You can inline it by
filter == null ? null : filter.getFilterString():
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448866)
Time Spent: 0.5h (was: 20m)
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2815) Null pointer exception on queue update
[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=448833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448833
]
ASF GitHub Bot logged work on ARTEMIS-2815:
---
Author: ASF GitHub Bot
Created on: 20/Jun/20 22:20
Start Date: 20/Jun/20 22:20
Worklog Time Spent: 10m
Work Description: Havret opened a new pull request #3195:
URL: https://github.com/apache/activemq-artemis/pull/3195
I'm not sure if there more elegant way to do it in Java. Any hints would be
greatly appreciated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 448833)
Remaining Estimate: 0h
Time Spent: 10m
> Null pointer exception on queue update
> --
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.13.0
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
