[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=570333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570333 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 23/Mar/21 09:48 Start Date: 23/Mar/21 09:48 Worklog Time Spent: 10m Work Description: gtully merged pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 570333) Time Spent: 5h 20m (was: 5h 10m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_management-message-attribute-size-limit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566931 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 16/Mar/21 13:14 Start Date: 16/Mar/21 13:14 Worklog Time Spent: 10m Work Description: gtully commented on pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#issuecomment-800247321 I think this is good to go. the core api remains intact and the overrides with limits are used from the jmx/control points to enforce the limits that can protect the broker and UI's. Thanks for the feedback! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566931) Time Spent: 5h 10m (was: 5h) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_management-message-attribute-size-limit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566923
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 13:04
Start Date: 16/Mar/21 13:04
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595147730
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -706,9 +707,10 @@ default long getWholeMessageSize() {
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
- default Map toMap() {
Review comment:
oops miss-read sorry, re read it and youre sorting it, cool.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566923)
Time Spent: 4h 50m (was: 4h 40m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566924
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 13:04
Start Date: 16/Mar/21 13:04
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595147905
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Review comment:
providing overrides with the limit leaves existing api as now. that is
better. thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566924)
Time Spent: 5h (was: 4h 50m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566919
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 13:01
Start Date: 16/Mar/21 13:01
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595145487
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -706,9 +707,10 @@ default long getWholeMessageSize() {
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
- default Map toMap() {
Review comment:
yep. sorted. toMap is now untouched.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566919)
Time Spent: 4h 40m (was: 4.5h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566914
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 12:58
Start Date: 16/Mar/21 12:58
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595143402
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -706,9 +707,10 @@ default long getWholeMessageSize() {
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
- default Map toMap() {
Review comment:
Yes but this is in interface, we have to keep toMap()
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566914)
Time Spent: 4h 20m (was: 4h 10m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566916
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 12:58
Start Date: 16/Mar/21 12:58
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595143659
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/CoreTransactionDetail.java
##
@@ -56,6 +56,6 @@ public String decodeMessageType(Message msg) {
@Override
public Map decodeMessageProperties(Message msg) {
- return msg.toMap();
+ return msg.toMap(256);
Review comment:
yep. that is back to the original
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566916)
Time Spent: 4.5h (was: 4h 20m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566911
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 12:56
Start Date: 16/Mar/21 12:56
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595142054
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/CoreTransactionDetail.java
##
@@ -56,6 +56,6 @@ public String decodeMessageType(Message msg) {
@Override
public Map decodeMessageProperties(Message msg) {
- return msg.toMap();
+ return msg.toMap(256);
Review comment:
Yes but this is decode and isnt just for ui
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566911)
Time Spent: 4h 10m (was: 4h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566909 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 16/Mar/21 12:55 Start Date: 16/Mar/21 12:55 Worklog Time Spent: 10m Work Description: michaelpearce-gain commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595141369 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -127,6 +127,8 @@ public static final boolean DEFAULT_ENABLE_METRICS = true; + public static final int MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT = 256; Review comment: i cannot resolve my comment but treat this as resolved. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566909) Time Spent: 4h (was: 3h 50m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 4h > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566841 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 16/Mar/21 10:13 Start Date: 16/Mar/21 10:13 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r595028470 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -253,6 +255,8 @@ private Boolean enableMetrics = null; + private Integer managementMessageAttributeSizeLimit = AddressSettings.MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT; Review comment: ok, that makes sense. thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566841) Time Spent: 3h 50m (was: 3h 40m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566807
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 09:16
Start Date: 16/Mar/21 09:16
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594986451
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Map map = new HashMap<>();
for (SimpleString name : getPropertyNames()) {
Object value = getObjectProperty(name.toString());
//some property is SimpleString, which is not available for
management console
if (value instanceof SimpleString) {
value = value.toString();
}
+ value = truncate(value, valueSizeLimit);
map.put(name.toString(), value);
}
return map;
}
+ static Object truncate(final Object value, final int valueSizeLimit) {
Review comment:
fair, will fix.
thanks for all the feedback, it is fantastic.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566807)
Time Spent: 3h 40m (was: 3.5h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566806
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 09:16
Start Date: 16/Mar/21 09:16
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594986031
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -706,9 +707,10 @@ default long getWholeMessageSize() {
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
- default Map toMap() {
Review comment:
the override will sort that and split usage between those who care and
those who don't.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566806)
Time Spent: 3.5h (was: 3h 20m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566805 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 16/Mar/21 09:14 Start Date: 16/Mar/21 09:14 Worklog Time Spent: 10m Work Description: gtully commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594985042 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -127,6 +127,8 @@ public static final boolean DEFAULT_ENABLE_METRICS = true; + public static final int MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT = 256; Review comment: nope. If there is a 1k property, we don't want that 1k on the browser or on the jmx command line as ascii. The fact that we currently display the full values is a bug imho. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566805) Time Spent: 3h 20m (was: 3h 10m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566803
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 09:13
Start Date: 16/Mar/21 09:13
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594983949
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/CoreTransactionDetail.java
##
@@ -56,6 +56,6 @@ public String decodeMessageType(Message msg) {
@Override
public Map decodeMessageProperties(Message msg) {
- return msg.toMap();
+ return msg.toMap(256);
Review comment:
on the default. I want the broker to be constrained by default but yes
the focus is the management api b/c that returns all the data. I want to fix it
such that the broker returns 'some' reasonable amount of data to
ui/management/control by default.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566803)
Time Spent: 3h 10m (was: 3h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566799
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 09:12
Start Date: 16/Mar/21 09:12
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594982852
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Map map = new HashMap<>();
for (SimpleString name : getPropertyNames()) {
Object value = getObjectProperty(name.toString());
//some property is SimpleString, which is not available for
management console
if (value instanceof SimpleString) {
value = value.toString();
}
+ value = truncate(value, valueSizeLimit);
map.put(name.toString(), value);
}
return map;
}
+ static Object truncate(final Object value, final int valueSizeLimit) {
+ Object result = value;
+ if (valueSizeLimit > 0) {
Review comment:
ok, -1 it will be.
##
File path:
artemis-jms-client/src/test/java/org/apache/activemq/artemis/jms/client/ConversionTest.java
##
@@ -36,7 +36,7 @@ public void testCoreToJMSConversion() {
clientMessage.setDurable(true)
.setPriority((byte) 9)
.setExpiration(123456);
- Map messageMap = clientMessage.toMap();
+ Map messageMap = clientMessage.toMap(0);
Review comment:
agree
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566799)
Time Spent: 3h (was: 2h 50m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566798
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 16/Mar/21 09:11
Start Date: 16/Mar/21 09:11
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594982656
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
##
@@ -102,10 +102,11 @@
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
@Override
- default Map toMap() {
- Map map = toPropertyMap();
+ default Map toMap(int valueSizeLimit) {
Review comment:
makes sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566798)
Time Spent: 2h 50m (was: 2h 40m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566455 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 15/Mar/21 18:37 Start Date: 15/Mar/21 18:37 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#issuecomment-799655996 This looks quite risky in change of core messages etc, if scope is meant just for management console/cli etc, Not sure we need to change such core internals just for management api layer. Surely it can be handled at a layer above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566455) Time Spent: 2h 40m (was: 2.5h) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566454
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:32
Start Date: 15/Mar/21 18:32
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594588424
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Map map = new HashMap<>();
for (SimpleString name : getPropertyNames()) {
Object value = getObjectProperty(name.toString());
//some property is SimpleString, which is not available for
management console
if (value instanceof SimpleString) {
value = value.toString();
}
+ value = truncate(value, valueSizeLimit);
map.put(name.toString(), value);
}
return map;
}
+ static Object truncate(final Object value, final int valueSizeLimit) {
Review comment:
This is private logic. Currently by doing this it be exposed on api
class. Do we really want to expose this? I would make this in an internal class
and call that method from default methods
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566454)
Time Spent: 2.5h (was: 2h 20m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566452
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:31
Start Date: 15/Mar/21 18:31
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594587283
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Review comment:
This is a breaking api change to users of core
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566452)
Time Spent: 2h 20m (was: 2h 10m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566451
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:30
Start Date: 15/Mar/21 18:30
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594587004
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -706,9 +707,10 @@ default long getWholeMessageSize() {
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
- default Map toMap() {
Review comment:
This is a breaking api change on core. This is exposed to users
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566451)
Time Spent: 2h 10m (was: 2h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566450 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 15/Mar/21 18:29 Start Date: 15/Mar/21 18:29 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594584525 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -253,6 +255,8 @@ private Boolean enableMetrics = null; + private Integer managementMessageAttributeSizeLimit = AddressSettings.MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT; Review comment: Should be null, unless set, so things like merge of address settings dont merge unset values. And the getter returns default if not set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566450) Time Spent: 2h (was: 1h 50m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 2h > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566448 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 15/Mar/21 18:28 Start Date: 15/Mar/21 18:28 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594584525 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -253,6 +255,8 @@ private Boolean enableMetrics = null; + private Integer managementMessageAttributeSizeLimit = AddressSettings.MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT; Review comment: Should be null, unless set, so things like merge of address settings dont merge unset values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566448) Time Spent: 1h 50m (was: 1h 40m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566444 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 15/Mar/21 18:27 Start Date: 15/Mar/21 18:27 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594584525 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -253,6 +255,8 @@ private Boolean enableMetrics = null; + private Integer managementMessageAttributeSizeLimit = AddressSettings.MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT; Review comment: Should be null. So things like merge of address settings dont merge unset values. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566444) Time Spent: 1h 40m (was: 1.5h) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566442 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 15/Mar/21 18:26 Start Date: 15/Mar/21 18:26 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on a change in pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594583735 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java ## @@ -127,6 +127,8 @@ public static final boolean DEFAULT_ENABLE_METRICS = true; + public static final int MANAGEMENT_MESSAGE_ATTRIBUTE_SIZE_LIMIT = 256; Review comment: Surely want existing behaviour of unlimited so users dont get shocks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 566442) Time Spent: 1.5h (was: 1h 20m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566437
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:21
Start Date: 15/Mar/21 18:21
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594580333
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/CoreTransactionDetail.java
##
@@ -56,6 +56,6 @@ public String decodeMessageType(Message msg) {
@Override
public Map decodeMessageProperties(Message msg) {
- return msg.toMap();
+ return msg.toMap(256);
Review comment:
Or at least configurable with default of unlimited
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566437)
Time Spent: 1h 20m (was: 1h 10m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566436
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:20
Start Date: 15/Mar/21 18:20
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594579501
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/impl/CoreTransactionDetail.java
##
@@ -56,6 +56,6 @@ public String decodeMessageType(Message msg) {
@Override
public Map decodeMessageProperties(Message msg) {
- return msg.toMap();
+ return msg.toMap(256);
Review comment:
Surely this could break existing case. I would expect this to remain
unlimited
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566436)
Time Spent: 1h 10m (was: 1h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566433
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:17
Start Date: 15/Mar/21 18:17
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594576770
##
File path:
artemis-jms-client/src/test/java/org/apache/activemq/artemis/jms/client/ConversionTest.java
##
@@ -36,7 +36,7 @@ public void testCoreToJMSConversion() {
clientMessage.setDurable(true)
.setPriority((byte) 9)
.setExpiration(123456);
- Map messageMap = clientMessage.toMap();
+ Map messageMap = clientMessage.toMap(0);
Review comment:
See other comment but semantically i would 0 to truncate to 0, unlimited
i would expect to call -1, likewise typically i would use toMap() to keep
interface unchanged. And toMap(int) as extra method. So that existing usages
remained unchanged.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566433)
Time Spent: 1h (was: 50m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566432
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:17
Start Date: 15/Mar/21 18:17
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594576770
##
File path:
artemis-jms-client/src/test/java/org/apache/activemq/artemis/jms/client/ConversionTest.java
##
@@ -36,7 +36,7 @@ public void testCoreToJMSConversion() {
clientMessage.setDurable(true)
.setPriority((byte) 9)
.setExpiration(123456);
- Map messageMap = clientMessage.toMap();
+ Map messageMap = clientMessage.toMap(0);
Review comment:
See other comment but semantically i would 0 to truncate to 0, unlimited
i would expect to call -1, likewise typically i would use toMap() to keep
interface unchanged.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566432)
Time Spent: 50m (was: 40m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566426
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 18:13
Start Date: 15/Mar/21 18:13
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594574442
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##
@@ -726,20 +728,44 @@ default long getWholeMessageSize() {
/**
* @return Returns the message properties in Map form, useful when encoding
to JSON
+* @param valueSizeLimit
*/
- default Map toPropertyMap() {
+ default Map toPropertyMap(int valueSizeLimit) {
Map map = new HashMap<>();
for (SimpleString name : getPropertyNames()) {
Object value = getObjectProperty(name.toString());
//some property is SimpleString, which is not available for
management console
if (value instanceof SimpleString) {
value = value.toString();
}
+ value = truncate(value, valueSizeLimit);
map.put(name.toString(), value);
}
return map;
}
+ static Object truncate(final Object value, final int valueSizeLimit) {
+ Object result = value;
+ if (valueSizeLimit > 0) {
Review comment:
I would expect truncate 0 to give me zero, normally expect to not
truncate or unlimited to be denoted by -1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566426)
Time Spent: 40m (was: 0.5h)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[
https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=566416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-566416
]
ASF GitHub Bot logged work on ARTEMIS-3175:
---
Author: ASF GitHub Bot
Created on: 15/Mar/21 17:40
Start Date: 15/Mar/21 17:40
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3490:
URL: https://github.com/apache/activemq-artemis/pull/3490#discussion_r594549339
##
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/ICoreMessage.java
##
@@ -102,10 +102,11 @@
/**
* @return Returns the message in Map form, useful when encoding to JSON
+* @param valueSizeLimit
*/
@Override
- default Map toMap() {
- Map map = toPropertyMap();
+ default Map toMap(int valueSizeLimit) {
Review comment:
IMO you should overload this method, i.e. have `toMap()` and
`toMap(int)`. Then the default implementation of `toMap()` can simply invoke
`toMap(0)`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 566416)
Time Spent: 0.5h (was: 20m)
> Restrict/truncate messages attributes to a configurable limit for management
> views
> --
>
> Key: ARTEMIS-3175
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3175
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: JMX
>Affects Versions: 2.17.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.18.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We still populate lots of per message data. ARTEMIS-3141 limits the number of
> messages that are returned by default however the message data is still
> displayed in full.
> With a few kbytes of data in message properties, it can quickly get become a
> burden.
> The open type message body is called BodyPreview - but we put the whole body
> in there at the moment.
> This enhancement will add an address setting -
> *_managementMessageAttributeSizeLimit_*
> with a reasonable 256 default.
> That will truncate all message attributes returned in JSON or JMX OpenData to
> this value.
> Most properties will fit in that limit and be fully visible, anything bigger
> will be difficult to view and is too much data to be exposing in bulk to a
> console or client.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=565302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565302 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 12/Mar/21 13:05 Start Date: 12/Mar/21 13:05 Worklog Time Spent: 10m Work Description: gtully commented on pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490#issuecomment-797477433 along with the feature, there were a few little bug fixes, like byte[] properties not being parsed to json or small message bodies on text messages being null. Those scenarios are covered in the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 565302) Time Spent: 20m (was: 10m) > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 20m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-3175) Restrict/truncate messages attributes to a configurable limit for management views
[ https://issues.apache.org/jira/browse/ARTEMIS-3175?focusedWorklogId=565300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565300 ] ASF GitHub Bot logged work on ARTEMIS-3175: --- Author: ASF GitHub Bot Created on: 12/Mar/21 13:03 Start Date: 12/Mar/21 13:03 Worklog Time Spent: 10m Work Description: gtully opened a new pull request #3490: URL: https://github.com/apache/activemq-artemis/pull/3490 …-size-limit to sensibly limit data returned by list/browse/filter management ops This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 565300) Remaining Estimate: 0h Time Spent: 10m > Restrict/truncate messages attributes to a configurable limit for management > views > -- > > Key: ARTEMIS-3175 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3175 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: JMX >Affects Versions: 2.17.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.18.0 > > Time Spent: 10m > Remaining Estimate: 0h > > We still populate lots of per message data. ARTEMIS-3141 limits the number of > messages that are returned by default however the message data is still > displayed in full. > With a few kbytes of data in message properties, it can quickly get become a > burden. > The open type message body is called BodyPreview - but we put the whole body > in there at the moment. > This enhancement will add an address setting - > *_managementMessageAttributeSizeLimit_* > with a reasonable 256 default. > That will truncate all message attributes returned in JSON or JMX OpenData to > this value. > Most properties will fit in that limit and be fully visible, anything bigger > will be difficult to view and is too much data to be exposing in bulk to a > console or client. -- This message was sent by Atlassian Jira (v8.3.4#803005)
