[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-04 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=823405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823405
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 04/Nov/22 13:44
Start Date: 04/Nov/22 13:44
Worklog Time Spent: 10m 
  Work Description: brusdev merged PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270




Issue Time Tracking
---

Worklog Id: (was: 823405)
Time Spent: 1h 20m  (was: 1h 10m)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-03 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=823135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823135
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 03/Nov/22 16:46
Start Date: 03/Nov/22 16:46
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4270:
URL: 
https://github.com/apache/activemq-artemis/pull/4270#issuecomment-1302383523

   @brusdev fine... merge when you feel comfortable then . LGTM




Issue Time Tracking
---

Worklog Id: (was: 823135)
Time Spent: 1h 10m  (was: 1h)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822747
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 02/Nov/22 15:14
Start Date: 02/Nov/22 15:14
Worklog Time Spent: 10m 
  Work Description: brusdev commented on PR #4270:
URL: 
https://github.com/apache/activemq-artemis/pull/4270#issuecomment-1300645284

   @clebertsuconic adding a test would be very hard, I tested it manually




Issue Time Tracking
---

Worklog Id: (was: 822747)
Time Spent: 1h  (was: 50m)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822746
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 02/Nov/22 15:13
Start Date: 02/Nov/22 15:13
Worklog Time Spent: 10m 
  Work Description: brusdev commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011917616


##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest, 
ServletResponse servletRespo
   filterChain.doFilter(servletRequest, servletResponse);
   if (AuditLogger.isAnyLoggingEnabled()) {
  int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything 
else must be a failure
- if (status == 200) {
+ if (status < 300) {

Review Comment:
   Status ranges updated





Issue Time Tracking
---

Worklog Id: (was: 822746)
Time Spent: 50m  (was: 40m)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822686
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 02/Nov/22 13:20
Start Date: 02/Nov/22 13:20
Worklog Time Spent: 10m 
  Work Description: TheCycoONE commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011736748


##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest, 
ServletResponse servletRespo
   filterChain.doFilter(servletRequest, servletResponse);
   if (AuditLogger.isAnyLoggingEnabled()) {
  int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything 
else must be a failure
- if (status == 200) {
+ if (status < 300) {

Review Comment:
   Does 100 continue need to be handled as well - would that ever reach here? I 
think in general I would feel better if < 200 was skipped like 300-399.





Issue Time Tracking
---

Worklog Id: (was: 822686)
Time Spent: 40m  (was: 0.5h)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-11-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822673
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 02/Nov/22 13:07
Start Date: 02/Nov/22 13:07
Worklog Time Spent: 10m 
  Work Description: TheCycoONE commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011736748


##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest, 
ServletResponse servletRespo
   filterChain.doFilter(servletRequest, servletResponse);
   if (AuditLogger.isAnyLoggingEnabled()) {
  int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything 
else must be a failure
- if (status == 200) {
+ if (status < 300) {

Review Comment:
   Does 100 continue need to be handled as well - would that ever reach here?





Issue Time Tracking
---

Worklog Id: (was: 822673)
Time Spent: 0.5h  (was: 20m)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-10-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=820534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-820534
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 26/Oct/22 14:35
Start Date: 26/Oct/22 14:35
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on PR #4270:
URL: 
https://github.com/apache/activemq-artemis/pull/4270#issuecomment-1292150381

   @brusdev I don't have how to validate this... 
   
   if you believe this is not possible to have a test added, and know this is 
ok by manually testing it.. please merge it.




Issue Time Tracking
---

Worklog Id: (was: 820534)
Time Spent: 20m  (was: 10m)

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts

2022-10-25 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=819947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819947
 ]

ASF GitHub Bot logged work on ARTEMIS-4071:
---

Author: ASF GitHub Bot
Created on: 25/Oct/22 08:25
Start Date: 25/Oct/22 08:25
Worklog Time Spent: 10m 
  Work Description: brusdev opened a new pull request, #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270

   The HTTP redirection messages (300 – 399) must be ignored they don't mean an 
authentication failure.




Issue Time Tracking
---

Worklog Id: (was: 819947)
Remaining Estimate: 0h
Time Spent: 10m

> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit 
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User 
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)