[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=863145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863145 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 31/May/23 20:16 Start Date: 31/May/23 20:16 Worklog Time Spent: 10m Work Description: jbertram merged PR #4435: URL: https://github.com/apache/activemq-artemis/pull/4435 Issue Time Tracking --- Worklog Id: (was: 863145) Time Spent: 1h 50m (was: 1h 40m) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[
https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=860815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860815
]
ASF GitHub Bot logged work on ARTEMIS-4238:
---
Author: ASF GitHub Bot
Created on: 05/May/23 19:13
Start Date: 05/May/23 19:13
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4435:
URL: https://github.com/apache/activemq-artemis/pull/4435#discussion_r1186424827
##
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##
@@ -120,6 +120,7 @@ public class ActiveMQActivationSpec extends
ConnectionFactoryProperties implemen
/**
* Transaction timeout
*/
+ @Deprecated
Review Comment:
Done.
##
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##
@@ -631,6 +632,7 @@ public Integer getTransactionTimeout() {
*
* @param value The value
*/
+ @Deprecated
Review Comment:
Ditto
Issue Time Tracking
---
Worklog Id: (was: 860815)
Time Spent: 1h 40m (was: 1.5h)
> transaction timeout ActivationConfigProperty is no longer working
> -
>
> Key: ARTEMIS-4238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: JMS
>Affects Versions: 2.28.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> ARTEMIS-3707 has created a regression where the transactionTimeout
> ActivationConfigProperty is no longer working properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[
https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=860276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860276
]
ASF GitHub Bot logged work on ARTEMIS-4238:
---
Author: ASF GitHub Bot
Created on: 03/May/23 10:38
Start Date: 03/May/23 10:38
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4435:
URL: https://github.com/apache/activemq-artemis/pull/4435#discussion_r1183518415
##
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java:
##
@@ -631,6 +632,7 @@ public Integer getTransactionTimeout() {
*
* @param value The value
*/
+ @Deprecated
Review Comment:
Ditto
Issue Time Tracking
---
Worklog Id: (was: 860276)
Time Spent: 1.5h (was: 1h 20m)
> transaction timeout ActivationConfigProperty is no longer working
> -
>
> Key: ARTEMIS-4238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: JMS
>Affects Versions: 2.28.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> ARTEMIS-3707 has created a regression where the transactionTimeout
> ActivationConfigProperty is no longer working properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=860275=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860275 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 03/May/23 10:37 Start Date: 03/May/23 10:37 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4435: URL: https://github.com/apache/activemq-artemis/pull/4435#discussion_r1183517862 ## artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java: ## @@ -120,6 +120,7 @@ public class ActiveMQActivationSpec extends ConnectionFactoryProperties implemen /** * Transaction timeout */ + @Deprecated Review Comment: If it is deprecated for future removal as indicated in the documentation, should the Deprecated tag indicate that with the forRemoval flag? Issue Time Tracking --- Worklog Id: (was: 860275) Time Spent: 1h 20m (was: 1h 10m) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856803 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 13/Apr/23 15:08 Start Date: 13/Apr/23 15:08 Worklog Time Spent: 10m Work Description: jbertram merged PR #4433: URL: https://github.com/apache/activemq-artemis/pull/4433 Issue Time Tracking --- Worklog Id: (was: 856803) Time Spent: 1h 10m (was: 1h) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856792 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 13/Apr/23 14:36 Start Date: 13/Apr/23 14:36 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4433: URL: https://github.com/apache/activemq-artemis/pull/4433#issuecomment-1507083552 @ehsavoie, this looks good. I transitioned it from draft and will merge shortly. Issue Time Tracking --- Worklog Id: (was: 856792) Time Spent: 1h (was: 50m) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[
https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856206
]
ASF GitHub Bot logged work on ARTEMIS-4238:
---
Author: ASF GitHub Bot
Created on: 11/Apr/23 18:46
Start Date: 11/Apr/23 18:46
Worklog Time Spent: 10m
Work Description: ehsavoie commented on code in PR #4433:
URL: https://github.com/apache/activemq-artemis/pull/4433#discussion_r1163199931
##
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAManagedConnection.java:
##
@@ -336,7 +336,7 @@ public void associateConnection(final Object obj) throws
ResourceException {
public void checkTransactionActive() throws JMSException {
// don't bother looking at the transaction if there's an active XID
- if (!inManagedTx && tsr != null) {
+ if (!inManagedTx && tsr != null && tsr.getTransactionKey() != null) {
Review Comment:
a leftover
Issue Time Tracking
---
Worklog Id: (was: 856206)
Time Spent: 50m (was: 40m)
> transaction timeout ActivationConfigProperty is no longer working
> -
>
> Key: ARTEMIS-4238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: JMS
>Affects Versions: 2.28.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> ARTEMIS-3707 has created a regression where the transactionTimeout
> ActivationConfigProperty is no longer working properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856196=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856196 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 11/Apr/23 17:58 Start Date: 11/Apr/23 17:58 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4433: URL: https://github.com/apache/activemq-artemis/pull/4433#issuecomment-1503849936 The commit message doesn't follow the [recommended format](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/code.md#commitMessageDetails). There's no need for square brackets and a colon around the Jira reference. Issue Time Tracking --- Worklog Id: (was: 856196) Time Spent: 40m (was: 0.5h) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856193 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 11/Apr/23 17:56 Start Date: 11/Apr/23 17:56 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4433: URL: https://github.com/apache/activemq-artemis/pull/4433#issuecomment-1503847900 It would be ideal to have some tests for this to catch future regressions. Issue Time Tracking --- Worklog Id: (was: 856193) Time Spent: 0.5h (was: 20m) > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[
https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856192
]
ASF GitHub Bot logged work on ARTEMIS-4238:
---
Author: ASF GitHub Bot
Created on: 11/Apr/23 17:55
Start Date: 11/Apr/23 17:55
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4433:
URL: https://github.com/apache/activemq-artemis/pull/4433#discussion_r1163154561
##
artemis-ra/src/main/java/org/apache/activemq/artemis/ra/ActiveMQRAManagedConnection.java:
##
@@ -336,7 +336,7 @@ public void associateConnection(final Object obj) throws
ResourceException {
public void checkTransactionActive() throws JMSException {
// don't bother looking at the transaction if there's an active XID
- if (!inManagedTx && tsr != null) {
+ if (!inManagedTx && tsr != null && tsr.getTransactionKey() != null) {
Review Comment:
This change doesn't appear related to the `transactionTimeout` change. Why
is this necessary?
Issue Time Tracking
---
Worklog Id: (was: 856192)
Time Spent: 20m (was: 10m)
> transaction timeout ActivationConfigProperty is no longer working
> -
>
> Key: ARTEMIS-4238
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4238
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: JMS
>Affects Versions: 2.28.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ARTEMIS-3707 has created a regression where the transactionTimeout
> ActivationConfigProperty is no longer working properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4238) transaction timeout ActivationConfigProperty is no longer working
[ https://issues.apache.org/jira/browse/ARTEMIS-4238?focusedWorklogId=856139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856139 ] ASF GitHub Bot logged work on ARTEMIS-4238: --- Author: ASF GitHub Bot Created on: 11/Apr/23 14:13 Start Date: 11/Apr/23 14:13 Worklog Time Spent: 10m Work Description: ehsavoie opened a new pull request, #4433: URL: https://github.com/apache/activemq-artemis/pull/4433 …nger working. * Re-adding the missing code Jira: https://issues.apache.org/jira/browse/ARTEMIS-4238 Issue Time Tracking --- Worklog Id: (was: 856139) Remaining Estimate: 0h Time Spent: 10m > transaction timeout ActivationConfigProperty is no longer working > - > > Key: ARTEMIS-4238 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4238 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: JMS >Affects Versions: 2.28.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > ARTEMIS-3707 has created a regression where the transactionTimeout > ActivationConfigProperty is no longer working properly -- This message was sent by Atlassian Jira (v8.20.10#820010)
