[jira] [Work logged] (ARTEMIS-4252) Fix flaky QuorumFailOverTest tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4252?focusedWorklogId=859271=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859271 ] ASF GitHub Bot logged work on ARTEMIS-4252: --- Author: ASF GitHub Bot Created on: 26/Apr/23 22:10 Start Date: 26/Apr/23 22:10 Worklog Time Spent: 10m Work Description: jbertram merged PR #4454: URL: https://github.com/apache/activemq-artemis/pull/4454 Issue Time Tracking --- Worklog Id: (was: 859271) Time Spent: 50m (was: 40m) > Fix flaky QuorumFailOverTest tests > -- > > Key: ARTEMIS-4252 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4252 > Project: ActiveMQ Artemis > Issue Type: Test >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > QuorumFailOverTest tests are intermittently failing. To fix > QuorumFailOverTest tests, we should wait for cluster bridge connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4252) Fix flaky QuorumFailOverTest tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4252?focusedWorklogId=859220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859220 ] ASF GitHub Bot logged work on ARTEMIS-4252: --- Author: ASF GitHub Bot Created on: 26/Apr/23 16:59 Start Date: 26/Apr/23 16:59 Worklog Time Spent: 10m Work Description: brusdev commented on PR #4448: URL: https://github.com/apache/activemq-artemis/pull/4448#issuecomment-1523760300 @gemmellr thanks for your review, I created to address #4454 your comments. Issue Time Tracking --- Worklog Id: (was: 859220) Time Spent: 40m (was: 0.5h) > Fix flaky QuorumFailOverTest tests > -- > > Key: ARTEMIS-4252 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4252 > Project: ActiveMQ Artemis > Issue Type: Test >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > QuorumFailOverTest tests are intermittently failing. To fix > QuorumFailOverTest tests, we should wait for cluster bridge connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4252) Fix flaky QuorumFailOverTest tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4252?focusedWorklogId=859212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859212
]
ASF GitHub Bot logged work on ARTEMIS-4252:
---
Author: ASF GitHub Bot
Created on: 26/Apr/23 16:43
Start Date: 26/Apr/23 16:43
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4448:
URL: https://github.com/apache/activemq-artemis/pull/4448#discussion_r1178141231
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##
@@ -630,6 +630,11 @@ public long getCallTimeout() {
return callTimeout;
}
+ @Override
+ public Bridge[] getBridges() {
+ return
records.values().stream().map(MessageFlowRecord::getBridge).toArray(Bridge[]::new);
Review Comment:
It makes sense, I'll fix it. I'll create another PR to fix it.
##
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##
@@ -1328,6 +1330,17 @@ protected static final void waitForComponent(final
ActiveMQComponent component,
}
}
+ protected static final void waitForBridges(final ActiveMQServer server, int
connectedBridges) throws Exception {
+ waitForBridges(server.getClusterManager().getDefaultConnection(null),
connectedBridges);
+ }
+
+ protected static final void waitForBridges(ClusterConnection
clusterConnection, int connectedBridges) throws Exception {
+ Bridge[] bridges = clusterConnection.getBridges();
Review Comment:
You are right I missed to remove that line, I'll create another PR to fix it.
Issue Time Tracking
---
Worklog Id: (was: 859212)
Time Spent: 0.5h (was: 20m)
> Fix flaky QuorumFailOverTest tests
> --
>
> Key: ARTEMIS-4252
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4252
> Project: ActiveMQ Artemis
> Issue Type: Test
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> QuorumFailOverTest tests are intermittently failing. To fix
> QuorumFailOverTest tests, we should wait for cluster bridge connections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4252) Fix flaky QuorumFailOverTest tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4252?focusedWorklogId=858717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858717
]
ASF GitHub Bot logged work on ARTEMIS-4252:
---
Author: ASF GitHub Bot
Created on: 24/Apr/23 13:43
Start Date: 24/Apr/23 13:43
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4448:
URL: https://github.com/apache/activemq-artemis/pull/4448#discussion_r1175301832
##
artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##
@@ -1328,6 +1330,17 @@ protected static final void waitForComponent(final
ActiveMQComponent component,
}
}
+ protected static final void waitForBridges(final ActiveMQServer server, int
connectedBridges) throws Exception {
+ waitForBridges(server.getClusterManager().getDefaultConnection(null),
connectedBridges);
+ }
+
+ protected static final void waitForBridges(ClusterConnection
clusterConnection, int connectedBridges) throws Exception {
+ Bridge[] bridges = clusterConnection.getBridges();
Review Comment:
This doesnt look used. Is it needed? Was a quick-exit check intended but
missed?
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##
@@ -630,6 +630,11 @@ public long getCallTimeout() {
return callTimeout;
}
+ @Override
+ public Bridge[] getBridges() {
+ return
records.values().stream().map(MessageFlowRecord::getBridge).toArray(Bridge[]::new);
Review Comment:
The 'records' field has 'recordsGuard' to protect its use in other cases. Is
that needed here?
Issue Time Tracking
---
Worklog Id: (was: 858717)
Time Spent: 20m (was: 10m)
> Fix flaky QuorumFailOverTest tests
> --
>
> Key: ARTEMIS-4252
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4252
> Project: ActiveMQ Artemis
> Issue Type: Test
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> QuorumFailOverTest tests are intermittently failing. To fix
> QuorumFailOverTest tests, we should wait for cluster bridge connections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4252) Fix flaky QuorumFailOverTest tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4252?focusedWorklogId=858712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858712 ] ASF GitHub Bot logged work on ARTEMIS-4252: --- Author: ASF GitHub Bot Created on: 24/Apr/23 13:11 Start Date: 24/Apr/23 13:11 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4448: URL: https://github.com/apache/activemq-artemis/pull/4448 Issue Time Tracking --- Worklog Id: (was: 858712) Remaining Estimate: 0h Time Spent: 10m > Fix flaky QuorumFailOverTest tests > -- > > Key: ARTEMIS-4252 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4252 > Project: ActiveMQ Artemis > Issue Type: Test >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > QuorumFailOverTest tests are intermittently failing. To fix > QuorumFailOverTest tests, we should wait for cluster bridge connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
