[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910560 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 14:49 Start Date: 19/Mar/24 14:49 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4859: URL: https://github.com/apache/activemq-artemis/pull/4859 Issue Time Tracking --- Worklog Id: (was: 910560) Time Spent: 2h 20m (was: 2h 10m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910527 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 13:20 Start Date: 19/Mar/24 13:20 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4859: URL: https://github.com/apache/activemq-artemis/pull/4859#issuecomment-2007161813 I'm running a complete test suite job. if everything goes ok I will merge this one in 1 hour from this comment. Issue Time Tracking --- Worklog Id: (was: 910527) Time Spent: 2h 10m (was: 2h) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910445 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 01:16 Start Date: 19/Mar/24 01:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4859: URL: https://github.com/apache/activemq-artemis/pull/4859#issuecomment-2005554570 @jbertram I missed that you didn't set the right super class on XMLDataImporter. if you could merge this before the release please? Issue Time Tracking --- Worklog Id: (was: 910445) Time Spent: 1h 50m (was: 1h 40m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910446 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 01:16 Start Date: 19/Mar/24 01:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4859: URL: https://github.com/apache/activemq-artemis/pull/4859#issuecomment-200078 I will merge it when all the tests are good (just running the CI to double check it) Issue Time Tracking --- Worklog Id: (was: 910446) Time Spent: 2h (was: 1h 50m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910444 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 01:15 Start Date: 19/Mar/24 01:15 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4859: URL: https://github.com/apache/activemq-artemis/pull/4859 (no comment) Issue Time Tracking --- Worklog Id: (was: 910444) Time Spent: 1h 40m (was: 1.5h) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910443 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 19/Mar/24 01:06 Start Date: 19/Mar/24 01:06 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4855: URL: https://github.com/apache/activemq-artemis/pull/4855 Issue Time Tracking --- Worklog Id: (was: 910443) Time Spent: 1.5h (was: 1h 20m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910143 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 15/Mar/24 16:31 Start Date: 15/Mar/24 16:31 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4855: URL: https://github.com/apache/activemq-artemis/pull/4855#issuecomment-227043 @clebertsuconic, I separated out the basic connection stuff. Let me know what you think. Issue Time Tracking --- Worklog Id: (was: 910143) Time Spent: 1h 20m (was: 1h 10m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910011 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 15/Mar/24 02:55 Start Date: 15/Mar/24 02:55 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4855: URL: https://github.com/apache/activemq-artemis/pull/4855#issuecomment-1998851265 @jbertram I think it gets confusing. I think we should have an upper class that does not ask for those. This is actually probably the reason why it didn't extend the class and made a copy of the properties instead of reusing stuff. Issue Time Tracking --- Worklog Id: (was: 910011) Time Spent: 1h 10m (was: 1h) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=910003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-910003 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 15/Mar/24 01:23 Start Date: 15/Mar/24 01:23 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4855: URL: https://github.com/apache/activemq-artemis/pull/4855#issuecomment-1998733027 No, it doesn't really make sense to specify `protocol` or `clientID`, but it doesn't really hurt either as far as I can tell. It would be worth adjusting the abstract to have one that's more generic for basic connectivity. Issue Time Tracking --- Worklog Id: (was: 910003) Time Spent: 1h (was: 50m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=90&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 15/Mar/24 00:58 Start Date: 15/Mar/24 00:58 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4855: URL: https://github.com/apache/activemq-artemis/pull/4855#issuecomment-1998714100 h... maybe we need to tweak the Abstract a bit. does it make sense to specify --protocol on the import? what about clientID? ``` Usage: artemis data imp [--legacy-prefixes] [--silent] [--sort] [--verbose] [--acceptor=] [--clientID=] --input= [--password=] [--protocol=] [--url=] [--user=] Import all message-data using an XML that could be interpreted by any system. --acceptor= Name used to find the default connection URL on the acceptor list. If an acceptor with that name cannot be found the CLI will look for a connector with the same name. --clientID= ClientID set on the connection. --input= The input file name. Default: exp.dmp. --legacy-prefixes Do not remove prefixes from legacy imports. --password= Password used to connect. --protocol= Protocol used. Valid values are AMQP, CORE --silentDisable all the inputs, and make a best guess for any required input. --sort Sort the messages from the input (used for older versions that won't sort messages). --url= Connection URL. Default: build URL from the 'artemis' acceptor defined in the broker.xml or tcp: //localhost:61616 if the acceptor cannot be parsed. --user= User used to connect. --verbose Print additional information. ``` Issue Time Tracking --- Worklog Id: (was: 90) Time Spent: 50m (was: 40m) > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[
https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=909955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909955
]
ASF GitHub Bot logged work on ARTEMIS-4689:
---
Author: ASF GitHub Bot
Created on: 14/Mar/24 17:48
Start Date: 14/Mar/24 17:48
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4855:
URL: https://github.com/apache/activemq-artemis/pull/4855#discussion_r1525285537
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
Review Comment:
I added `hidden = true`, but I left `@Deprecated` so that we will remember
to remove it at the next major version.
Issue Time Tracking
---
Worklog Id: (was: 909955)
Time Spent: 40m (was: 0.5h)
> Import command should accept URL
>
>
> Key: ARTEMIS-4689
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4689
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the import command only takes host & port with regard to its
> connection to the broker. It should take a URL instead so that the connection
> can be configured appropriately for more use-cases (e.g. using TLS).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[
https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=909953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909953
]
ASF GitHub Bot logged work on ARTEMIS-4689:
---
Author: ASF GitHub Bot
Created on: 14/Mar/24 17:41
Start Date: 14/Mar/24 17:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4855:
URL: https://github.com/apache/activemq-artemis/pull/4855#discussion_r1525277290
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
+ public String host = null;
- @Option(names = "--port", description = "The port used to import the data.
Default: 61616.")
+ @Deprecated(forRemoval = true)
+ @Option(names = "--port", description = "The port used to import the data.
Default: 61616. Deprecated! Use 'url' instead.")
Review Comment:
eg:
https://github.com/apache/activemq-artemis/blob/7742936583d48e179f67c7d73b7b49cbe83731d5/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/DestAbstract.java#L41-L42
if you have a script showing the older parameters, it should work fine, but
it will prevent users from discovering the deprecated term.
it is the best approach on the CLI.. hidden=true
Issue Time Tracking
---
Worklog Id: (was: 909953)
Time Spent: 0.5h (was: 20m)
> Import command should accept URL
>
>
> Key: ARTEMIS-4689
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4689
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the import command only takes host & port with regard to its
> connection to the broker. It should take a URL instead so that the connection
> can be configured appropriately for more use-cases (e.g. using TLS).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[
https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=909951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909951
]
ASF GitHub Bot logged work on ARTEMIS-4689:
---
Author: ASF GitHub Bot
Created on: 14/Mar/24 17:39
Start Date: 14/Mar/24 17:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4855:
URL: https://github.com/apache/activemq-artemis/pull/4855#discussion_r1525274543
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
Review Comment:
just use hidden=true, no need to deprecate things in the CLI.
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
+ public String host = null;
- @Option(names = "--port", description = "The port used to import the data.
Default: 61616.")
+ @Deprecated(forRemoval = true)
+ @Option(names = "--port", description = "The port used to import the data.
Default: 61616. Deprecated! Use 'url' instead.")
Review Comment:
just use hidden
Issue Time Tracking
---
Worklog Id: (was: 909951)
Time Spent: 20m (was: 10m)
> Import command should accept URL
>
>
> Key: ARTEMIS-4689
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4689
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the import command only takes host & port with regard to its
> connection to the broker. It should take a URL instead so that the connection
> can be configured appropriately for more use-cases (e.g. using TLS).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4689) Import command should accept URL
[ https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=909950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909950 ] ASF GitHub Bot logged work on ARTEMIS-4689: --- Author: ASF GitHub Bot Created on: 14/Mar/24 17:38 Start Date: 14/Mar/24 17:38 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4855: URL: https://github.com/apache/activemq-artemis/pull/4855 (no comment) Issue Time Tracking --- Worklog Id: (was: 909950) Remaining Estimate: 0h Time Spent: 10m > Import command should accept URL > > > Key: ARTEMIS-4689 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4689 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently the import command only takes host & port with regard to its > connection to the broker. It should take a URL instead so that the connection > can be configured appropriately for more use-cases (e.g. using TLS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
