[jira] [Work logged] (ARTEMIS-4702) Only run command needs custom JVM settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4702?focusedWorklogId=922130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922130
]
ASF GitHub Bot logged work on ARTEMIS-4702:
---
Author: ASF GitHub Bot
Created on: 05/Jun/24 10:48
Start Date: 05/Jun/24 10:48
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4885:
URL: https://github.com/apache/activemq-artemis/pull/4885#discussion_r1627495954
##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -36,7 +36,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}'
HAWTIO_ROLE='${role}'
# Java Opts
-if [ -z "$JAVA_ARGS" ]; then
+if [ -z "$JAVA_ARGS" ] && [ "$1" = "run" ]; then
Review Comment:
There is a related problem with the log4j2 config, see:
https://issues.apache.org/jira/browse/ARTEMIS-4785
in that case, we need to keep the logging just for the broker run and not
for any other command. the comment on that jira has lots of good info.
Issue Time Tracking
---
Worklog Id: (was: 922130)
Time Spent: 0.5h (was: 20m)
> Only run command needs custom JVM settings
> --
>
> Key: ARTEMIS-4702
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4702
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Right now every {{artemis}} command uses the same JVM settings from
> {{artemis.profile}}. So, for example, if the settings included {{-Xms8G
> -Xmx8G}} for running the broker (i.e. the {{run}} command) those same
> settings would be used for the {{queue stat}}, {{consumer}}, {{producer}},
> etc. commands as well. At best, it's overkill to use 8G of memory for these
> secondary commands and at worst it can actually prevent them from operating
> at all (e.g. if the machine is low on memory).
> JVM settings really only need to apply to the {{run}} command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4702) Only run command needs custom JVM settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4702?focusedWorklogId=914768=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914768
]
ASF GitHub Bot logged work on ARTEMIS-4702:
---
Author: ASF GitHub Bot
Created on: 16/Apr/24 03:18
Start Date: 16/Apr/24 03:18
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4885:
URL: https://github.com/apache/activemq-artemis/pull/4885#discussion_r1566656217
##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/artemis.profile:
##
@@ -36,7 +36,7 @@ ARTEMIS_INSTANCE_ETC_URI='${artemis.instance.etc.uri}'
HAWTIO_ROLE='${role}'
# Java Opts
-if [ -z "$JAVA_ARGS" ]; then
+if [ -z "$JAVA_ARGS" ] && [ "$1" = "run" ]; then
Review Comment:
the export might need special memory to load large journals as well.
Also, if you don't pass an argument you may enter the shell where you can do
export, data print, and also.. run from the shell. (not very common, but
possible).
Issue Time Tracking
---
Worklog Id: (was: 914768)
Time Spent: 20m (was: 10m)
> Only run command needs custom JVM settings
> --
>
> Key: ARTEMIS-4702
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4702
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now every {{artemis}} command uses the same JVM settings from
> {{artemis.profile}}. So, for example, if the settings included {{-Xms8G
> -Xmx8G}} for running the broker (i.e. the {{run}} command) those same
> settings would be used for the {{queue stat}}, {{consumer}}, {{producer}},
> etc. commands as well. At best, it's overkill to use 8G of memory for these
> secondary commands and at worst it can actually prevent them from operating
> at all (e.g. if the machine is low on memory).
> JVM settings really only need to apply to the {{run}} command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4702) Only run command needs custom JVM settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4702?focusedWorklogId=914479=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914479
]
ASF GitHub Bot logged work on ARTEMIS-4702:
---
Author: ASF GitHub Bot
Created on: 12/Apr/24 21:42
Start Date: 12/Apr/24 21:42
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #4885:
URL: https://github.com/apache/activemq-artemis/pull/4885
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 914479)
Remaining Estimate: 0h
Time Spent: 10m
> Only run command needs custom JVM settings
> --
>
> Key: ARTEMIS-4702
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4702
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now every {{artemis}} command uses the same JVM settings from
> {{artemis.profile}}. So, for example, if the settings included {{-Xms8G
> -Xmx8G}} for running the broker (i.e. the {{run}} command) those same
> settings would be used for the {{queue stat}}, {{consumer}}, {{producer}},
> etc. commands as well. At best, it's overkill to use 8G of memory for these
> secondary commands and at worst it can actually prevent them from operating
> at all (e.g. if the machine is low on memory).
> JVM settings really only need to apply to the {{run}} command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
