[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods
[ https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916364 ] ASF GitHub Bot logged work on ARTEMIS-4741: --- Author: ASF GitHub Bot Created on: 25/Apr/24 11:41 Start Date: 25/Apr/24 11:41 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4902: URL: https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2076984557 > I started doing equivalent updates and though the assertNull changes definitely make sense, its not clear a lot of the assertTrue/assertFalse changes necessarily do. They are mostly checking Boolean (rather than boolean) return values, so by changing them to assertTrue/assertFalse they are potentially just going to throw an NPE before the assertion actually happens. I'd be inclined to leave those ones as-is. I went through them all, less were Boolean than it initially seemed. I converted almost all of them (left the 10 or so where the type wasnt even known to be Boolean, since the assertEquals handles both the null and the type) and added assertNotNulls beforehand for the Boolean ones. In addition to these original changes, also converted an assertNotEquals(null, foo) into assertNotNull(foo). Issue Time Tracking --- Worklog Id: (was: 916364) Time Spent: 50m (was: 40m) > Use specific assertion methods > -- > > Key: ARTEMIS-4741 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4741 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods
[ https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916159 ] ASF GitHub Bot logged work on ARTEMIS-4741: --- Author: ASF GitHub Bot Created on: 24/Apr/24 10:35 Start Date: 24/Apr/24 10:35 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4902: URL: https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2074641040 I started doing equivalent updates and though the assertNull changes definitely make sense, its not clear a lot of the assertTrue/assertFalse changes necessarily do. They are mostly checking Boolean (rather than boolean) return values, so by changing them to assertTrue/assertFalse they are potentially just going to throw an NPE before the assertion actually happens. I'd be inclined to leave those ones as-is. Issue Time Tracking --- Worklog Id: (was: 916159) Time Spent: 40m (was: 0.5h) > Use specific assertion methods > -- > > Key: ARTEMIS-4741 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4741 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods
[ https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916065 ] ASF GitHub Bot logged work on ARTEMIS-4741: --- Author: ASF GitHub Bot Created on: 23/Apr/24 15:40 Start Date: 23/Apr/24 15:40 Worklog Time Spent: 10m Work Description: jbertram closed pull request #4902: ARTEMIS-4741 use specific assertion methods URL: https://github.com/apache/activemq-artemis/pull/4902 Issue Time Tracking --- Worklog Id: (was: 916065) Time Spent: 0.5h (was: 20m) > Use specific assertion methods > -- > > Key: ARTEMIS-4741 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4741 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4741) Use specific assertion methods
[ https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916037 ] ASF GitHub Bot logged work on ARTEMIS-4741: --- Author: ASF GitHub Bot Created on: 23/Apr/24 12:35 Start Date: 23/Apr/24 12:35 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4902: URL: https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2072185101 Could we avoid merging this, and I'll roll similar improvements into my work on switching to JUnit 5 instead? All of these lines changed will clash in 1-3 different ways with changes I have made already, so will make the already-annoying rebase process more more annoying still. Issue Time Tracking --- Worklog Id: (was: 916037) Time Spent: 20m (was: 10m) > Use specific assertion methods > -- > > Key: ARTEMIS-4741 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4741 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
