[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-07-24 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=927211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927211
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 24/Jul/24 12:59
Start Date: 24/Jul/24 12:59
Worklog Time Spent: 10m 
  Work Description: andytaylor closed pull request #5028: ARTEMIS-4780 - 
fix console when jmx-domain is non default
URL: https://github.com/apache/activemq-artemis/pull/5028




Issue Time Tracking
---

Worklog Id: (was: 927211)
Time Spent: 2h  (was: 1h 50m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-07-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=925911=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925911
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 15/Jul/24 12:02
Start Date: 15/Jul/24 12:02
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #5028:
URL: 
https://github.com/apache/activemq-artemis/pull/5028#issuecomment-2228339363

   I didn't particularly mean an _external_ file, just a _specific_ file. One 
targeted file used only for that mechanism of identifying the domain, rather 
than the current string-literal-across-several-main-console-files. Something 
that could then be simply updated in isolation, e.g overwrite it while 
repacking the plugin war we already publish to create their own version along 
with their custom broker.
   
   That said, I'd also be fine with just addressing it in the new console.




Issue Time Tracking
---

Worklog Id: (was: 925911)
Time Spent: 1h 50m  (was: 1h 40m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-07-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=925907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925907
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 15/Jul/24 11:21
Start Date: 15/Jul/24 11:21
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #5028:
URL: 
https://github.com/apache/activemq-artemis/pull/5028#issuecomment-2228267093

   What you suggest @gemmellr using a external file is easy in the new console 
but difficult to do in th eold console because of the way HawtIO builds and 
authenticates. I could just fix it in th enew console and leave this as is 
(apart for the mbean guard fix). wdyt?




Issue Time Tracking
---

Worklog Id: (was: 925907)
Time Spent: 1h 40m  (was: 1.5h)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-07-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=925887=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925887
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 15/Jul/24 09:09
Start Date: 15/Jul/24 09:09
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #5028:
URL: 
https://github.com/apache/activemq-artemis/pull/5028#issuecomment-2228031429

   Sorry, I didnt see that you had commented.
   
   When we chatted about this previously and you mentioned you had already 
discussed with Gary/Dom and decided on adding it to the existing hawtio mbean, 
I didnt realise that specifically called itself out as a security mbean in its 
overall naming, so I can definitely see Justin's point there. Though as its not 
an MBean users really interact with themselves, I'm not sure how bad it would 
really be to go with it. I also thought their idea was better than adding a new 
MBean at the time because at least that existing MBean is already 'trusted' for 
the other stuff and was already clearly hawtio console specific, and this only 
really being a hawtio console problem. I didnt really want a new MBean for this 
either as its almost completely superfluous for every normal user, i.e most 
people simply dont need it so having an mbean for it feels like needless 
clutter for the regular case. It also needs a known domain and objectname to 
look up itself, which will almost certainly be something else that can clash 
with other things at some point. In retrospect this also only works for one 
broker 'jmx domain' at a time (same is true of using the existing hawtio 
mbean), which in some ways is odd as the entire reason this weird 'variable 
mbean jmx domain' stuff was added ~15 years ago was to support multiple broker 
being managed in the same VM using multiple different jmx domains.
   
   Thus far only 1 person has asked about hitting a mismatch here it seems, and 
that is only coming up because they are shading the broker. So to me it seems 
reasonable enough theyd also need to similarly update the console as well, 
which they already indicated theyd be up for doing with a custom build (since 
the bit needing changed is in a file in a jar, in the war) if that was the 
approach deemed necessary. I did suggest perhaps there is some way we could 
make that easier, e.g take the custom value from a specific file, which they 
could then more easily add/update/swap out than currently as part of the 
general console files themselves. I think I'm back to thinking that is 
preferable than mechanics like this to do it automatically. A specific new 
MBean for it, that doesnt even work for the original use case of varying the 
mbean domain, and is entirely superfluous for almost every user, feels like 
perhaps the worst option for auto-fixing a self-created problem from shading 
the broker but not similarly updating the console.




Issue Time Tracking
---

Worklog Id: (was: 925887)
Time Spent: 1.5h  (was: 1h 20m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-11 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=923066=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923066
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 12/Jun/24 03:18
Start Date: 12/Jun/24 03:18
Worklog Time Spent: 10m 
  Work Description: joshb1050 commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2162027006

   @andytaylor Up to you—whichever makes most sense. Thanks for tackling!




Issue Time Tracking
---

Worklog Id: (was: 923066)
Time Spent: 1h 20m  (was: 1h 10m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-10 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922816
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 10/Jun/24 12:58
Start Date: 10/Jun/24 12:58
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2158283290

   I have made it configurable and this time actually use it, I can reopen this 
or raise a new PR, wdyt?




Issue Time Tracking
---

Worklog Id: (was: 922816)
Time Spent: 1h 10m  (was: 1h)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922206=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922206
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 15:03
Start Date: 05/Jun/24 15:03
Worklog Time Spent: 10m 
  Work Description: joshb1050 commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150302868

   The tricky piece of this is the WAR is provided separately and so we have to 
run a custom shader to shade it. However it doesn't rewrite the JMX domain as 
part of the shading process as it's just a string in a TS file.

   I think what's unexpected is the JMXDomain is configurable as one says but 
the console doesn't pick up on it, hence the confusion.
   
   Custom compilation does work changing the hardcoded value and we could do 
that if that's the best approach forward. Thanks for looking at this.




Issue Time Tracking
---

Worklog Id: (was: 922206)
Time Spent: 1h  (was: 50m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922191
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 13:48
Start Date: 05/Jun/24 13:48
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2150011256

   Well, from the JIRA I think it actually _is_ configurable on the broker 
(unclear why)...but seems like either noone has ever used that, or used it 
together with the console at the same time, or changed the console to match.




Issue Time Tracking
---

Worklog Id: (was: 922191)
Time Spent: 50m  (was: 40m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922174=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922174
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 12:48
Start Date: 05/Jun/24 12:48
Worklog Time Spent: 10m 
  Work Description: andytaylor commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149772044

   For some reason I thought the domain was configurable so I think I agree. I 
will close this




Issue Time Tracking
---

Worklog Id: (was: 922174)
Time Spent: 40m  (was: 0.5h)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922173=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922173
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 12:48
Start Date: 05/Jun/24 12:48
Worklog Time Spent: 10m 
  Work Description: andytaylor closed pull request #18: ARTEMIS-4780 - 
Allow JMX Domain to be discoverable
URL: https://github.com/apache/activemq-artemis-console/pull/18




Issue Time Tracking
---

Worklog Id: (was: 922173)
Time Spent: 0.5h  (was: 20m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=922160=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922160
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 05/Jun/24 11:53
Start Date: 05/Jun/24 11:53
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #18:
URL: 
https://github.com/apache/activemq-artemis-console/pull/18#issuecomment-2149643584

   This feels off. The whole point of the domain in the object name is to avoid 
clashing, as some other component could easily have broker= in its mbean names.
   
   I see from JIRA that this is coming up due to shading the broker. Presumably 
the console bits should be shaded too in that case? Is there a way the value 
could be taken from a file, such that shading it could [be made to] update that 
also?




Issue Time Tracking
---

Worklog Id: (was: 922160)
Time Spent: 20m  (was: 10m)

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact




[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage

2024-06-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=921726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921726
 ]

ASF GitHub Bot logged work on ARTEMIS-4780:
---

Author: ASF GitHub Bot
Created on: 03/Jun/24 10:31
Start Date: 03/Jun/24 10:31
Worklog Time Spent: 10m 
  Work Description: andytaylor opened a new pull request, #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18

   This is because users can change this, the code now searched for *:broker=*




Issue Time Tracking
---

Worklog Id: (was: 921726)
Remaining Estimate: 0h
Time Spent: 10m

> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> 
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process. 
> I did set up:
> 
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because 
> we try to read in localStorage['artemisJmxDomain'] but never actually set it 
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] = 
> "com.abc.shaded.org.apache.activemq.artemis"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact