[jira] [Work logged] (ARTEMIS-4812) PageCursorInfo should be cleared on its Maps when page is marked as complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4812?focusedWorklogId=922981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922981 ] ASF GitHub Bot logged work on ARTEMIS-4812: --- Author: ASF GitHub Bot Created on: 11/Jun/24 16:03 Start Date: 11/Jun/24 16:03 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4970: URL: https://github.com/apache/activemq-artemis/pull/4970 Issue Time Tracking --- Worklog Id: (was: 922981) Time Spent: 20m (was: 10m) > PageCursorInfo should be cleared on its Maps when page is marked as complete > > > Key: ARTEMIS-4812 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4812 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Say you have a paged destination where there is a lazy consumer. The other > queues will keep consuming, and they will mark a page as complete. However > PageCursorInfo::acks and PageCursorInfo::removedReferences should be cleared > upon completion otherwise they will only be GCed when the page file is > removed and the entries for PageCursorInfo removed. > IntObjectHashMap also keeps an array of integers in memory and it won't > remove it when all elements are removed. to the reference to IntObjectHashMap > has to be set to null instead of removeAllReferences. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4812) PageCursorInfo should be cleared on its Maps when page is marked as complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4812?focusedWorklogId=922971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922971 ] ASF GitHub Bot logged work on ARTEMIS-4812: --- Author: ASF GitHub Bot Created on: 11/Jun/24 14:23 Start Date: 11/Jun/24 14:23 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4970: URL: https://github.com/apache/activemq-artemis/pull/4970 this could lead to OME if a lazy consumer is there for a long time with all pages being removed. Issue Time Tracking --- Worklog Id: (was: 922971) Remaining Estimate: 0h Time Spent: 10m > PageCursorInfo should be cleared on its Maps when page is marked as complete > > > Key: ARTEMIS-4812 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4812 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Say you have a paged destination where there is a lazy consumer. The other > queues will keep consuming, and they will mark a page as complete. However > PageCursorInfo::acks and PageCursorInfo::removedReferences should be cleared > upon completion otherwise they will only be GCed when the page file is > removed and the entries for PageCursorInfo removed. > IntObjectHashMap also keeps an array of integers in memory and it won't > remove it when all elements are removed. to the reference to IntObjectHashMap > has to be set to null instead of removeAllReferences. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
