[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213228#comment-15213228 ] Qin Liu commented on AMBARI-12906: -- Like I said before what was missing here is communication. I will improve that so I can do better next time. Thank you for your time as well! > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213215#comment-15213215 ] Antonenko Alexander commented on AMBARI-12906: -- Now I see the difference, you are right. Thank you for your time! > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[
https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213212#comment-15213212
]
Qin Liu commented on AMBARI-12906:
--
I can remove isEmptyOrSpaces without problem as long as this JIRA can move
forward. But isEmptyOrSpaces (return true for 'qin liu' ) and Em.isBlank
(return false for 'qin liu') are not the same function.
I can replace
if
(validator.isEmptyOrSpaces(this.get('controller.inputFields.SMTPUsername.value')))
{<===check if empty or having any white spaces
if
(validator.isEmptyOrSpaces(this.get('controller.inputFields.SMTPPassword.value')))
{<===check if empty or having any white spaces
with
if
(Em.isBlank(this.get('controller.inputFields.SMTPUsername.value'))){
<===check if empty or only white spaces
if
(Em.isBlank(this.get('controller.inputFields.SMTPPassword.value'))){
<===check if empty or only white spaces
Hi Jonathan and Richard,
Are you ok with that? If so, I am going to submit new patch those
changes.Thank you!
> Alert notifications are created even if credential fields are left empty
>
>
> Key: AMBARI-12906
> URL: https://issues.apache.org/jira/browse/AMBARI-12906
> Project: Ambari
> Issue Type: Bug
> Components: alerts
>Affects Versions: 2.1.0
>Reporter: Chandana Mirashi
>Assignee: Qin Liu
> Fix For: 2.4.0
>
> Attachments: AMBARI-12906.patch
>
>
> User should not be allowed to save changes if the credential fields are left
> empty when creating new Alert Notifications.
> Steps to reproduce:
> 1. Create New Alert Notification
> 2. Enter Name = test
> 3. Tick the checkbox for 'Use Authentication'
> 4. Keep username and password empty
> 5. Click on Save
> 6. New alert notifications is created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213160#comment-15213160 ] Antonenko Alexander commented on AMBARI-12906: -- [~qinliu] Once again, please remove isEmptyOrSpaces, as there is no need in this function. As we already have Em.isBlank, that can be accessed globally. They work the same and have the same purpose. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213145#comment-15213145 ] Qin Liu commented on AMBARI-12906: -- Hi Jonathan, Richard, and Antonenko, I would like to come up with a solution for this JIRA. First, let me summarize the issue here: This JIRA was originally opened for "User should not be allowed to save changes if the credential fields are left empty". Its intend was to remind user to provide user/pwd if Use Auth is checked. Jonathan and Di wanted to check white spaces as well. I thought user/pwd (e.g., user='qin liu', it is really common.) containing one white space by mistake should be avoided so I introduced isEmptyOrSpaces which will return true if empty or having at least one white space. Di is off and Richard helped to review and got it shipped. Antonenko aborted it because he thought the existing Em.isBlank has the same functionality as the new isEmptyOrSpaces but they are totally different. I know checking empty or white spaces will never be perfect and I was really struggling with myself at the time when I was implementing isEmptyOrSpaces. I would think it would be really helpful if we can provide a button on UI to let users to test connection with provided user/pwd. Another JIRA can be opened for that. I think what was missing here is communications. I should have better communication with reviewers. I will educate myself and certainly need your help so I can do better job next time. I would think we can deliver it without any further change and open another JiRA to cover others. Jonathan, Richard, and Antonenko, please comment on this. Thank you very much! > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212705#comment-15212705 ] Qin Liu commented on AMBARI-12906: -- Then, it will never end. This JIRA was originally opened for "User should not be allowed to save changes if the credential fields are left empty". Its intend is to remind user to provide user/pwd if Use Auth is checked. The reviewers want to check white spaces as well. I think user name containing one white space by mistake should be avoided so I introduce isEmptyOrSpaces. I think it would be helpful if we can provide a button on UI to let user to test connection with provided user/pwd. Another JIRA can be opened for that. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212641#comment-15212641 ] Antonenko Alexander commented on AMBARI-12906: -- no need to create new function to return true, for your case > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212635#comment-15212635 ] Antonenko Alexander commented on AMBARI-12906: -- Ofc, it will return false ) just use "!" sign for your case. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212435#comment-15212435 ] Qin Liu commented on AMBARI-12906: -- Hi Alexander, Thank you for your info! I will get familiar with them. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212426#comment-15212426 ] Qin Liu commented on AMBARI-12906: -- Hi Alexander, First, I want to clarify that I only asked Di, Jonathan, and you to review the patch. I know Di and I got Jonathan and your name from one of my friend. The patch has been sitting there for a while. I was so pleased to know that Richard helped to review and ship it. I really appreciate their help on my first JIRA and first time working on UI in my life. I haven't got time to say thank you on the review board. It was all my fault because I asked you to review the patch from email not from the review board. So others didn't know I asked you as well. I am so sorry about that. I will work hard to familiar with the process. Second, I checked Em.isBlank which return false for 'qin liu' or ' qinliu ' which is invalid for user name and password. That is why I introduced isEmptyOrSpaces. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211716#comment-15211716 ] Antonenko Alexander commented on AMBARI-12906: -- [~qinliu] Also please get familiar with : https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari ——> In general, the following conventions should be followed for all JavaScript code: http://javascript.crockford.com/code.html Most variables and functions should start with a lower case letter. Try to avoid creating variables starting from upper case letter. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: 2.4.0 > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211536#comment-15211536 ] Hudson commented on AMBARI-12906: - ABORTED: Integrated in Ambari-trunk-Commit #4542 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4542/]) AMBARI-12906: Alert notifications are created even if credential fields (rzang: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=72ac920cd1632bcd3a92e55d1fb9830f0d3d2540]) * ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js * ambari-web/app/templates/main/alerts/create_alert_notification.hbs * ambari-web/app/messages.js * ambari-web/app/utils/validator.js * ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: trunk > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207818#comment-15207818 ] Qin Liu commented on AMBARI-12906: -- Di is off for 2 weeks. So I added Alexander Antonenko as a reviewer. Hi Alexander, could you please review it? Thanks! > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Fix For: trunk > > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[
https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206039#comment-15206039
]
Hadoop QA commented on AMBARI-12906:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12794659/AMBARI-12906.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/5964//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/5964//console
This message is automatically generated.
> Alert notifications are created even if credential fields are left empty
>
>
> Key: AMBARI-12906
> URL: https://issues.apache.org/jira/browse/AMBARI-12906
> Project: Ambari
> Issue Type: Bug
> Components: alerts
>Affects Versions: 2.1.0
>Reporter: Chandana Mirashi
>Assignee: Qin Liu
> Fix For: trunk
>
> Attachments: AMBARI-12906.patch
>
>
> User should not be allowed to save changes if the credential fields are left
> empty when creating new Alert Notifications.
> Steps to reproduce:
> 1. Create New Alert Notification
> 2. Enter Name = test
> 3. Tick the checkbox for 'Use Authentication'
> 4. Keep username and password empty
> 5. Click on Save
> 6. New alert notifications is created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[
https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195914#comment-15195914
]
Hadoop QA commented on AMBARI-12906:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12793353/AMBARI-12906.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-web.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/5871//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/5871//console
This message is automatically generated.
> Alert notifications are created even if credential fields are left empty
>
>
> Key: AMBARI-12906
> URL: https://issues.apache.org/jira/browse/AMBARI-12906
> Project: Ambari
> Issue Type: Bug
> Components: alerts
>Affects Versions: 2.1.0
>Reporter: Chandana Mirashi
>Assignee: Qin Liu
> Fix For: trunk
>
> Attachments: AMBARI-12906.patch
>
>
> User should not be allowed to save changes if the credential fields are left
> empty when creating new Alert Notifications.
> Steps to reproduce:
> 1. Create New Alert Notification
> 2. Enter Name = test
> 3. Tick the checkbox for 'Use Authentication'
> 4. Keep username and password empty
> 5. Click on Save
> 6. New alert notifications is created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-12906) Alert notifications are created even if credential fields are left empty
[ https://issues.apache.org/jira/browse/AMBARI-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191446#comment-15191446 ] Qin Liu commented on AMBARI-12906: -- Has anyone had a chance to review the patch? I am new to Ambari and this is the first JIRA I'm working on. Would really appreciate some feedback. Thanks. > Alert notifications are created even if credential fields are left empty > > > Key: AMBARI-12906 > URL: https://issues.apache.org/jira/browse/AMBARI-12906 > Project: Ambari > Issue Type: Bug > Components: alerts >Affects Versions: 2.1.0 >Reporter: Chandana Mirashi >Assignee: Qin Liu > Attachments: AMBARI-12906.patch > > > User should not be allowed to save changes if the credential fields are left > empty when creating new Alert Notifications. > Steps to reproduce: > 1. Create New Alert Notification > 2. Enter Name = test > 3. Tick the checkbox for 'Use Authentication' > 4. Keep username and password empty > 5. Click on Save > 6. New alert notifications is created. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
