[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252792#comment-15252792
]
Lav Jain commented on AMBARI-15657:
---
Hi [~aantonenko], Thanks a lot for letting us know.
The rationale was that if some configuration change results in an ERROR, the
user should not be allowed to proceed. Otherwise, the validation should trigger
a WARN (instead of ERROR). Currently, there is no distinction between the two.
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252401#comment-15252401
]
Antonenko Alexander commented on AMBARI-15657:
--
[~mithmatt], [~lavjain],
Hi, we faced issue that is related with this patch. Please see AMBARI-16019.
This is cased by two lines of code that was added in committed patch
// Do not allow "Proceed Anyway" for validation errors
disablePrimary: self.get('configValidationError'),
This may block users, or make them do unwanted changes to configs.
Please see patch for AMBARI-16019. The fix is simple, we remove this two lines.
Just wanted to let you know about that changes and please put more people for
review if you do such a fundamental changes.
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227131#comment-15227131
]
Hudson commented on AMBARI-15657:
-
FAILURE: Integrated in Ambari-branch-2.2 #595 (See
[https://builds.apache.org/job/Ambari-branch-2.2/595/])
AMBARI-15657: HAWQ config should not allow multiple Master/Segment (matt:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=fc7338795ca7ef157afff031ed96c2d1ec7962df])
* ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs
* ambari-web/app/mixins/common/serverValidator.js
* ambari-web/app/styles/application.less
*
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
* ambari-web/app/models/configs/objects/service_config_property.js
* ambari-web/app/views/common/configs/service_config_layout_tab_view.js
* ambari-web/app/messages.js
* ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py
* ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
* ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227014#comment-15227014
]
Hudson commented on AMBARI-15657:
-
FAILURE: Integrated in Ambari-trunk-Commit #4599 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/4599/])
AMBARI-15657: HAWQ config should not allow multiple Master/Segment (matt:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=8672138926f2b88c6d798a470b4beb279f4c071f])
* ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
* ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json
* ambari-web/app/styles/application.less
* ambari-web/app/messages.js
*
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
* ambari-web/app/templates/common/modal_popups/config_recommendation_popup.hbs
* ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py
* ambari-web/app/models/configs/objects/service_config_property.js
* ambari-web/app/views/common/configs/service_config_layout_tab_view.js
* ambari-web/app/mixins/common/serverValidator.js
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226806#comment-15226806
]
Matt commented on AMBARI-15657:
---
Committed to trunk:
{code}
author Matt
Tue, 5 Apr 2016 11:00:49 -0700 (11:00 -0700)
committer Matt
Tue, 5 Apr 2016 11:00:49 -0700 (11:00 -0700)
commit 8672138926f2b88c6d798a470b4beb279f4c071f
{code}
Committed to branch-2.2:
{code}
author Matt
Tue, 5 Apr 2016 11:03:16 -0700 (11:03 -0700)
committer Matt
Tue, 5 Apr 2016 11:03:16 -0700 (11:03 -0700)
commit fc7338795ca7ef157afff031ed96c2d1ec7962df
{code}
Marking as resolved.
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-15657) HAWQ config should not allow multiple Master/Segment directories
[
https://issues.apache.org/jira/browse/AMBARI-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221211#comment-15221211
]
Hadoop QA commented on AMBARI-15657:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12796416/screenshot.png
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6141//console
This message is automatically generated.
> HAWQ config should not allow multiple Master/Segment directories
>
>
> Key: AMBARI-15657
> URL: https://issues.apache.org/jira/browse/AMBARI-15657
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
>Affects Versions: trunk, 2.2.0
>Reporter: Lav Jain
>Assignee: Lav Jain
>Priority: Minor
> Attachments: AMBARI-15657.branch22.patch, AMBARI-15657.patch,
> screenshot.png
>
>
> User can add multiple space delimited directories, but after installation, it
> shows a comma in between. however, only first directory goes into effect,
> that too with a comma in the end.
> {code}
> [pivotal@ip-10-32-36-213 etc]$ cat hawq-site.xml
>
> hawq_master_directory
> /data/hawq/master,/data/hawq/master2
>
>
> hawq_segment_directory
> /data/hawq/segment,/data/hawq/segment2
>
> [pivotal@ip-10-32-36-213 etc]$ ls -l /data/hawq
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 master,
> drwxr-xr-x 3 root root 4096 Mar 12 01:00 segment,
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
