[jira] [Commented] (AMBARI-16915) Storm Stack advisor should not make storm.topology.submission.notifier.plugin.class property required
[ https://issues.apache.org/jira/browse/AMBARI-16915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309221#comment-15309221 ] Hudson commented on AMBARI-16915: - FAILURE: Integrated in Ambari-trunk-Commit #4972 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4972/]) AMBARI-16915. Make storm.topology.submission.notifier.plugin.class (sgunturi: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=2491df2263c35f1a541b111a410f606a8d60a786]) * ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > Storm Stack advisor should not make > storm.topology.submission.notifier.plugin.class property required > - > > Key: AMBARI-16915 > URL: https://issues.apache.org/jira/browse/AMBARI-16915 > Project: Ambari > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Sivaguru Kannan > Attachments: AMBARI-16915_branch-2.4.patch > > > The Ambari change, This is in reference with the change, > https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a > which accidentally made the storm.topology.submission.notifier.plugin > property mandatory. > If the storm defaults yaml config does not set the property a " " value is > set for the property. This causes storm startup to fail with a Class Not > Found exception when starting with Ambari. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-16915) Storm Stack advisor should not make storm.topology.submission.notifier.plugin.class property required
[
https://issues.apache.org/jira/browse/AMBARI-16915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305136#comment-15305136
]
Hadoop QA commented on AMBARI-16915:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12806707/AMBARI-16915_branch-2.4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7042//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7042//console
This message is automatically generated.
> Storm Stack advisor should not make
> storm.topology.submission.notifier.plugin.class property required
> -
>
> Key: AMBARI-16915
> URL: https://issues.apache.org/jira/browse/AMBARI-16915
> Project: Ambari
> Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Sivaguru Kannan
> Attachments: AMBARI-16915_branch-2.4.patch
>
>
> The Ambari change, This is in reference with the change,
> https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a
> which accidentally made the storm.topology.submission.notifier.plugin
> property mandatory.
> If the storm defaults yaml config does not set the property a " " value is
> set for the property. This causes storm startup to fail with a Class Not
> Found exception when starting with Ambari.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (AMBARI-16915) Storm Stack advisor should not make storm.topology.submission.notifier.plugin.class property required
[ https://issues.apache.org/jira/browse/AMBARI-16915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303056#comment-15303056 ] ASF GitHub Bot commented on AMBARI-16915: - GitHub user csivaguru opened a pull request: https://github.com/apache/ambari/pull/33 AMBARI-16915 Do not set the notifier plugin class property when not specified in storm defaults You can merge this pull request into a Git repository by running: $ git pull https://github.com/csivaguru/ambari AMBARI-16915 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ambari/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit b75b53251e2dec6a31bd45b679baf278100ce02c Author: Sivaguru Kannan Date: 2016-05-26T22:05:05Z AMBARI-16915 Do not set the notifier plugin class property when not specified in storm defaults > Storm Stack advisor should not make > storm.topology.submission.notifier.plugin.class property required > - > > Key: AMBARI-16915 > URL: https://issues.apache.org/jira/browse/AMBARI-16915 > Project: Ambari > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Sivaguru Kannan > > The Ambari change, This is in reference with your change, > https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a > accidentally made the storm.topology.submission.notifier.plugin property > mandatory. > If the storm defaults yaml config does not set the property a " " value is > set for the property. This causes storm startup to fail with a Class Not > Found exception when starting with Ambari. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
