[jira] [Commented] (AMBARI-16919) Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations']["capacity-scheduler"]["properties"]["capacity
[ https://issues.apache.org/jira/browse/AMBARI-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303925#comment-15303925 ] Swapan Shridhar commented on AMBARI-16919: -- trunk: {code} commit 59364bc87d0ad3c6fa16918329d40230b34646c8 Author: Swapan ShridharDate: Thu May 26 18:47:21 2016 -0700 AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations'][capacity-scheduler][properties][capacity-scheduler] is null. {code} branch-2.4: {code} commit c2e741e5257bcd39b7cdf9aa68159d4e5307b394 Author: Swapan Shridhar Date: Thu May 26 20:00:37 2016 -0700 AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations'][capacity-scheduler][properties][capacity-scheduler] is null. {code} > Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to > Stack Advisor and > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > is null. > --- > > Key: AMBARI-16919 > URL: https://issues.apache.org/jira/browse/AMBARI-16919 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Affects Versions: 2.4.0 >Reporter: Swapan Shridhar >Assignee: Swapan Shridhar >Priority: Blocker > Fix For: 2.4.0 > > Attachments: AMBARI-16919.patch > > > AMBARI-16888 handled the scenario when capacity-scheduler is passed in as > dictionary and > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > set as value = "null". > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : "null", > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : > 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : > "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "1", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > But. there can be another scenario where passed-in 'capacity-scheduler' is > like : > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : null, > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : > 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : > "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "1", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > Here, > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > is itself 'null'. > We get into reading capacity-scheduler configs as key-value only if we dont > find configs passed in as single '\n' string at level > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"]: > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMBARI-16919) Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to Stack Advisor and services['configurations']["capacity-scheduler"]["properties"]["capacity
[ https://issues.apache.org/jira/browse/AMBARI-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303710#comment-15303710 ] Hudson commented on AMBARI-16919: - ABORTED: Integrated in Ambari-trunk-Commit #4938 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4938/]) AMBARI-16919. Handle the scenario when 'capacity-scheduler' is passed-in (sshridhar: [http://git-wip-us.apache.org/repos/asf?p=ambari.git=commit=59364bc87d0ad3c6fa16918329d40230b34646c8]) * ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java * ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py * ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > Handle the scenario when 'capacity-scheduler' is passed-in as dictionary to > Stack Advisor and > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > is null. > --- > > Key: AMBARI-16919 > URL: https://issues.apache.org/jira/browse/AMBARI-16919 > Project: Ambari > Issue Type: Bug > Components: ambari-server >Affects Versions: 2.4.0 >Reporter: Swapan Shridhar >Assignee: Swapan Shridhar >Priority: Blocker > Fix For: 2.4.0 > > Attachments: AMBARI-16919.patch > > > AMBARI-16888 handled the scenario when capacity-scheduler is passed in as > dictionary and > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > set as value = "null". > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : "null", > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : > 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : > "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "1", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > But. there can be another scenario where passed-in 'capacity-scheduler' is > like : > {code} > "capacity-scheduler" : { > "properties" : { > "capacity-scheduler" : null, > "yarn.scheduler.capacity.root.accessible-node-labels" : "*", > "yarn.scheduler.capacity.maximum-am-resource-percent" : "1", > "yarn.scheduler.capacity.root.acl_administer_queue" : "*", > "yarn.scheduler.capacity.queue-mappings-override.enable" : > 'false', > "yarn.scheduler.capacity.root.default.capacity" : "100", > "yarn.scheduler.capacity.root.default.user-limit-factor" : "1", > "yarn.scheduler.capacity.root.queues" : "default", > "yarn.scheduler.capacity.root.capacity" : "100", > "yarn.scheduler.capacity.root.default.acl_submit_applications" : > "*", > "yarn.scheduler.capacity.root.default.maximum-capacity" : "100", > "yarn.scheduler.capacity.node-locality-delay" : "40", > "yarn.scheduler.capacity.maximum-applications" : "1", > "yarn.scheduler.capacity.root.default.state" : "RUNNING" > } > }, > {code} > Here, > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"] > is itself 'null'. > We get into reading capacity-scheduler configs as key-value only if we dont > find configs passed in as single '\n' string at level > services['configurations']["capacity-scheduler"]["properties"]["capacity-scheduler"]: > -- This message was sent by Atlassian JIRA (v6.3.4#6332)