[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326025#comment-16326025 ] Hudson commented on AMBARI-22637: - FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #8597 (See [https://builds.apache.org/job/Ambari-trunk-Commit/8597/]) AMBARI-22637. Fix misuses of os.path.dirname(path) in yarn.py (aonishuk: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=008a3c1ef08b7fa39668b3e563cb88d5b414bec9]) * (edit) ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py * (edit) contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn.py * (edit) ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Fix For: 3.0.0 > > Attachments: AMBARI-22637.001.patch > > Time Spent: 1h > Remaining Estimate: 0h > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322086#comment-16322086 ] Andrew Onischuk commented on AMBARI-22637: -- Hello [~ajisakaa] we have recently changed the process of contibuting to Ambari. Reviewboard and committing directly is no longer the way to do it. You have to create a pull request from you fork of ambari on github and let someone from committers (like me) to review and commit More details here: https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > Fix For: 3.0.0 > > Attachments: AMBARI-22637.001.patch > > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321547#comment-16321547 ] Akira Ajisaka commented on AMBARI-22637: Hi [~aonishuk], would you commit this? Am I missing something to do? > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > Fix For: 3.0.0 > > Attachments: AMBARI-22637.001.patch > > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299620#comment-16299620 ] Akira Ajisaka commented on AMBARI-22637: Thanks [~aonishuk] for the review. Would you commit this? > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > Attachments: AMBARI-22637.001.patch > > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294839#comment-16294839 ] Andrew Onischuk commented on AMBARI-22637: -- Nice find. +1 > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > Attachments: AMBARI-22637.001.patch > > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294769#comment-16294769 ] Akira Ajisaka commented on AMBARI-22637: Hi [~aonishuk] and [~dsen], would you review this issue? > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > Attachments: AMBARI-22637.001.patch > > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[
https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287985#comment-16287985
]
Hadoop QA commented on AMBARI-22637:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12901718/AMBARI-22637.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/12831//console
This message is automatically generated.
> Fix misuses of os.path.dirname(path) in yarn.py
> ---
>
> Key: AMBARI-22637
> URL: https://issues.apache.org/jira/browse/AMBARI-22637
> Project: Ambari
> Issue Type: Sub-task
> Components: ambari-server
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: AMBARI-22637.001.patch
>
>
> As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to
> '/ats/done' and '/ats/active' by default. This is because the default value
> of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and
> the default value of yarn.timeline-service.entity-group-fs-store.active-dir
> is '/ats/active/', and both of the default value have trailing '/'.
> Next yarn.py sets 700 permission to the directories, so finally the
> permissions become correct.
> This issue causes redundant WebHDFS calls every time when launching ATS.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287832#comment-16287832 ] Akira Ajisaka commented on AMBARI-22637: Workaround: Set the parameters to '/ats/done' and '/ats/active' (without trailing '/'). > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMBARI-22637) Fix misuses of os.path.dirname(path) in yarn.py
[ https://issues.apache.org/jira/browse/AMBARI-22637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287831#comment-16287831 ] Akira Ajisaka commented on AMBARI-22637: When using 'Start all' to launch all the components, I've seen ATS is failing to launch because of the failure of the redundant WebHDFS setpermission calls, and the WebHDFS calls failed because the NameNode is in safe mode. To fix this issue, we should wait until safe mode is off (tracked by AMBARI-17901), however, I'm thinking it's better to fix yarn.py as well. > Fix misuses of os.path.dirname(path) in yarn.py > --- > > Key: AMBARI-22637 > URL: https://issues.apache.org/jira/browse/AMBARI-22637 > Project: Ambari > Issue Type: Sub-task > Components: ambari-server >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > > As I written in AMBARI-22632, yarn.py wrongly sets 755 permission to > '/ats/done' and '/ats/active' by default. This is because the default value > of yarn.timeline-service.entity-group-fs-store.done-dir is '/ats/done/' and > the default value of yarn.timeline-service.entity-group-fs-store.active-dir > is '/ats/active/', and both of the default value have trailing '/'. > Next yarn.py sets 700 permission to the directories, so finally the > permissions become correct. > This issue causes redundant WebHDFS calls every time when launching ATS. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
