[jira] [Commented] (ARROW-8781) [CI][C++] Enable ccache on GHA MinGW jobs

2020-05-16 Thread Kouhei Sutou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109257#comment-17109257
 ] 

Kouhei Sutou commented on ARROW-8781:
-

{{ccache}} on MinGW still doesn't work: 
https://github.com/kou/arrow/runs/681552844

> [CI][C++] Enable ccache on GHA MinGW jobs
> -
>
> Key: ARROW-8781
> URL: https://issues.apache.org/jira/browse/ARROW-8781
> Project: Apache Arrow
>  Issue Type: Wish
>  Components: C++, Continuous Integration
>Reporter: Antoine Pitrou
>Priority: Minor
>
> It would be nice to enable caching with ccache on the MinGW Github Actions 
> jobs. They're currently quite slow...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-8781) [CI][C++] Enable ccache on GHA MinGW jobs

2020-05-16 Thread Kouhei Sutou (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109256#comment-17109256
 ] 

Kouhei Sutou commented on ARROW-8781:
-

I didn't look into it deeply but {{ccache}} on MinGW was stuck: ARROW-8233

> [CI][C++] Enable ccache on GHA MinGW jobs
> -
>
> Key: ARROW-8781
> URL: https://issues.apache.org/jira/browse/ARROW-8781
> Project: Apache Arrow
>  Issue Type: Wish
>  Components: C++, Continuous Integration
>Reporter: Antoine Pitrou
>Priority: Minor
>
> It would be nice to enable caching with ccache on the MinGW Github Actions 
> jobs. They're currently quite slow...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ARROW-8825) [C++] Cannot compiled pass with Wunused-parameter flag

2020-05-16 Thread Kouhei Sutou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kouhei Sutou reassigned ARROW-8825:
---

Assignee: hurricanelee

> [C++] Cannot compiled pass with Wunused-parameter flag
> --
>
> Key: ARROW-8825
> URL: https://issues.apache.org/jira/browse/ARROW-8825
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.17.0
> Environment: mac os x/ linux
>Reporter: hurricanelee
>Assignee: hurricanelee
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> arrow's header: array.h has a function value_length(int64_t i) ...
> the i is unused parameter, if i compile it with -Werror / -Wunused-parameter 
> flag, it will get a failure.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8825) [C++] Cannot compiled pass with Wunused-parameter flag

2020-05-16 Thread Kouhei Sutou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kouhei Sutou updated ARROW-8825:

Summary: [C++] Cannot compiled pass with Wunused-parameter flag  (was: 
arrow cpp edition cannot compiled pass with Wunused-parameter flag.)

> [C++] Cannot compiled pass with Wunused-parameter flag
> --
>
> Key: ARROW-8825
> URL: https://issues.apache.org/jira/browse/ARROW-8825
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.17.0
> Environment: mac os x/ linux
>Reporter: hurricanelee
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 0.17.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> arrow's header: array.h has a function value_length(int64_t i) ...
> the i is unused parameter, if i compile it with -Werror / -Wunused-parameter 
> flag, it will get a failure.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8825) [C++] Cannot compiled pass with Wunused-parameter flag

2020-05-16 Thread Kouhei Sutou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kouhei Sutou updated ARROW-8825:

Priority: Minor  (was: Blocker)

> [C++] Cannot compiled pass with Wunused-parameter flag
> --
>
> Key: ARROW-8825
> URL: https://issues.apache.org/jira/browse/ARROW-8825
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.17.0
> Environment: mac os x/ linux
>Reporter: hurricanelee
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> arrow's header: array.h has a function value_length(int64_t i) ...
> the i is unused parameter, if i compile it with -Werror / -Wunused-parameter 
> flag, it will get a failure.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8825) [C++] Cannot compiled pass with Wunused-parameter flag

2020-05-16 Thread Kouhei Sutou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kouhei Sutou updated ARROW-8825:

Fix Version/s: (was: 0.17.0)

> [C++] Cannot compiled pass with Wunused-parameter flag
> --
>
> Key: ARROW-8825
> URL: https://issues.apache.org/jira/browse/ARROW-8825
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.17.0
> Environment: mac os x/ linux
>Reporter: hurricanelee
>Priority: Blocker
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> arrow's header: array.h has a function value_length(int64_t i) ...
> the i is unused parameter, if i compile it with -Werror / -Wunused-parameter 
> flag, it will get a failure.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARROW-8821) [Rust] nested binary expression with Like, NotLike and Not operator results in type cast error

2020-05-16 Thread Andy Grove (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Grove resolved ARROW-8821.
---
Fix Version/s: 1.0.0
   Resolution: Fixed

Issue resolved by pull request 7200
[https://github.com/apache/arrow/pull/7200]

> [Rust] nested binary expression with Like, NotLike and Not operator results 
> in type cast error
> --
>
> Key: ARROW-8821
> URL: https://issues.apache.org/jira/browse/ARROW-8821
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Rust - DataFusion
>Reporter: QP Hou
>Assignee: QP Hou
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8829) [Rust] Implement SQL parser

2020-05-16 Thread Andy Grove (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Grove updated ARROW-8829:
--
Description: 
Implement SQL parser that can take a Vec and produce a SQL AST.

We can potentially break this down into separate JIRAs.

It needs to support:
 * Single table SELECT ... FROM
 * WHERE
 * GROUP BY
 * ORDER BY
 * LIMIT

It needs to support the following expressions:
 * Literals (long, string, double)
 * Identifiers
 * Binary expressions
 ** Arithmetic (+, -, *, /, %)
 ** Boolean (AND, OR)
 ** Comparison (=, !=, <, <=, >, >=, <>)
 * Unary boolean expression: NOT
 * CAST(expr AS type)
 * Aliased expressions: expr AS alias
 * Scalar functions
 * Aggregate functions

  was:
Implement SQL parser that can take a Vec and produce a SQL AST.

We can potentially break this down into separate JIRAs.

It needs to support:
 * Single table SELECT ... FROM
 * WHERE
 * GROUP BY
 * ORDER BY
 * LIMIT

It needs to support the following expressions:
 * Literals (long, string, double)
 * Identifiers
 * Binary expressions
 ** Arithmetic (+, -, *, /, %)
 ** Boolean (AND, OR)
 ** Comparison (=, !=, <, <=, >, >=, <>)
 * Unary boolean expression: NOT
 * CAST(expr AS type)
 * Aliased expressions: expr AS alias


> [Rust] Implement SQL parser
> ---
>
> Key: ARROW-8829
> URL: https://issues.apache.org/jira/browse/ARROW-8829
> Project: Apache Arrow
>  Issue Type: Sub-task
>  Components: Rust, Rust - DataFusion
>Reporter: Andy Grove
>Assignee: Andy Grove
>Priority: Major
> Fix For: 1.0.0
>
>
> Implement SQL parser that can take a Vec and produce a SQL AST.
> We can potentially break this down into separate JIRAs.
> It needs to support:
>  * Single table SELECT ... FROM
>  * WHERE
>  * GROUP BY
>  * ORDER BY
>  * LIMIT
> It needs to support the following expressions:
>  * Literals (long, string, double)
>  * Identifiers
>  * Binary expressions
>  ** Arithmetic (+, -, *, /, %)
>  ** Boolean (AND, OR)
>  ** Comparison (=, !=, <, <=, >, >=, <>)
>  * Unary boolean expression: NOT
>  * CAST(expr AS type)
>  * Aliased expressions: expr AS alias
>  * Scalar functions
>  * Aggregate functions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8829) [Rust] Implement SQL parser

2020-05-16 Thread Andy Grove (Jira)
Andy Grove created ARROW-8829:
-

 Summary: [Rust] Implement SQL parser
 Key: ARROW-8829
 URL: https://issues.apache.org/jira/browse/ARROW-8829
 Project: Apache Arrow
  Issue Type: Sub-task
  Components: Rust, Rust - DataFusion
Reporter: Andy Grove
Assignee: Andy Grove
 Fix For: 1.0.0


Implement SQL parser that can take a Vec and produce a SQL AST.

We can potentially break this down into separate JIRAs.

It needs to support:
 * Single table SELECT ... FROM
 * WHERE
 * GROUP BY
 * ORDER BY
 * LIMIT

It needs to support the following expressions:
 * Literals (long, string, double)
 * Identifiers
 * Binary expressions
 ** Arithmetic (+, -, *, /, %)
 ** Boolean (AND, OR)
 ** Comparison (=, !=, <, <=, >, >=, <>)
 * Unary boolean expression: NOT
 * CAST(expr AS type)
 * Aliased expressions: expr AS alias



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8827) [Integration Testing] Initial skeleton for Rust integration tests

2020-05-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ARROW-8827:
--
Labels: pull-request-available  (was: )

> [Integration Testing] Initial skeleton for Rust integration tests
> -
>
> Key: ARROW-8827
> URL: https://issues.apache.org/jira/browse/ARROW-8827
> Project: Apache Arrow
>  Issue Type: Improvement
>Reporter: Andy Grove
>Assignee: Andy Grove
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Initial skeleton for Rust integration tests



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8828) [Rust] Implement SQL tokenizer

2020-05-16 Thread Andy Grove (Jira)
Andy Grove created ARROW-8828:
-

 Summary: [Rust] Implement SQL tokenizer
 Key: ARROW-8828
 URL: https://issues.apache.org/jira/browse/ARROW-8828
 Project: Apache Arrow
  Issue Type: Sub-task
  Components: Rust, Rust - DataFusion
Reporter: Andy Grove
Assignee: Andy Grove
 Fix For: 1.0.0


Implement enum for all supported SQL tokens and implement a tokenizer that can 
tokenize a SQL string and produce a Vec.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8827) [Integration Testing] Initial skeleton for Rust integration tests

2020-05-16 Thread Andy Grove (Jira)
Andy Grove created ARROW-8827:
-

 Summary: [Integration Testing] Initial skeleton for Rust 
integration tests
 Key: ARROW-8827
 URL: https://issues.apache.org/jira/browse/ARROW-8827
 Project: Apache Arrow
  Issue Type: Improvement
Reporter: Andy Grove
Assignee: Andy Grove
 Fix For: 1.0.0


Initial skeleton for Rust integration tests



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8821) [Rust] nested binary expression with Like, NotLike and Not operator results in type cast error

2020-05-16 Thread QP Hou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QP Hou updated ARROW-8821:
--
Component/s: (was: Rust)
 Rust - DataFusion

> [Rust] nested binary expression with Like, NotLike and Not operator results 
> in type cast error
> --
>
> Key: ARROW-8821
> URL: https://issues.apache.org/jira/browse/ARROW-8821
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Rust - DataFusion
>Reporter: QP Hou
>Assignee: QP Hou
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8821) [Rust] nested binary expression with Like, NotLike and Not operator results in type cast error

2020-05-16 Thread QP Hou (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QP Hou updated ARROW-8821:
--
Component/s: Rust

> [Rust] nested binary expression with Like, NotLike and Not operator results 
> in type cast error
> --
>
> Key: ARROW-8821
> URL: https://issues.apache.org/jira/browse/ARROW-8821
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Rust
>Reporter: QP Hou
>Assignee: QP Hou
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-8374) [R] Table to vector of DictonaryType will error when Arrays don't have the same Dictionary per array

2020-05-16 Thread Neal Richardson (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109145#comment-17109145
 ] 

Neal Richardson commented on ARROW-8374:


Presumably there's already a C++ function that does this that we can call, yeah?

> [R] Table to vector of DictonaryType will error when Arrays don't have the 
> same Dictionary per array
> 
>
> Key: ARROW-8374
> URL: https://issues.apache.org/jira/browse/ARROW-8374
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: R
>Reporter: Francois Saint-Jacques
>Priority: Major
> Fix For: 1.0.0
>
>
> The conversion should accommodate Unifying the dictionary before converting, 
> otherwise the indices are simply broken



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8826) [Crossbow] remote URL should always have .git

2020-05-16 Thread Neal Richardson (Jira)
Neal Richardson created ARROW-8826:
--

 Summary: [Crossbow] remote URL should always have .git
 Key: ARROW-8826
 URL: https://issues.apache.org/jira/browse/ARROW-8826
 Project: Apache Arrow
  Issue Type: Improvement
  Components: Continuous Integration, Developer Tools
Reporter: Neal Richardson
Assignee: Neal Richardson


In ARROW-7803, I edited the crossbow templates for the homebrew jobs to 
substitute in the correct fork of arrow and append the current git SHA so that 
the code under test corresponds to the requested git commit. Unfortunately, 
this caused the nightly builds to fail. 

Comparing a successful on-demand run 
(https://github.com/ursa-labs/crossbow/blob/actions-266-travis-homebrew-r-autobrew/.travis.yml)
 with a nightly run 
(https://github.com/ursa-labs/crossbow/blob/nightly-2020-05-16-0-travis-homebrew-cpp/.travis.yml),
 it appears that the default "remote" URL that crossbow uses when not on a 
fork/PR does not contain the ".git" suffix. And I suspect that Homebrew 
requires that in order to identify the source as a git repo in order to clone 
it correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8825) arrow cpp edition cannot compiled pass with Wunused-parameter flag.

2020-05-16 Thread hurricanelee (Jira)
hurricanelee created ARROW-8825:
---

 Summary: arrow cpp edition cannot compiled pass with 
Wunused-parameter flag.
 Key: ARROW-8825
 URL: https://issues.apache.org/jira/browse/ARROW-8825
 Project: Apache Arrow
  Issue Type: Bug
  Components: C++
Affects Versions: 0.17.0
 Environment: mac os x/ linux
Reporter: hurricanelee
 Fix For: 0.17.0


arrow's header: array.h has a function value_length(int64_t i) ...

the i is unused parameter, if i compile it with -Werror / -Wunused-parameter 
flag, it will get a failure.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8824) [Rust] [DataFusion] Implement new SQL parser

2020-05-16 Thread Andy Grove (Jira)
Andy Grove created ARROW-8824:
-

 Summary: [Rust] [DataFusion] Implement new SQL parser
 Key: ARROW-8824
 URL: https://issues.apache.org/jira/browse/ARROW-8824
 Project: Apache Arrow
  Issue Type: Improvement
  Components: Rust, Rust - DataFusion
Reporter: Andy Grove
Assignee: Andy Grove
 Fix For: 1.0.0


We currently depend on the sqlparser crate that I originally created but has 
moved on since the version we use and that project is aiming to support 
multiple SQL dialects and I don't think it is appropriate for what we need in 
DataFusion.

I think it would be better to build a new SQL parser as part of the DataFusion 
crate so that we can more easily maintain it, and it can use Arrow as the 
native type system.

Another option would be to try and donate the sqlparser 0.2.x code base but 
there are a fair number of committers and it is probably easier just to 
implement it from scratch (without referencing the existing code).

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8782) [Rust] [DataFusion] Add benchmarks based on NYC Taxi data set

2020-05-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ARROW-8782:
--
Labels: pull-request-available  (was: )

> [Rust] [DataFusion] Add benchmarks based on NYC Taxi data set
> -
>
> Key: ARROW-8782
> URL: https://issues.apache.org/jira/browse/ARROW-8782
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Rust, Rust - DataFusion
>Reporter: Andy Grove
>Assignee: Andy Grove
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> I plan on adding a new benchmarks folder beneatch the datafusion crate, 
> containing benchmarks based on the NYC Taxi data set. The benchmark will be a 
> CLI and will support running a number of different queries against CSV and 
> Parquet.
> The README will contain instructions for downloading the data set.
> The benchmark will produce CSV files containing results.
> These benchmarks will allow us to manually verify performance before major 
> releases and on an ongoing basis as we make changes to 
> Arrow/Parquet/DataFusion.
> I will be basing this on existing benchmarks I recently built in Ballista [1] 
> (I am the only contributor to these benchmarks so far).
> A dockerfile will be provided, making it easy to restrict CPU and RAM when 
> running these benchmarks.
> [1] https://github.com/ballista-compute/ballista/tree/master/rust/benchmarks
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8823) [C++] Compute aggregate compression ratio when producing compressed IPC body messages

2020-05-16 Thread Wes McKinney (Jira)
Wes McKinney created ARROW-8823:
---

 Summary: [C++] Compute aggregate compression ratio when producing 
compressed IPC body messages
 Key: ARROW-8823
 URL: https://issues.apache.org/jira/browse/ARROW-8823
 Project: Apache Arrow
  Issue Type: Improvement
  Components: C++
Reporter: Wes McKinney


It would be beneficial to know the exact bytes-on-wire savings once the message 
has been produced. Since this computation would be relatively trivial it would 
not add overhead to the IPC write hot path. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8822) [Rust] [DataFusion] Add MemoryScan variant to LogicalPlan

2020-05-16 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ARROW-8822:
--
Labels: pull-request-available  (was: )

> [Rust] [DataFusion] Add MemoryScan variant to LogicalPlan
> -
>
> Key: ARROW-8822
> URL: https://issues.apache.org/jira/browse/ARROW-8822
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Rust, Rust - DataFusion
>Reporter: Andy Grove
>Assignee: Andy Grove
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Allow queries against Vec



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ARROW-8822) [Rust] [DataFusion] Add MemoryScan variant to LogicalPlan

2020-05-16 Thread Andy Grove (Jira)
Andy Grove created ARROW-8822:
-

 Summary: [Rust] [DataFusion] Add MemoryScan variant to LogicalPlan
 Key: ARROW-8822
 URL: https://issues.apache.org/jira/browse/ARROW-8822
 Project: Apache Arrow
  Issue Type: Improvement
  Components: Rust, Rust - DataFusion
Reporter: Andy Grove
Assignee: Andy Grove
 Fix For: 1.0.0


Allow queries against Vec



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-8559) [Rust] Consolidate Record Batch iterator traits in main arrow crate

2020-05-16 Thread Paddy Horan (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109019#comment-17109019
 ] 

Paddy Horan commented on ARROW-8559:


Yep, I agree.  Reader it is.

On the _SendableBatchReader_, both have a _schema_ method in addition to _next_ 
which have different return types _Arc_ vs _Rc_ I think.  I guess it's a 
convenience also (when used as a trait object, etc.).

> [Rust] Consolidate Record Batch iterator traits in main arrow crate
> ---
>
> Key: ARROW-8559
> URL: https://issues.apache.org/jira/browse/ARROW-8559
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: Rust
>Reporter: Paddy Horan
>Assignee: Paddy Horan
>Priority: Major
>
> We have the `BatchIterator` trait in DataFusion and the `RecordBatchReader` 
> trait in the main arrow crate.
> They differ in that `BatchIterator` is Send + Sync.  They should both be in 
> the Arrow crate and be named `BatchIterator` and `SendableBatchIterator`



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARROW-8559) [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-05-16 Thread Paddy Horan (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paddy Horan updated ARROW-8559:
---
Summary: [Rust] Consolidate Record Batch reader traits in main arrow crate  
(was: [Rust] Consolidate Record Batch iterator traits in main arrow crate)

> [Rust] Consolidate Record Batch reader traits in main arrow crate
> -
>
> Key: ARROW-8559
> URL: https://issues.apache.org/jira/browse/ARROW-8559
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: Rust
>Reporter: Paddy Horan
>Assignee: Paddy Horan
>Priority: Major
>
> We have the `BatchIterator` trait in DataFusion and the `RecordBatchReader` 
> trait in the main arrow crate.
> They differ in that `BatchIterator` is Send + Sync.  They should both be in 
> the Arrow crate and be named `BatchIterator` and `SendableBatchIterator`



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-8819) [Rust] Rust docs don't complile for the Arrow crate

2020-05-16 Thread Neville Dipale (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108906#comment-17108906
 ] 

Neville Dipale commented on ARROW-8819:
---

This has already been fixed in master

> [Rust] Rust docs don't complile for the Arrow crate
> ---
>
> Key: ARROW-8819
> URL: https://issues.apache.org/jira/browse/ARROW-8819
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: Rust
>Affects Versions: 0.17.0
>Reporter: Paddy Horan
>Priority: Major
>
> See Github [issue|https://github.com/apache/arrow/issues/7194]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARROW-8808) [Rust] Divide by zero in arrays/builder.rs

2020-05-16 Thread Neville Dipale (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neville Dipale resolved ARROW-8808.
---
Resolution: Fixed

Issue resolved by pull request 7186
[https://github.com/apache/arrow/pull/7186]

> [Rust] Divide by zero in arrays/builder.rs
> --
>
> Key: ARROW-8808
> URL: https://issues.apache.org/jira/browse/ARROW-8808
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Rust
>Reporter: Andy Grove
>Assignee: Andy Grove
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Integration testing exposed a bug in cases where values_data.len() is zero. 
> This fails with divide by zero error.
> {code:java}
> // check that values_data length is multiple of len
> assert!(
> values_data.len() / len == self.list_len as usize,
> "Values of FixedSizeList must have equal lengths, values have length {} 
> and list has {}",
> values_data.len(),
> len
> ); {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ARROW-8818) [Rust] Failing to build on master due to Flatbuffers/Union issues

2020-05-16 Thread Neville Dipale (Jira)


 [ 
https://issues.apache.org/jira/browse/ARROW-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neville Dipale resolved ARROW-8818.
---
Fix Version/s: 1.0.0
   Resolution: Fixed

Issue resolved by pull request 7198
[https://github.com/apache/arrow/pull/7198]

> [Rust] Failing to build on master due to Flatbuffers/Union issues
> -
>
> Key: ARROW-8818
> URL: https://issues.apache.org/jira/browse/ARROW-8818
> Project: Apache Arrow
>  Issue Type: New Feature
>  Components: Rust
>Reporter: Paddy Horan
>Assignee: Paddy Horan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)