[jira] [Assigned] (ARROW-7230) [C++] Use vendored std::optional instead of boost::optional in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-7230: - Assignee: Projjal Chanda > [C++] Use vendored std::optional instead of boost::optional in Gandiva > -- > > Key: ARROW-7230 > URL: https://issues.apache.org/jira/browse/ARROW-7230 > Project: Apache Arrow > Issue Type: Improvement > Components: C++, C++ - Gandiva >Reporter: Wes McKinney >Assignee: Projjal Chanda >Priority: Major > > This may help with overall codebase consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7262) [C++][Gandiva] Implement replace function in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7262. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 5902 [https://github.com/apache/arrow/pull/5902] > [C++][Gandiva] Implement replace function in Gandiva > > > Key: ARROW-7262 > URL: https://issues.apache.org/jira/browse/ARROW-7262 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Projjal Chanda >Assignee: Projjal Chanda >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > add _utf8 replace(utf8, utf8, utf8)_ function in Gandiva -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7378) loop vectorization broken in gandiva
Pindikura Ravindra created ARROW-7378: - Summary: loop vectorization broken in gandiva Key: ARROW-7378 URL: https://issues.apache.org/jira/browse/ARROW-7378 Project: Apache Arrow Issue Type: Task Components: C++ - Gandiva Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra [~yibo] pointed out in the mailing list that this is broken. I found that there is something in the last change to llvm_generator.cc that broke the auto vectorization. [https://github.com/apache/arrow/commit/165b02d2358e5c8c2039cf626ac7326d82e3ca90] If I undo this one patch, I can see the vectorization happen with Yibo Cai's test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7378) loop vectorization broken in gandiva
[ https://issues.apache.org/jira/browse/ARROW-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7378. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 6019 [https://github.com/apache/arrow/pull/6019] > loop vectorization broken in gandiva > > > Key: ARROW-7378 > URL: https://issues.apache.org/jira/browse/ARROW-7378 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [~yibo] pointed out in the mailing list that this is broken. > > I found that there is something in the last change to llvm_generator.cc that > broke the auto vectorization. > > [https://github.com/apache/arrow/commit/165b02d2358e5c8c2039cf626ac7326d82e3ca90] > > If I undo this one patch, I can see the vectorization happen with Yibo Cai's > test. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7399) gandiva does not pick runtime cpu features
Pindikura Ravindra created ARROW-7399: - Summary: gandiva does not pick runtime cpu features Key: ARROW-7399 URL: https://issues.apache.org/jira/browse/ARROW-7399 Project: Apache Arrow Issue Type: Task Components: C++ - Gandiva Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra [~yibo] reported that the IR code generated by gandiva is using 128-bit registers even though the test machine has cpu with avx2 feature. I was able to reproduce the same on a gce host. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7404) [C++][Gandiva] Fix utf8 char length error on Arm64
[ https://issues.apache.org/jira/browse/ARROW-7404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7404. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 6043 [https://github.com/apache/arrow/pull/6043] > [C++][Gandiva] Fix utf8 char length error on Arm64 > -- > > Key: ARROW-7404 > URL: https://issues.apache.org/jira/browse/ARROW-7404 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Yibo Cai >Assignee: Yibo Cai >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Current code checks if a UTF-8 eight-bit code unit is within 0x00~0x7F > by "if (c >= 0)", where c is defined as "char". This checking assumes > char is always signed, which is not true[1]. On Arm64, char is unsigned > by default and causes some Gandiva unit tests fail. > Fix it by casting to "signed char" explicitly. > [1] Cited from https://en.cppreference.com/w/cpp/language/types > The signedness of char depends on the compiler and the target platform: > the defaults for ARM and PowerPC are typically unsigned, the defaults > for x86 and x64 are typically signed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7399) [C++][Gandiva] Gandiva does not pick runtime cpu features
[ https://issues.apache.org/jira/browse/ARROW-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7399. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 6038 [https://github.com/apache/arrow/pull/6038] > [C++][Gandiva] Gandiva does not pick runtime cpu features > - > > Key: ARROW-7399 > URL: https://issues.apache.org/jira/browse/ARROW-7399 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > [~yibo] reported that the IR code generated by gandiva is using 128-bit > registers even though the test machine has cpu with avx2 feature. I was able > to reproduce the same on a gce host. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7631) [C++][Gandiva] return zero if there is an overflow while converting a decimal to a lower precision/scale
[ https://issues.apache.org/jira/browse/ARROW-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7631. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 6239 [https://github.com/apache/arrow/pull/6239] > [C++][Gandiva] return zero if there is an overflow while converting a decimal > to a lower precision/scale > > > Key: ARROW-7631 > URL: https://issues.apache.org/jira/browse/ARROW-7631 > Project: Apache Arrow > Issue Type: Bug >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > also add castDecimalNullOnOverflow function : casts a decimal to specified > precision and scale, returns null if the cast results in an overflow -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-7793) [Java] If there is a leak the base allocator should release the excess memory to parent before throwing exception
[ https://issues.apache.org/jira/browse/ARROW-7793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-7793. --- Fix Version/s: 1.0.0 Resolution: Fixed Issue resolved by pull request 6401 [https://github.com/apache/arrow/pull/6401] > [Java] If there is a leak the base allocator should release the excess memory > to parent before throwing exception > - > > Key: ARROW-7793 > URL: https://issues.apache.org/jira/browse/ARROW-7793 > Project: Apache Arrow > Issue Type: Bug >Reporter: Projjal Chanda >Assignee: Projjal Chanda >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Here [1] it should release the excess reservation minus leak to parent before > throwing exception > [1] > [https://github.com/apache/arrow/blob/762202418541e843923b8cae640d15b4952a0af6/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java#L481] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARROW-7793) [Java] If there is a leak the base allocator should release the excess memory to parent before throwing exception
[ https://issues.apache.org/jira/browse/ARROW-7793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-7793: -- Component/s: Java > [Java] If there is a leak the base allocator should release the excess memory > to parent before throwing exception > - > > Key: ARROW-7793 > URL: https://issues.apache.org/jira/browse/ARROW-7793 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Projjal Chanda >Assignee: Projjal Chanda >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Here [1] it should release the excess reservation minus leak to parent before > throwing exception > [1] > [https://github.com/apache/arrow/blob/762202418541e843923b8cae640d15b4952a0af6/java/memory/src/main/java/org/apache/arrow/memory/BaseAllocator.java#L481] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ARROW-5485) [Gandiva][Crossbow] OSx builds failing
[ https://issues.apache.org/jira/browse/ARROW-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5485. --- Resolution: Fixed Issue resolved by pull request 4499 [https://github.com/apache/arrow/pull/4499] > [Gandiva][Crossbow] OSx builds failing > -- > > Key: ARROW-5485 > URL: https://issues.apache.org/jira/browse/ARROW-5485 > Project: Apache Arrow > Issue Type: Task > Components: Packaging >Affects Versions: 0.14.0 >Reporter: Praveen Kumar Desabandu >Assignee: Wes McKinney >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > OSX builds are failing for the last 3 days. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5476) [Java][Memory] Fix Netty ArrowBuf Slice
[ https://issues.apache.org/jira/browse/ARROW-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5476. --- Resolution: Fixed Issue resolved by pull request 4451 [https://github.com/apache/arrow/pull/4451] > [Java][Memory] Fix Netty ArrowBuf Slice > --- > > Key: ARROW-5476 > URL: https://issues.apache.org/jira/browse/ARROW-5476 > Project: Apache Arrow > Issue Type: Task > Components: Java >Affects Versions: 0.14.0 >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The slice of netty arrow buf depends on arrow buf reader and writer indexes, > but arrow buf is supposed to only track memory addr + length and there are > places where the arrow buf indexes are not in sync with netty. > So slice should use the indexes in Netty Arrow Buf instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5451) [C++][Gandiva] Add round functions for decimals
[ https://issues.apache.org/jira/browse/ARROW-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5451. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4418 [https://github.com/apache/arrow/pull/4418] > [C++][Gandiva] Add round functions for decimals > --- > > Key: ARROW-5451 > URL: https://issues.apache.org/jira/browse/ARROW-5451 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Will use this Jira to add support for : > * round > * truncate > * ceil > * floor > * cast decimal to double, double to decimal > * cast decimal to long, long to decimal > * convert (modify precision/scale) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5579) [Java] shade flatbuffer dependency
Pindikura Ravindra created ARROW-5579: - Summary: [Java] shade flatbuffer dependency Key: ARROW-5579 URL: https://issues.apache.org/jira/browse/ARROW-5579 Project: Apache Arrow Issue Type: Task Components: Java Reporter: Pindikura Ravindra Reported in a [github issue|[https://github.com/apache/arrow/issues/4489]] After some [discussion|https://github.com/google/flatbuffers/issues/5368] with the Flatbuffers maintainer, it appears that FB generated code is not guaranteed to be compatible with _any other_ version of the runtime library other than the exact same version of the flatc used to compile it. This makes depending on flatbuffers in a library (like arrow) quite risky, as if an app depends on any other version of FB, either directly or transitively, it's likely the versions will clash at some point and you'll see undefined behaviour at runtime. Shading the dependency looks to me the best way to avoid this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5601) [gandiva] Error when projector with a string field
[ https://issues.apache.org/jira/browse/ARROW-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863703#comment-16863703 ] Pindikura Ravindra commented on ARROW-5601: --- we should be returning a proper status in this case too, instead of crashing. > [gandiva] Error when projector with a string field > -- > > Key: ARROW-5601 > URL: https://issues.apache.org/jira/browse/ARROW-5601 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Affects Versions: 0.13.0 > Environment: Ubuntu 16.04 x86_64 >Reporter: Sun Chenggen >Assignee: Pindikura Ravindra >Priority: Major > Original Estimate: 48h > Remaining Estimate: 48h > > when I try to select a string field by {{gandiva}} projector, it failed with > errors. > {code:python} > import pandas as pd > import pyarrow as pa > from pyarrow import gandiva > a = pd.DataFrame({'col1': ["asdf", "abc"]}) > tb = pa.Table.from_pandas(a) > teb = gandiva.TreeExprBuilder() > col1 = tb.schema[0] > node1 = teb.make_field(col1) > exp1 = teb.make_expression(node1, col1) > gandiva.make_projector(tb.schema, [exp1], pa.default_memory_pool()) > {code} > Run the code above, it crashs with error like this: > {code:bash} > python: ../lib/IR/Instructions.cpp:1202: void llvm::StoreInst::AssertOK(): > Assertion `getOperand(0)->getType() == > cast(getOperand(1)->getType())->getElementType() && "Ptr must be > a pointer to Val type!"' failed. Aborted > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ARROW-5601) [gandiva] Error when projector with a string field
[ https://issues.apache.org/jira/browse/ARROW-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-5601: - Assignee: Pindikura Ravindra > [gandiva] Error when projector with a string field > -- > > Key: ARROW-5601 > URL: https://issues.apache.org/jira/browse/ARROW-5601 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Affects Versions: 0.13.0 > Environment: Ubuntu 16.04 x86_64 >Reporter: Sun Chenggen >Assignee: Pindikura Ravindra >Priority: Major > Original Estimate: 48h > Remaining Estimate: 48h > > when I try to select a string field by {{gandiva}} projector, it failed with > errors. > {code:python} > import pandas as pd > import pyarrow as pa > from pyarrow import gandiva > a = pd.DataFrame({'col1': ["asdf", "abc"]}) > tb = pa.Table.from_pandas(a) > teb = gandiva.TreeExprBuilder() > col1 = tb.schema[0] > node1 = teb.make_field(col1) > exp1 = teb.make_expression(node1, col1) > gandiva.make_projector(tb.schema, [exp1], pa.default_memory_pool()) > {code} > Run the code above, it crashs with error like this: > {code:bash} > python: ../lib/IR/Instructions.cpp:1202: void llvm::StoreInst::AssertOK(): > Assertion `getOperand(0)->getType() == > cast(getOperand(1)->getType())->getElementType() && "Ptr must be > a pointer to Val type!"' failed. Aborted > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5602) [Java][Gandiva] Add test for decimal round functions
Pindikura Ravindra created ARROW-5602: - Summary: [Java][Gandiva] Add test for decimal round functions Key: ARROW-5602 URL: https://issues.apache.org/jira/browse/ARROW-5602 Project: Apache Arrow Issue Type: Task Components: Java Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-5601) [gandiva] Error when projector with a string field
[ https://issues.apache.org/jira/browse/ARROW-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863714#comment-16863714 ] Pindikura Ravindra commented on ARROW-5601: --- There is an existing Jira ARROW-3459 to add support for variable len output expressions in gandiva. I'll use this Jira to add a fix that gracefully fails such expressions (instead of crashing), till ARROW-3459 is fixed. > [gandiva] Error when projector with a string field > -- > > Key: ARROW-5601 > URL: https://issues.apache.org/jira/browse/ARROW-5601 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Affects Versions: 0.13.0 > Environment: Ubuntu 16.04 x86_64 >Reporter: Sun Chenggen >Assignee: Pindikura Ravindra >Priority: Major > Original Estimate: 48h > Remaining Estimate: 48h > > when I try to select a string field by {{gandiva}} projector, it failed with > errors. > {code:python} > import pandas as pd > import pyarrow as pa > from pyarrow import gandiva > a = pd.DataFrame({'col1': ["asdf", "abc"]}) > tb = pa.Table.from_pandas(a) > teb = gandiva.TreeExprBuilder() > col1 = tb.schema[0] > node1 = teb.make_field(col1) > exp1 = teb.make_expression(node1, col1) > gandiva.make_projector(tb.schema, [exp1], pa.default_memory_pool()) > {code} > Run the code above, it crashs with error like this: > {code:bash} > python: ../lib/IR/Instructions.cpp:1202: void llvm::StoreInst::AssertOK(): > Assertion `getOperand(0)->getType() == > cast(getOperand(1)->getType())->getElementType() && "Ptr must be > a pointer to Val type!"' failed. Aborted > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5602) [Java][Gandiva] Add test for decimal round functions
[ https://issues.apache.org/jira/browse/ARROW-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5602. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4568 [https://github.com/apache/arrow/pull/4568] > [Java][Gandiva] Add test for decimal round functions > > > Key: ARROW-5602 > URL: https://issues.apache.org/jira/browse/ARROW-5602 > Project: Apache Arrow > Issue Type: Task > Components: Java >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5601) [gandiva] Error when projector with a string field
[ https://issues.apache.org/jira/browse/ARROW-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5601. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4569 [https://github.com/apache/arrow/pull/4569] > [gandiva] Error when projector with a string field > -- > > Key: ARROW-5601 > URL: https://issues.apache.org/jira/browse/ARROW-5601 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Affects Versions: 0.13.0 > Environment: Ubuntu 16.04 x86_64 >Reporter: Sun Chenggen >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Original Estimate: 48h > Time Spent: 10m > Remaining Estimate: 47h 50m > > when I try to select a string field by {{gandiva}} projector, it failed with > errors. > {code:python} > import pandas as pd > import pyarrow as pa > from pyarrow import gandiva > a = pd.DataFrame({'col1': ["asdf", "abc"]}) > tb = pa.Table.from_pandas(a) > teb = gandiva.TreeExprBuilder() > col1 = tb.schema[0] > node1 = teb.make_field(col1) > exp1 = teb.make_expression(node1, col1) > gandiva.make_projector(tb.schema, [exp1], pa.default_memory_pool()) > {code} > Run the code above, it crashs with error like this: > {code:bash} > python: ../lib/IR/Instructions.cpp:1202: void llvm::StoreInst::AssertOK(): > Assertion `getOperand(0)->getType() == > cast(getOperand(1)->getType())->getElementType() && "Ptr must be > a pointer to Val type!"' failed. Aborted > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5626) [C
Pindikura Ravindra created ARROW-5626: - Summary: [C Key: ARROW-5626 URL: https://issues.apache.org/jira/browse/ARROW-5626 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ARROW-5626) [C++][Gandiva] Expression cache should consider precision and scale too
[ https://issues.apache.org/jira/browse/ARROW-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-5626: - Assignee: Pindikura Ravindra Component/s: C++ - Gandiva Summary: [C++][Gandiva] Expression cache should consider precision and scale too (was: [C) > [C++][Gandiva] Expression cache should consider precision and scale too > --- > > Key: ARROW-5626 > URL: https://issues.apache.org/jira/browse/ARROW-5626 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARROW-5636) [C++][Gandiva] Expression cache should not use ToString on data type
[ https://issues.apache.org/jira/browse/ARROW-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-5636: -- Component/s: C++ - Gandiva > [C++][Gandiva] Expression cache should not use ToString on data type > > > Key: ARROW-5636 > URL: https://issues.apache.org/jira/browse/ARROW-5636 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Priority: Major > > The expression cache in gandiva generates uses the ToString() method of > arrow::DataType() for both hashing and equality. > This is error-prone - we should have a visitor for generating hash, and use > the equality visitor for comparison. > [~fsaintjacques] [~praveenbingo] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5636) [C++][Gandiva] Expression cache should not use ToString on data type
Pindikura Ravindra created ARROW-5636: - Summary: [C++][Gandiva] Expression cache should not use ToString on data type Key: ARROW-5636 URL: https://issues.apache.org/jira/browse/ARROW-5636 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra The expression cache in gandiva generates uses the ToString() method of arrow::DataType() for both hashing and equality. This is error-prone - we should have a visitor for generating hash, and use the equality visitor for comparison. [~fsaintjacques] [~praveenbingo] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5626) [C++][Gandiva] Expression cache should consider precision and scale too
[ https://issues.apache.org/jira/browse/ARROW-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5626. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4592 [https://github.com/apache/arrow/pull/4592] > [C++][Gandiva] Expression cache should consider precision and scale too > --- > > Key: ARROW-5626 > URL: https://issues.apache.org/jira/browse/ARROW-5626 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-4923) Expose setters for Decimal vector that take long and double inputs
[ https://issues.apache.org/jira/browse/ARROW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-4923. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4591 [https://github.com/apache/arrow/pull/4591] > Expose setters for Decimal vector that take long and double inputs > -- > > Key: ARROW-4923 > URL: https://issues.apache.org/jira/browse/ARROW-4923 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Thippana Vamsi Kalyan >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Add new set methods on DecimalVector to take long and double inputs. > Methods should set Decimal value at given index like other setters available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ARROW-4923) Expose setters for Decimal vector that take long and double inputs
[ https://issues.apache.org/jira/browse/ARROW-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-4923: - Assignee: Prudhvi Porandla > Expose setters for Decimal vector that take long and double inputs > -- > > Key: ARROW-4923 > URL: https://issues.apache.org/jira/browse/ARROW-4923 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Thippana Vamsi Kalyan >Assignee: Prudhvi Porandla >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Add new set methods on DecimalVector to take long and double inputs. > Methods should set Decimal value at given index like other setters available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5701) [C++][Gandiva] Build expressions only for the required selection vector types
Pindikura Ravindra created ARROW-5701: - Summary: [C++][Gandiva] Build expressions only for the required selection vector types Key: ARROW-5701 URL: https://issues.apache.org/jira/browse/ARROW-5701 Project: Apache Arrow Issue Type: Task Components: C++ - Gandiva Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra We currently build the JIT for all known selection vector types (there are 4 supported types). For very long expressions, this increases the build time by 4x. Instead, we should build only for the required selection vector type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5701) [C++][Gandiva] Build expressions only for the required selection vector types
[ https://issues.apache.org/jira/browse/ARROW-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5701. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4667 [https://github.com/apache/arrow/pull/4667] > [C++][Gandiva] Build expressions only for the required selection vector types > - > > Key: ARROW-5701 > URL: https://issues.apache.org/jira/browse/ARROW-5701 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 10m > Remaining Estimate: 0h > > We currently build the JIT for all known selection vector types (there are 4 > supported types). For very long expressions, this increases the build time by > 4x. > > Instead, we should build only for the required selection vector type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5661) Support hash functions for decimal in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5661. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4618 [https://github.com/apache/arrow/pull/4618] > Support hash functions for decimal in Gandiva > - > > Key: ARROW-5661 > URL: https://issues.apache.org/jira/browse/ARROW-5661 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-4301) [Java][Gandiva] Maven snapshot version update does not seem to update Gandiva submodule
[ https://issues.apache.org/jira/browse/ARROW-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873873#comment-16873873 ] Pindikura Ravindra commented on ARROW-4301: --- [~wesmckinn] - gandiva java has a dependency on cpp. so, adding gandiva to the default profile will mean that the arrow java cannot be built as standalone (it can be done right now for users who don't require gandiva). > [Java][Gandiva] Maven snapshot version update does not seem to update Gandiva > submodule > --- > > Key: ARROW-4301 > URL: https://issues.apache.org/jira/browse/ARROW-4301 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva, Java >Reporter: Wes McKinney >Assignee: Praveen Kumar Desabandu >Priority: Blocker > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h > Remaining Estimate: 0h > > See > https://github.com/apache/arrow/commit/a486db8c1476be1165981c4fe22996639da8e550. > This is breaking the build so I'm going to patch manually -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-3459) [C++][Gandiva] Add support for variable length output vectors
[ https://issues.apache.org/jira/browse/ARROW-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-3459. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4760 [https://github.com/apache/arrow/pull/4760] > [C++][Gandiva] Add support for variable length output vectors > - > > Key: ARROW-3459 > URL: https://issues.apache.org/jira/browse/ARROW-3459 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Gandiva can currently handle variable length input vectors but requires the > output vectors to be fixed-length. This is because we do not have a handle to > allocate or resize arrow vectors from inside the LLVM code. Due to this > limitation, we are not able to support a lot of utf8 related functions > (convert-numeric-to-string, toupper, strstr, replace, ..). > > This needs to be fixed for both C++ and Java. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5818) [Java][Gandiva] support varlen output vectors
Pindikura Ravindra created ARROW-5818: - Summary: [Java][Gandiva] support varlen output vectors Key: ARROW-5818 URL: https://issues.apache.org/jira/browse/ARROW-5818 Project: Apache Arrow Issue Type: Task Components: Java Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5818) [Java][Gandiva] support varlen output vectors
[ https://issues.apache.org/jira/browse/ARROW-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5818. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4771 [https://github.com/apache/arrow/pull/4771] > [Java][Gandiva] support varlen output vectors > - > > Key: ARROW-5818 > URL: https://issues.apache.org/jira/browse/ARROW-5818 > Project: Apache Arrow > Issue Type: Task > Components: Java >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5483) [Java] add ValueVector constructors that take a Field object
[ https://issues.apache.org/jira/browse/ARROW-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5483. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4614 [https://github.com/apache/arrow/pull/4614] > [Java] add ValueVector constructors that take a Field object > > > Key: ARROW-5483 > URL: https://issues.apache.org/jira/browse/ARROW-5483 > Project: Apache Arrow > Issue Type: Task > Components: Java >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: arrow, pull-request-available > Fix For: 0.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Each instance of a ValueVector instantiates Field and FieldType object, which > consume 81 bytes of heap space. This duplication be avoided in cases where > all the ValueVectors belong to the same set of columns/schema. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5829) [Java] failure in TestServerOptions.domainSocket
Pindikura Ravindra created ARROW-5829: - Summary: [Java] failure in TestServerOptions.domainSocket Key: ARROW-5829 URL: https://issues.apache.org/jira/browse/ARROW-5829 Project: Apache Arrow Issue Type: Bug Components: FlightRPC, Java Reporter: Pindikura Ravindra I see this consistently with the 0.14.0 rc0 release candidate on mac mojave. java.io.IOException: Failed to bind at org.apache.arrow.flight.TestServerOptions.domainSocket(TestServerOptions.java:46) Caused by: io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5824) [Gandiva] [C++] Fix decimal null
[ https://issues.apache.org/jira/browse/ARROW-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5824. --- Resolution: Fixed Fix Version/s: 0.14.0 Issue resolved by pull request 4780 [https://github.com/apache/arrow/pull/4780] > [Gandiva] [C++] Fix decimal null > > > Key: ARROW-5824 > URL: https://issues.apache.org/jira/browse/ARROW-5824 > Project: Apache Arrow > Issue Type: Bug >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Decimal literal uses hard code precision and scale. It should use the input > precision and scale instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARROW-5824) [Gandiva] [C++] Fix decimal null
[ https://issues.apache.org/jira/browse/ARROW-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-5824: -- Component/s: C++ - Gandiva > [Gandiva] [C++] Fix decimal null > > > Key: ARROW-5824 > URL: https://issues.apache.org/jira/browse/ARROW-5824 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.14.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Decimal literal uses hard code precision and scale. It should use the input > precision and scale instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5867) [C++][Gandiva] Add support for cast int to decimal
Pindikura Ravindra created ARROW-5867: - Summary: [C++][Gandiva] Add support for cast int to decimal Key: ARROW-5867 URL: https://issues.apache.org/jira/browse/ARROW-5867 Project: Apache Arrow Issue Type: Task Components: C++ - Gandiva Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5758) [C++][Gandiva] Support casting decimals to varchar and vice versa
[ https://issues.apache.org/jira/browse/ARROW-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5758. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4803 [https://github.com/apache/arrow/pull/4803] > [C++][Gandiva] Support casting decimals to varchar and vice versa > - > > Key: ARROW-5758 > URL: https://issues.apache.org/jira/browse/ARROW-5758 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Add castDecimal(varchar), castVarchar(Decimal) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5860) [Java] [Vector] Fix decimal byte setter
[ https://issues.apache.org/jira/browse/ARROW-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5860. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4811 [https://github.com/apache/arrow/pull/4811] > [Java] [Vector] Fix decimal byte setter > --- > > Key: ARROW-5860 > URL: https://issues.apache.org/jira/browse/ARROW-5860 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5867) [C++][Gandiva] Add support for cast int to decimal
[ https://issues.apache.org/jira/browse/ARROW-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5867. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4817 [https://github.com/apache/arrow/pull/4817] > [C++][Gandiva] Add support for cast int to decimal > -- > > Key: ARROW-5867 > URL: https://issues.apache.org/jira/browse/ARROW-5867 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5872) Support mod(double, double) method in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5872. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4820 [https://github.com/apache/arrow/pull/4820] > Support mod(double, double) method in Gandiva > - > > Key: ARROW-5872 > URL: https://issues.apache.org/jira/browse/ARROW-5872 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARROW-5903) [Java] Set methods in DecimalVector are slow
Pindikura Ravindra created ARROW-5903: - Summary: [Java] Set methods in DecimalVector are slow Key: ARROW-5903 URL: https://issues.apache.org/jira/browse/ARROW-5903 Project: Apache Arrow Issue Type: Task Components: Java Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra The methods are doing a bound check on each byte in the input buffer and each byte on the output buffer. Avoiding this repetitive work improves perf by a factor of 2x to 3x. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5900) [Gandiva] [Java] Decimal precision,scale bounds check
[ https://issues.apache.org/jira/browse/ARROW-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5900. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4845 [https://github.com/apache/arrow/pull/4845] > [Gandiva] [Java] Decimal precision,scale bounds check > - > > Key: ARROW-5900 > URL: https://issues.apache.org/jira/browse/ARROW-5900 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently we accept decimal precision of values, need bounds checking that it > is between 1-38 inclusive. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARROW-5903) [Java] Set methods in DecimalVector are slow
[ https://issues.apache.org/jira/browse/ARROW-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5903. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4847 [https://github.com/apache/arrow/pull/4847] > [Java] Set methods in DecimalVector are slow > > > Key: ARROW-5903 > URL: https://issues.apache.org/jira/browse/ARROW-5903 > Project: Apache Arrow > Issue Type: Task > Components: Java >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 50m > Remaining Estimate: 0h > > The methods are doing a bound check on each byte in the input buffer and each > byte on the output buffer. Avoiding this repetitive work improves perf by a > factor of 2x to 3x. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5842) [Java] Revise the semantic of lastSet in ListVector
[ https://issues.apache.org/jira/browse/ARROW-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5842. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4797 [https://github.com/apache/arrow/pull/4797] > [Java] Revise the semantic of lastSet in ListVector > --- > > Key: ARROW-5842 > URL: https://issues.apache.org/jira/browse/ARROW-5842 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Trivial > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The {{lastSet}} member in ListVector seems misleading. According to the name, > it should refers to the last index that is actually set. However, from the > context of the code, it actually means the next index that will be set. > We fix this problem, and make it consistent with the {{lastSet}} in > {{BaseVariableWidthVector}}. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5881) [Java] Provide functionalities to efficiently determine if a validity buffer has completely 1 bits/0 bits
[ https://issues.apache.org/jira/browse/ARROW-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5881. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4829 [https://github.com/apache/arrow/pull/4829] > [Java] Provide functionalities to efficiently determine if a validity buffer > has completely 1 bits/0 bits > - > > Key: ARROW-5881 > URL: https://issues.apache.org/jira/browse/ARROW-5881 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > These utilities can be used to efficiently determine, for example, > * If all values in a vector are null > * If a vector contains no null > * If a vector contains any valid element > * If a vector contains any invalid element -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5892) [C++][Gandiva] Support function aliases
[ https://issues.apache.org/jira/browse/ARROW-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5892. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4835 [https://github.com/apache/arrow/pull/4835] > [C++][Gandiva] Support function aliases > --- > > Key: ARROW-5892 > URL: https://issues.apache.org/jira/browse/ARROW-5892 > Project: Apache Arrow > Issue Type: New Feature > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > This allows linking of several external names to the same precompiled > function. > For example, 'mod', 'modulo' can be used to access the mod function -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-5925) [Gandiva][C++] cast decimal to int should round up
Pindikura Ravindra created ARROW-5925: - Summary: [Gandiva][C++] cast decimal to int should round up Key: ARROW-5925 URL: https://issues.apache.org/jira/browse/ARROW-5925 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5944) [C++][Gandiva] Remove 'div' alias for 'divide'
[ https://issues.apache.org/jira/browse/ARROW-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5944. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4876 [https://github.com/apache/arrow/pull/4876] > [C++][Gandiva] Remove 'div' alias for 'divide' > --- > > Key: ARROW-5944 > URL: https://issues.apache.org/jira/browse/ARROW-5944 > Project: Apache Arrow > Issue Type: Task >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 10m > Remaining Estimate: 0h > > div and divide are two different operators. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-5944) [C++][Gandiva] Remove 'div' alias for 'divide'
[ https://issues.apache.org/jira/browse/ARROW-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-5944: -- Component/s: C++ - Gandiva > [C++][Gandiva] Remove 'div' alias for 'divide' > --- > > Key: ARROW-5944 > URL: https://issues.apache.org/jira/browse/ARROW-5944 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 20m > Remaining Estimate: 0h > > div and divide are two different operators. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-5925) [Gandiva][C++] cast decimal to int should round up
[ https://issues.apache.org/jira/browse/ARROW-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-5925: -- Component/s: C++ - Gandiva > [Gandiva][C++] cast decimal to int should round up > -- > > Key: ARROW-5925 > URL: https://issues.apache.org/jira/browse/ARROW-5925 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5925) [Gandiva][C++] cast decimal to int should round up
[ https://issues.apache.org/jira/browse/ARROW-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5925. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4864 [https://github.com/apache/arrow/pull/4864] > [Gandiva][C++] cast decimal to int should round up > -- > > Key: ARROW-5925 > URL: https://issues.apache.org/jira/browse/ARROW-5925 > Project: Apache Arrow > Issue Type: Bug >Reporter: Pindikura Ravindra >Assignee: Pindikura Ravindra >Priority: Major > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-5964) [C++][Gandiva] Cast double to decimal with rounding returns 0
Pindikura Ravindra created ARROW-5964: - Summary: [C++][Gandiva] Cast double to decimal with rounding returns 0 Key: ARROW-5964 URL: https://issues.apache.org/jira/browse/ARROW-5964 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra casting 1.15470053838 to decimal(18,0) gives 0. should return 1. there is a bug in the overflow check after rounding. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5957) [C++][Gandiva] Implement div function in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5957. --- Resolution: Fixed Fix Version/s: 0.14.1 Issue resolved by pull request 4887 [https://github.com/apache/arrow/pull/4887] > [C++][Gandiva] Implement div function in Gandiva > > > Key: ARROW-5957 > URL: https://issues.apache.org/jira/browse/ARROW-5957 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.14.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Implement 'div' function for int32, int64, float32, and float64 (gandiva) > types. > div is integer division - divide and return quotient after discarding the > fractional part. > The function signature is {{type div(type, type)}} > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-5957) [C++][Gandiva] Implement div function in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-5957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-5957: -- Fix Version/s: (was: 0.14.1) 1.0.0 > [C++][Gandiva] Implement div function in Gandiva > > > Key: ARROW-5957 > URL: https://issues.apache.org/jira/browse/ARROW-5957 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Implement 'div' function for int32, int64, float32, and float64 (gandiva) > types. > div is integer division - divide and return quotient after discarding the > fractional part. > The function signature is {{type div(type, type)}} > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5970) [Java] Provide pointer to Arrow buffer
[ https://issues.apache.org/jira/browse/ARROW-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5970. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4897 [https://github.com/apache/arrow/pull/4897] > [Java] Provide pointer to Arrow buffer > -- > > Key: ARROW-5970 > URL: https://issues.apache.org/jira/browse/ARROW-5970 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > Introduce pointer to a memory region within an ArrowBuf. > This pointer will be used as the basis for calculating the hash code within a > vector, and equality determination. > This data structure can be considered as a "universal value holder". -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5967) [Java] DateUtility#timeZoneList is not correct
[ https://issues.apache.org/jira/browse/ARROW-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5967. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4904 [https://github.com/apache/arrow/pull/4904] > [Java] DateUtility#timeZoneList is not correct > -- > > Key: ARROW-5967 > URL: https://issues.apache.org/jira/browse/ARROW-5967 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now {{timeZoneList}} in {{DateUtility}} belongs to Joda time. > Since we have replace Joda time with Java time in ARROW-2015, this should > also be changed. > {{TimeStampXXTZVectors}} have a timezone member which seems not used now and > its {{getObject}} returns Long(different with that in {{TimeStampXXVectors}} > which returns {{LocalDateTime}}), should it return {{LocalDateTime}} with its > timezone? > Is it reasonable if we do as follows: > # remove Joda {{timezoneList}} in {{DateUtility}} > # add method like {{getLocalDateTimeFromEpochMilli(long epochMillis, String > timezone)}} in DateUtility > # Not sure make {{TimeStampXXTZVectors}} return {{LocalDateTime}}? > cc [~emkornfi...@gmail.com] [~bryanc] [~siddteotia] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARROW-6025) [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 tests
[ https://issues.apache.org/jira/browse/ARROW-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895173#comment-16895173 ] Pindikura Ravindra commented on ARROW-6025: --- [~kszucs] - is the solution that [~wesmckinn] suggested reasonable ? If not, I'll try and find a way to disable the tests in environments where the timezone related files are missing. > [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 > tests > --- > > Key: ARROW-6025 > URL: https://issues.apache.org/jira/browse/ARROW-6025 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Krisztian Szucs >Priority: Major > > I've recently enabled gandiva in the conda c++ ursabot builders. The > container doesn't contain the required timezones do the tests are failing: > {code} > ../src/gandiva/precompiled/time_test.cc:103: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2000-09-23 9:45:30.920 Canada/Pacific", 37) > Which is: 0 > 969727530920 > ../src/gandiva/precompiled/time_test.cc:105: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2012-02-28 23:30:59 Asia/Kolkata", 32) > Which is: 0 > 1330452059000 > ../src/gandiva/precompiled/time_test.cc:107: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "1923-10-07 03:03:03 America/New_York", 36) > Which is: 0 > -1459094217000 > {code} > See build: > https://ci.ursalabs.org/#/builders/66/builds/3046/steps/8/logs/stdio -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5891) [C++][Gandiva] Remove duplicates in function registries
[ https://issues.apache.org/jira/browse/ARROW-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5891. --- Resolution: Fixed Fix Version/s: 1.0.0 Issue resolved by pull request 4853 [https://github.com/apache/arrow/pull/4853] > [C++][Gandiva] Remove duplicates in function registries > --- > > Key: ARROW-5891 > URL: https://issues.apache.org/jira/browse/ARROW-5891 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Major > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Each precompiled function should have at most one "NativeFunction" entry in > the registry. No two function signatures can refer the same precompiled > function. Also add a UnitTest which checks if there are duplicates -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5975) [C++][Gandiva] Add method to cast Date(in Milliseconds) to timestamp
[ https://issues.apache.org/jira/browse/ARROW-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5975. --- Resolution: Fixed Issue resolved by pull request 4902 [https://github.com/apache/arrow/pull/4902] > [C++][Gandiva] Add method to cast Date(in Milliseconds) to timestamp > > > Key: ARROW-5975 > URL: https://issues.apache.org/jira/browse/ARROW-5975 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Affects Versions: 1.0.0 >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > add castTIMESTAMP_date64(date64) method in Gandiva. The input date is in > milliseconds. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6023) [C++][Gandiva] Add functions in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6023. --- Resolution: Fixed Issue resolved by pull request 4932 [https://github.com/apache/arrow/pull/4932] > [C++][Gandiva] Add functions in Gandiva > --- > > Key: ARROW-6023 > URL: https://issues.apache.org/jira/browse/ARROW-6023 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 1.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > support following functions in Gandiva - > # int32 castINT(int64) : cast int64 to int32 > # float4 castFLOAT4(float8) : cast float8 to float4 > # int64 truncate(int64, int32 scale) : if scale is negative, make last > -scale digits zero > # timestamp add(date, int32 days) : add days to date(in milliseconds) and > return timestamp -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6034) [C++][Gandiva] Add string functions in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6034. --- Resolution: Fixed Fix Version/s: (was: 1.0.0) 0.15.0 Issue resolved by pull request 4942 [https://github.com/apache/arrow/pull/4942] > [C++][Gandiva] Add string functions in Gandiva > -- > > Key: ARROW-6034 > URL: https://issues.apache.org/jira/browse/ARROW-6034 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Affects Versions: 1.0.0 >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Add following functions in Gandiva - > substr(str, offset, len) : returns substring of length _len_ starting from > _offset._ negative _offset_ is counted from string end. > substr(str, offset) : returns substring starting from _offset._ negative > _offset_ is counted from string end. > concat(str1, str2) : concatenate two strings > castVARCHAR(timestamp, len) : returns timestamp as string of length _len_ > convert_fromUTF8(binary): convert binary array to string -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6021) [Java] Extract copyFrom and copyFromSafe methods to ValueVector interface
[ https://issues.apache.org/jira/browse/ARROW-6021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6021. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4931 [https://github.com/apache/arrow/pull/4931] > [Java] Extract copyFrom and copyFromSafe methods to ValueVector interface > - > > Key: ARROW-6021 > URL: https://issues.apache.org/jira/browse/ARROW-6021 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Currently we have copyFrom and copyFromSafe methods in fixed-width and > variable-width vectors. Extracting them to the common super interface will > make it much more convenient to use them, and avoid unnecessary if-else > statements. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6013) [Java] Support range searcher
[ https://issues.apache.org/jira/browse/ARROW-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6013. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4925 [https://github.com/apache/arrow/pull/4925] > [Java] Support range searcher > - > > Key: ARROW-6013 > URL: https://issues.apache.org/jira/browse/ARROW-6013 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 3h > Remaining Estimate: 0h > > For a sorted vector, the range searcher finds the first/last occurrence of a > particular element. > The search is based on binary search, which takes O(logn) time. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-6093) [Java] reduce branches in algo for first match in VectorRangeSearcher
Pindikura Ravindra created ARROW-6093: - Summary: [Java] reduce branches in algo for first match in VectorRangeSearcher Key: ARROW-6093 URL: https://issues.apache.org/jira/browse/ARROW-6093 Project: Apache Arrow Issue Type: Improvement Components: Java Reporter: Pindikura Ravindra This is a follow up Jira for the improvement suggested by [~fsaintjacques] in the PR for [https://github.com/apache/arrow/pull/4925] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6002) [C++][Gandiva] TestCastFunctions does not test int64 casting`
[ https://issues.apache.org/jira/browse/ARROW-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6002. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4991 [https://github.com/apache/arrow/pull/4991] > [C++][Gandiva] TestCastFunctions does not test int64 casting` > - > > Key: ARROW-6002 > URL: https://issues.apache.org/jira/browse/ARROW-6002 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Benjamin Kietzman >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > {{outputs[2]}} (corresponds to cast from float32) is checked twice > https://github.com/apache/arrow/pull/4817/files#diff-2e911c4dcae01ea2d3ce200892a0179aR478 > while {{outputs[1]}} is not checked (corresponds to cast from int64) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (ARROW-6002) [C++][Gandiva] TestCastFunctions does not test int64 casting`
[ https://issues.apache.org/jira/browse/ARROW-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-6002: - Assignee: Benjamin Kietzman > [C++][Gandiva] TestCastFunctions does not test int64 casting` > - > > Key: ARROW-6002 > URL: https://issues.apache.org/jira/browse/ARROW-6002 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Benjamin Kietzman >Assignee: Benjamin Kietzman >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > {{outputs[2]}} (corresponds to cast from float32) is checked twice > https://github.com/apache/arrow/pull/4817/files#diff-2e911c4dcae01ea2d3ce200892a0179aR478 > while {{outputs[1]}} is not checked (corresponds to cast from int64) -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-6116) [C++][Gandiva] Fix bug in TimedTestFilterAdd2
Pindikura Ravindra created ARROW-6116: - Summary: [C++][Gandiva] Fix bug in TimedTestFilterAdd2 Key: ARROW-6116 URL: https://issues.apache.org/jira/browse/ARROW-6116 Project: Apache Arrow Issue Type: Bug Components: C++ - Gandiva Reporter: Pindikura Ravindra The tests should be : f0 + f1 < f2, instead it's doing f1 + f2 < f2. This was reported via a PR [https://github.com/apache/arrow/pull/4976] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6112. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4976 [https://github.com/apache/arrow/pull/4976] > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Fix For: 0.15.0 > > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Issue Comment Deleted] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-6112: -- Comment: was deleted (was: Issue resolved by pull request 4976 [https://github.com/apache/arrow/pull/4976]) > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra updated ARROW-6112: -- Fix Version/s: (was: 0.15.0) > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Reopened] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reopened ARROW-6112: --- > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898754#comment-16898754 ] Pindikura Ravindra commented on ARROW-6112: --- sorry, i mistakenly put this Jira ID for an [unrelated PR |[https://github.com/apache/arrow/pull/4976]]- fixed now. > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (ARROW-6112) [Java] Update APIs to support 64-bit address space
[ https://issues.apache.org/jira/browse/ARROW-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898754#comment-16898754 ] Pindikura Ravindra edited comment on ARROW-6112 at 8/2/19 10:02 AM: sorry, i mistakenly put this Jira ID for an [unrelated PR|https://github.com/apache/arrow/pull/4976] - fixed now. was (Author: pravindra): sorry, i mistakenly put this Jira ID for an [unrelated PR |[https://github.com/apache/arrow/pull/4976]]- fixed now. > [Java] Update APIs to support 64-bit address space > -- > > Key: ARROW-6112 > URL: https://issues.apache.org/jira/browse/ARROW-6112 > Project: Apache Arrow > Issue Type: Improvement >Reporter: Micah Kornfield >Assignee: Micah Kornfield >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > The arrow spec allows for 64 bit address range for buffers (and arrays) we > should support this at the API level in Java even if the current Netty > backing buffers don't support it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6116) [C++][Gandiva] Fix bug in TimedTestFilterAdd2
[ https://issues.apache.org/jira/browse/ARROW-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6116. --- Resolution: Fixed Fix Version/s: 0.15.0 > [C++][Gandiva] Fix bug in TimedTestFilterAdd2 > - > > Key: ARROW-6116 > URL: https://issues.apache.org/jira/browse/ARROW-6116 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Pindikura Ravindra >Priority: Major > Fix For: 0.15.0 > > > The tests should be : f0 + f1 < f2, instead it's doing f1 + f2 < f2. This was > reported via a PR > > [https://github.com/apache/arrow/pull/4976] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (ARROW-6025) [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 tests
[ https://issues.apache.org/jira/browse/ARROW-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra reassigned ARROW-6025: - Assignee: Prudhvi Porandla > [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 > tests > --- > > Key: ARROW-6025 > URL: https://issues.apache.org/jira/browse/ARROW-6025 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Krisztian Szucs >Assignee: Prudhvi Porandla >Priority: Major > > I've recently enabled gandiva in the conda c++ ursabot builders. The > container doesn't contain the required timezones do the tests are failing: > {code} > ../src/gandiva/precompiled/time_test.cc:103: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2000-09-23 9:45:30.920 Canada/Pacific", 37) > Which is: 0 > 969727530920 > ../src/gandiva/precompiled/time_test.cc:105: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2012-02-28 23:30:59 Asia/Kolkata", 32) > Which is: 0 > 1330452059000 > ../src/gandiva/precompiled/time_test.cc:107: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "1923-10-07 03:03:03 America/New_York", 36) > Which is: 0 > -1459094217000 > {code} > See build: > https://ci.ursalabs.org/#/builders/66/builds/3046/steps/8/logs/stdio -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARROW-6025) [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 tests
[ https://issues.apache.org/jira/browse/ARROW-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898778#comment-16898778 ] Pindikura Ravindra commented on ARROW-6025: --- thanks [~kszucs] - we'll use this Jira to handle missing timezones. I believe we already hit this on windows too, and disabled the tests there. > [Gandiva][Test] Error handling for missing timezone in castTIMESTAMP_utf8 > tests > --- > > Key: ARROW-6025 > URL: https://issues.apache.org/jira/browse/ARROW-6025 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva >Reporter: Krisztian Szucs >Assignee: Prudhvi Porandla >Priority: Major > > I've recently enabled gandiva in the conda c++ ursabot builders. The > container doesn't contain the required timezones do the tests are failing: > {code} > ../src/gandiva/precompiled/time_test.cc:103: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2000-09-23 9:45:30.920 Canada/Pacific", 37) > Which is: 0 > 969727530920 > ../src/gandiva/precompiled/time_test.cc:105: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "2012-02-28 23:30:59 Asia/Kolkata", 32) > Which is: 0 > 1330452059000 > ../src/gandiva/precompiled/time_test.cc:107: Failure > Expected equality of these values: > castTIMESTAMP_utf8(context_ptr, "1923-10-07 03:03:03 America/New_York", 36) > Which is: 0 > -1459094217000 > {code} > See build: > https://ci.ursalabs.org/#/builders/66/builds/3046/steps/8/logs/stdio -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-5776) [Gandiva][Crossbow] Revert template to have commit ids.
[ https://issues.apache.org/jira/browse/ARROW-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-5776. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4738 [https://github.com/apache/arrow/pull/4738] > [Gandiva][Crossbow] Revert template to have commit ids. > --- > > Key: ARROW-5776 > URL: https://issues.apache.org/jira/browse/ARROW-5776 > Project: Apache Arrow > Issue Type: Bug >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > We are dependent on the commit ids being present in the cross bow travis > templates so that we can sync our builds against the same commit id that was > used to create the artifacts. > So reverting back fetch-head to give back arrow-head. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6030) [Java] Efficiently compute hash code for ArrowBufPointer
[ https://issues.apache.org/jira/browse/ARROW-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6030. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4939 [https://github.com/apache/arrow/pull/4939] > [Java] Efficiently compute hash code for ArrowBufPointer > > > Key: ARROW-6030 > URL: https://issues.apache.org/jira/browse/ARROW-6030 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > As ArrowBufHasher is introduced, we can compute the hash code of a continuous > region within an ArrowBuf. > We optimize the process to make it efficient to avoid recomputation. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6134) [C++][Gandiva] Add concat function in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-6134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6134. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5008 [https://github.com/apache/arrow/pull/5008] > [C++][Gandiva] Add concat function in Gandiva > - > > Key: ARROW-6134 > URL: https://issues.apache.org/jira/browse/ARROW-6134 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > * remove concat alias for concatOperator > * add concat(utf8, utf8) function. The difference between concat and > concatOperator is in null input handling. concatOperator returns null if one > of the inputs is null; concat treats null input as empty string -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6137) [C++][Gandiva] Change output format of castVARCHAR(timestamp) in Gandiva
[ https://issues.apache.org/jira/browse/ARROW-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6137. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5014 [https://github.com/apache/arrow/pull/5014] > [C++][Gandiva] Change output format of castVARCHAR(timestamp) in Gandiva > > > Key: ARROW-6137 > URL: https://issues.apache.org/jira/browse/ARROW-6137 > Project: Apache Arrow > Issue Type: Task > Components: C++ - Gandiva >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Format timestamp to -MM-dd hh:mm:ss.sss -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6117) [Java] Fix the set method of FixedSizeBinaryVector
[ https://issues.apache.org/jira/browse/ARROW-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6117. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4995 [https://github.com/apache/arrow/pull/4995] > [Java] Fix the set method of FixedSizeBinaryVector > -- > > Key: ARROW-6117 > URL: https://issues.apache.org/jira/browse/ARROW-6117 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > For the set method, if the parameter is null, it should clear the validity > bit. However, the current implementation throws a NullPointerException. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-6210) [Java] remove equals API from ValueVector
Pindikura Ravindra created ARROW-6210: - Summary: [Java] remove equals API from ValueVector Key: ARROW-6210 URL: https://issues.apache.org/jira/browse/ARROW-6210 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra This is a follow-up from [https://github.com/apache/arrow/pull/4933] The callers should be fixed to use the RangeEquals API instead. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARROW-6211) [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface
Pindikura Ravindra created ARROW-6211: - Summary: [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface Key: ARROW-6211 URL: https://issues.apache.org/jira/browse/ARROW-6211 Project: Apache Arrow Issue Type: Bug Reporter: Pindikura Ravindra This is a follow-up from [https://github.com/apache/arrow/pull/4933] public interface VectorVisitor \{..} In ValueVector : public OUT accept(VectorVisitor visitor, IN value) throws EX; -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6022) [Java] Support equals API in ValueVector to compare two vectors equal
[ https://issues.apache.org/jira/browse/ARROW-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6022. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 4933 [https://github.com/apache/arrow/pull/4933] > [Java] Support equals API in ValueVector to compare two vectors equal > - > > Key: ARROW-6022 > URL: https://issues.apache.org/jira/browse/ARROW-6022 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 15h 10m > Remaining Estimate: 0h > > In some case, this feature is useful. > In ARROW-1184, {{Dictionary#equals}} not work due to the lack of this API. > Moreover, we already implemented {{equals(int index, ValueVector target, int > targetIndex)}}, so this new added API could reuse it. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6200) [Java] Method getBufferSizeFor in BaseRepeatedValueVector/ListVector not correct
[ https://issues.apache.org/jira/browse/ARROW-6200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6200. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5060 [https://github.com/apache/arrow/pull/5060] > [Java] Method getBufferSizeFor in BaseRepeatedValueVector/ListVector not > correct > > > Key: ARROW-6200 > URL: https://issues.apache.org/jira/browse/ARROW-6200 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Critical > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Currently, {{getBufferSizeFor}} in {{BaseRepeatedValueVector}} implemented as > below: > {code:java} > if (valueCount == 0) { > return 0; > } > return ((valueCount + 1) * OFFSET_WIDTH) + > vector.getBufferSizeFor(valueCount); > {code} > Here vector.getBufferSizeFor(valueCount) seems not right which should be > > {code:java} > int innerVectorValueCount = offsetBuffer.getInt(valueCount * OFFSET_WIDTH); > vector.getBufferSizeFor(innerVectorValueCount) > {code} > ListVector has the same problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARROW-6211) [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface
[ https://issues.apache.org/jira/browse/ARROW-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905880#comment-16905880 ] Pindikura Ravindra commented on ARROW-6211: --- yes, I think it should. > [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface > - > > Key: ARROW-6211 > URL: https://issues.apache.org/jira/browse/ARROW-6211 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Pindikura Ravindra >Assignee: Ji Liu >Priority: Major > > This is a follow-up from [https://github.com/apache/arrow/pull/4933] > > public interface VectorVisitor \{..} > > In ValueVector : > public OUT accept(VectorVisitor > visitor, IN value) throws EX; > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARROW-6211) [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface
[ https://issues.apache.org/jira/browse/ARROW-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906084#comment-16906084 ] Pindikura Ravindra commented on ARROW-6211: --- It'll be useful for generic visitors to carry state (the IN value allows that). For the RangeEqualsVisitors, you can always use Void. > [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface > - > > Key: ARROW-6211 > URL: https://issues.apache.org/jira/browse/ARROW-6211 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Pindikura Ravindra >Assignee: Ji Liu >Priority: Major > > This is a follow-up from [https://github.com/apache/arrow/pull/4933] > > public interface VectorVisitor \{..} > > In ValueVector : > public OUT accept(VectorVisitor > visitor, IN value) throws EX; > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6156) [Java] Support compare semantics for ArrowBufPointer
[ https://issues.apache.org/jira/browse/ARROW-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6156. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5030 [https://github.com/apache/arrow/pull/5030] > [Java] Support compare semantics for ArrowBufPointer > > > Key: ARROW-6156 > URL: https://issues.apache.org/jira/browse/ARROW-6156 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Compare two arrow buffer pointers by their content in lexicographic order. > null is smaller and shorter buffer is smaller. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6143) [Java] Unify the copyFrom and copyFromSafe methods for all vectors
[ https://issues.apache.org/jira/browse/ARROW-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6143. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5019 [https://github.com/apache/arrow/pull/5019] > [Java] Unify the copyFrom and copyFromSafe methods for all vectors > -- > > Key: ARROW-6143 > URL: https://issues.apache.org/jira/browse/ARROW-6143 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Some vectors have their own implementations of copyFrom and copyFromSafe > methods. > Since we have extracted the copyFrom and copyFromSafe methods to the base > interface (see ARROW-6021), we want all vectors' implementations to override > the methods from the super interface. > This will provide a unified way of copying data elements. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6208) [Java] Correct byte order before comparing in ByteFunctionHelpers
[ https://issues.apache.org/jira/browse/ARROW-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6208. --- Resolution: Fixed Fix Version/s: (was: 1.0.0) 0.15.0 Issue resolved by pull request 5063 [https://github.com/apache/arrow/pull/5063] > [Java] Correct byte order before comparing in ByteFunctionHelpers > - > > Key: ARROW-6208 > URL: https://issues.apache.org/jira/browse/ARROW-6208 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Affects Versions: 1.0.0 >Reporter: Prudhvi Porandla >Assignee: Prudhvi Porandla >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6264) [Java] There is no need to consider byte order in ArrowBufHasher
[ https://issues.apache.org/jira/browse/ARROW-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6264. --- Resolution: Fixed Fix Version/s: 0.15.0 Issue resolved by pull request 5098 [https://github.com/apache/arrow/pull/5098] > [Java] There is no need to consider byte order in ArrowBufHasher > > > Key: ARROW-6264 > URL: https://issues.apache.org/jira/browse/ARROW-6264 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Liya Fan >Assignee: Liya Fan >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > According to the discussion in > [https://github.com/apache/arrow/pull/5063#issuecomment-521276547|https://github.com/apache/arrow/pull/5063#issuecomment-521276547.], > Arrow has a mechanism to make sure the data is stored in little-endian, so > there is no need to check byte order. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARROW-6211) [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface
[ https://issues.apache.org/jira/browse/ARROW-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6211. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request 5091 [https://github.com/apache/arrow/pull/5091] > [Java] Remove dependency on RangeEqualsVisitor from ValueVector interface > - > > Key: ARROW-6211 > URL: https://issues.apache.org/jira/browse/ARROW-6211 > Project: Apache Arrow > Issue Type: Bug > Components: Java >Reporter: Pindikura Ravindra >Assignee: Ji Liu >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > This is a follow-up from [https://github.com/apache/arrow/pull/4933] > > public interface VectorVisitor \{..} > > In ValueVector : > public OUT accept(VectorVisitor > visitor, IN value) throws EX; > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (ARROW-6250) [Java] Implement ApproxEqualsVisitor comparing approx for floating point
[ https://issues.apache.org/jira/browse/ARROW-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6250. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request 5118 [https://github.com/apache/arrow/pull/5118] > [Java] Implement ApproxEqualsVisitor comparing approx for floating point > > > Key: ARROW-6250 > URL: https://issues.apache.org/jira/browse/ARROW-6250 > Project: Apache Arrow > Issue Type: New Feature > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Critical > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently we already implemented {{RangeEqualsVisitor/VectorEqualsVisitor}} > for comparing range/vector. > And ARROW-6211 is created to make {{ValueVector}} work with generic visitor. > We should also implement {{ApproxEqualsVisitor}} to compare floating point > just like cpp does > [https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (ARROW-6289) [Java] Add empty() in UnionVector to create instance
[ https://issues.apache.org/jira/browse/ARROW-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6289. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request 5115 [https://github.com/apache/arrow/pull/5115] > [Java] Add empty() in UnionVector to create instance > > > Key: ARROW-6289 > URL: https://issues.apache.org/jira/browse/ARROW-6289 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Minor > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Currently complex type vectors all have {{empty}}() API to create instance > except {{UnionVector}}. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (ARROW-6311) [Java] Make ApproxEqualsVisitor accept DiffFunction to make it more flexible
[ https://issues.apache.org/jira/browse/ARROW-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6311. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request 5155 [https://github.com/apache/arrow/pull/5155] > [Java] Make ApproxEqualsVisitor accept DiffFunction to make it more flexible > > > Key: ARROW-6311 > URL: https://issues.apache.org/jira/browse/ARROW-6311 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Ji Liu >Assignee: Ji Liu >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently {{ApproxEqualsVisitor}} will accept a epsilon for both float and > double compare, and the difference calculation is always {{Math.abs}}(f1-f2) > For some cases like {{Validator}} it is not very suitable as: > i. it has different epsilon values for float/double > ii. it difference function is not Math.abs(f1-f2) > > To resolve these, make this visitor accept both float/double epsilons and > diff functions. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (ARROW-6332) [Java][C++][Gandiva] Handle size of varchar vectors correctly
[ https://issues.apache.org/jira/browse/ARROW-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pindikura Ravindra resolved ARROW-6332. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request 5179 [https://github.com/apache/arrow/pull/5179] > [Java][C++][Gandiva] Handle size of varchar vectors correctly > - > > Key: ARROW-6332 > URL: https://issues.apache.org/jira/browse/ARROW-6332 > Project: Apache Arrow > Issue Type: Bug > Components: C++ - Gandiva, Java >Reporter: Praveen Kumar Desabandu >Assignee: Praveen Kumar Desabandu >Priority: Major > Labels: pull-request-available > Fix For: 0.15.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Currently we default the initial size of variable width vectors. This limits > that maximum size of these buffers to 3969 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (ARROW-6383) [Java] report outstanding child allocators on parent allocator close
Pindikura Ravindra created ARROW-6383: - Summary: [Java] report outstanding child allocators on parent allocator close Key: ARROW-6383 URL: https://issues.apache.org/jira/browse/ARROW-6383 Project: Apache Arrow Issue Type: Task Reporter: Pindikura Ravindra Assignee: Pindikura Ravindra when a parent allocator is closed, we should report the child allocators if any are outstanding. This helps in debugging memory leaks - will tell if the leak happened in the parent or the child. -- This message was sent by Atlassian Jira (v8.3.2#803003)