[jira] [Comment Edited] (ARROW-1380) [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests
[
https://issues.apache.org/jira/browse/ARROW-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586818#comment-16586818
]
Lukasz Bartnik edited comment on ARROW-1380 at 8/21/18 2:43 AM:
All Valgrind errors seem to originate in libpython. I re-ran:
{code}export PLASMA_VALGRIND=1
python \-m pytest \-vv \-r sxX --durations=15 -s $PYARROW_PATH --parquet{code}
with a suppression file aiming at {code}obj:*/libpython3.6m.so*{code}
(attached) and all errors got suppressed. Another way to show it is to extract
all suppressions from Valgrind: there are no C++ related context filters among
those extracted suppressions.
was (Author: lbartnik):
All Valgrind errors seem to originate in libpython. I re-ran:
{{export PLASMA_VALGRIND=1 }}
{{python -m pytest -vv -r sxX --durations=15 -s $PYARROW_PATH --parquet}}
with a suppression file aiming at _obj:*/libpython3.6m.so*_ (attached) and all
errors got suppressed. Another way to show it is to extract all suppressions
from Valgrind: there are no C++ related context filters among those extracted
suppressions.
> [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests
> -
>
> Key: ARROW-1380
> URL: https://issues.apache.org/jira/browse/ARROW-1380
> Project: Apache Arrow
> Issue Type: Bug
> Components: Plasma (C++)
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.11.0
>
> Attachments: LastTest.log, valgrind.supp_
>
>
> I thought I fixed this, but they seem to have recurred:
> https://travis-ci.org/apache/arrow/jobs/266421430#L5220
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (ARROW-1380) [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests
[
https://issues.apache.org/jira/browse/ARROW-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586818#comment-16586818
]
Lukasz Bartnik edited comment on ARROW-1380 at 8/21/18 2:39 AM:
All Valgrind errors seem to originate in libpython. I re-ran:
{{export PLASMA_VALGRIND=1 }}
{{python -m pytest -vv -r sxX --durations=15 -s $PYARROW_PATH --parquet}}
with a suppression file aiming at _obj:*/libpython3.6m.so*_ (attached) and all
errors got suppressed. Another way to show it is to extract all suppressions
from Valgrind: there are no C++ related context filters among those extracted
suppressions.
was (Author: lbartnik):
All valgrind errors seem to originate in libpython. I re-ran:
{{export PLASMA_VALGRIND=1 }}
{{python -m pytest -vv -r sxX --durations=15 -s $PYARROW_PATH –parquet}}
with a suppression file aiming at _obj:*/libpython3.6m.so*_ (attached) and all
errors got suppressed. Another way to show it is to extract all suppressions
from Valgrind: there are no C++ related context filters among those extracted
suppressions.
> [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests
> -
>
> Key: ARROW-1380
> URL: https://issues.apache.org/jira/browse/ARROW-1380
> Project: Apache Arrow
> Issue Type: Bug
> Components: Plasma (C++)
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.11.0
>
> Attachments: LastTest.log, valgrind.supp_
>
>
> I thought I fixed this, but they seem to have recurred:
> https://travis-ci.org/apache/arrow/jobs/266421430#L5220
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (ARROW-1380) [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests
[ https://issues.apache.org/jira/browse/ARROW-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583276#comment-16583276 ] Lukasz Bartnik edited comment on ARROW-1380 at 8/17/18 2:22 AM: I took a quick look at a recent build ([https://travis-ci.org/apache/arrow/builds/417014924).] Neither of its C++ jobs ([https://travis-ci.org/apache/arrow/jobs/417014931] and [https://travis-ci.org/apache/arrow/jobs/417014927)] seem to use valgrind. The only job that seems to use valgrind is the openjdk8/gcc one ([https://travis-ci.org/apache/arrow/jobs/417014925)] but there are no reports from valgrind in the log; in fact, valgrind doesn't seem to be used there at all. Looking at job descriptions: the original job where "still reachable" blocks are reported was a "gcc C++" one, but there were two such jobs back then (3786.1 and 3786.8) whereas there's only one now (9492.7). It seem that the error has been fixed between builds 3786 and 9492. I'm attaching the LastTest.log which does not contain any valgrind alarms: every "HEAP SUMMARY" line is followed by a "in use at exit: 0 bytes in 0 blocks" line. was (Author: lbartnik): I took a quick look at a recent build ([https://travis-ci.org/apache/arrow/builds/417014924).] Neither of its C++ jobs ([https://travis-ci.org/apache/arrow/jobs/417014931] and [https://travis-ci.org/apache/arrow/jobs/417014927)] seem to use valgrind. The only job that seems to use valgrind is the openjdk8/gcc one ([https://travis-ci.org/apache/arrow/jobs/417014925)] but there are no reports from valgrind in the log; in fact, valgrind doesn't seem to be used there at all. Looking at job descriptions: the original job where "still reachable" blocks are reported was a "gcc C++" one, but there were two such jobs back then (3786.1 and 3786.8) whereas there's only one now (9492.7). It seem that the error has been fixed between builds 3786 and 9492. I'm attaching the LastTest.log which does not contain any valgrind alarms: every "HEAP SUMMARY" line is followed by a "in use at exit: 0 bytes in 0 blocks" line. > [C++] Fix "still reachable" valgrind warnings in Plasma Python unit tests > - > > Key: ARROW-1380 > URL: https://issues.apache.org/jira/browse/ARROW-1380 > Project: Apache Arrow > Issue Type: Bug > Components: Plasma (C++) >Reporter: Wes McKinney >Priority: Major > Fix For: 0.11.0 > > Attachments: LastTest.log > > > I thought I fixed this, but they seem to have recurred: > https://travis-ci.org/apache/arrow/jobs/266421430#L5220 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
