[jira] [Commented] (ARROW-1536) [C++] Do not transitively depend on libboost_system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARROW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172684#comment-16172684
 ] 

ASF GitHub Bot commented on ARROW-1536:
---

Github user asfgit closed the pull request at:

https://github.com/apache/arrow/pull/1105


> [C++] Do not transitively depend on libboost_system
> ---
>
> Key: ARROW-1536
> URL: https://issues.apache.org/jira/browse/ARROW-1536
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.7.0
>Reporter: Wes McKinney
>  Labels: pull-request-available
> Fix For: 0.8.0
>
>
> We picked up this dependency recently. I don't think this is a blocker for 
> 0.7.0, but it impacts static linkers (e.g. linkers of parquet-cpp)
> This was introduced in ARROW-1339 
> https://github.com/apache/arrow/commit/94b7cfafae0bda8f68ee3e5e9702c954b0116203
> cc [~mdeepak]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1536) [C++] Do not transitively depend on libboost_system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARROW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170793#comment-16170793
 ] 

ASF GitHub Bot commented on ARROW-1536:
---

Github user wesm commented on the issue:

https://github.com/apache/arrow/pull/1105
  
Can you also rebase? thanks


> [C++] Do not transitively depend on libboost_system
> ---
>
> Key: ARROW-1536
> URL: https://issues.apache.org/jira/browse/ARROW-1536
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.7.0
>Reporter: Wes McKinney
>  Labels: pull-request-available
> Fix For: 0.8.0
>
>
> We picked up this dependency recently. I don't think this is a blocker for 
> 0.7.0, but it impacts static linkers (e.g. linkers of parquet-cpp)
> This was introduced in ARROW-1339 
> https://github.com/apache/arrow/commit/94b7cfafae0bda8f68ee3e5e9702c954b0116203
> cc [~mdeepak]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1536) [C++] Do not transitively depend on libboost_system

[Deepak Majeti (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARROW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169176#comment-16169176
 ] 

Deepak Majeti commented on ARROW-1536:
--

[~wesmckinn] I made an attempt here https://github.com/apache/arrow/pull/1105. 
Please let me know what you think. Thanks!

> [C++] Do not transitively depend on libboost_system
> ---
>
> Key: ARROW-1536
> URL: https://issues.apache.org/jira/browse/ARROW-1536
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.7.0
>Reporter: Wes McKinney
>  Labels: pull-request-available
> Fix For: 0.8.0
>
>
> We picked up this dependency recently. I don't think this is a blocker for 
> 0.7.0, but it impacts static linkers (e.g. linkers of parquet-cpp)
> This was introduced in ARROW-1339 
> https://github.com/apache/arrow/commit/94b7cfafae0bda8f68ee3e5e9702c954b0116203
> cc [~mdeepak]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1536) [C++] Do not transitively depend on libboost_system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARROW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169175#comment-16169175
 ] 

ASF GitHub Bot commented on ARROW-1536:
---

GitHub user majetideepak opened a pull request:

https://github.com/apache/arrow/pull/1105

ARROW-1536:[C++] Do not transitively depend on libboost_system



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majetideepak/arrow ARROW-1536

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/arrow/pull/1105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1105


commit 73eeb63a5426e47e7321d245c8059a3c341f983c
Author: Deepak Majeti 
Date:   2017-09-17T02:51:06Z

ARROW-1536:[C++] Do not transitively depend on libboost_system




> [C++] Do not transitively depend on libboost_system
> ---
>
> Key: ARROW-1536
> URL: https://issues.apache.org/jira/browse/ARROW-1536
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.7.0
>Reporter: Wes McKinney
>  Labels: pull-request-available
> Fix For: 0.8.0
>
>
> We picked up this dependency recently. I don't think this is a blocker for 
> 0.7.0, but it impacts static linkers (e.g. linkers of parquet-cpp)
> This was introduced in ARROW-1339 
> https://github.com/apache/arrow/commit/94b7cfafae0bda8f68ee3e5e9702c954b0116203
> cc [~mdeepak]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1536) [C++] Do not transitively depend on libboost_system

[Wes McKinney (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARROW-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168624#comment-16168624
 ] 

Wes McKinney commented on ARROW-1536:
-

[~mdeepak] I took a quick look at this. {{boost::system}} symbols are getting 
pulled in as a transitive dependency to {{boost::filesystem}}. We need 
{{boost::filesystem}} for handling unicode file paths on Windows. Trying to 
conditionally use boost::filesystem only on Windows would be a lot of work 
without a great deal of benefit.

One solution to this problem would be to add an option to vendor the requisite 
Boost bits in parquet-cpp, like we've done in Arrow 

https://github.com/apache/arrow/blob/master/cpp/CMakeLists.txt#L129

https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L139

> [C++] Do not transitively depend on libboost_system
> ---
>
> Key: ARROW-1536
> URL: https://issues.apache.org/jira/browse/ARROW-1536
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
>Affects Versions: 0.7.0
>Reporter: Wes McKinney
> Fix For: 0.8.0
>
>
> We picked up this dependency recently. I don't think this is a blocker for 
> 0.7.0, but it impacts static linkers (e.g. linkers of parquet-cpp)
> This was introduced in ARROW-1339 
> https://github.com/apache/arrow/commit/94b7cfafae0bda8f68ee3e5e9702c954b0116203
> cc [~mdeepak]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)