[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695013#comment-16695013 ] Wes McKinney commented on ARROW-1688: - OK great, I am leaving in 0.12 > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Bryan Cutler >Priority: Major > Fix For: 0.12.0 > > > see discussion in ARROW-1474 > My plan is to separate the stylecheck fixes into manageable chunks so they > are easier to review. I'll do this by enabling the build to fail on style, > then suppressing all checks but the ones to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687191#comment-16687191 ] Bryan Cutler commented on ARROW-1688: - I think I can finish this up by 0.12, just need to enable Javadoc checks and then do a little writeup of the style changes > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Bryan Cutler >Priority: Major > Fix For: 0.12.0 > > > see discussion in ARROW-1474 > My plan is to separate the stylecheck fixes into manageable chunks so they > are easier to review. I'll do this by enabling the build to fail on style, > then suppressing all checks but the ones to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687164#comment-16687164 ] Wes McKinney commented on ARROW-1688: - [~bryanc] where are we at on this for 0.12? > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Bryan Cutler >Priority: Major > Fix For: 0.12.0 > > > see discussion in ARROW-1474 > My plan is to separate the stylecheck fixes into manageable chunks so they > are easier to review. I'll do this by enabling the build to fail on style, > then suppressing all checks but the ones to be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591985#comment-16591985 ] Bryan Cutler commented on ARROW-1688: - I'll start looking into this and break it into smaller tasks if it makes sense > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.11.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588498#comment-16588498 ] Uwe L. Korn commented on ARROW-1688: Any chance to get this into 0.11? [~siddteotia] [~bryanc]? > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.11.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545991#comment-16545991 ] Wes McKinney commented on ARROW-1688: - Moved to 0.11 since it doesn't look like this will get completely done in 0.10 > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.11.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534164#comment-16534164 ] Wes McKinney commented on ARROW-1688: - Yes, sounds good to me. Please feel free to bite of a chunk of work and add some child JIRAs > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java - Vectors >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.10.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533990#comment-16533990 ] Bryan Cutler commented on ARROW-1688: - Would it help to break this up into parts by only enabling certain rules at a time? Like fixing import order first, etc. > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java - Vectors >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.10.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-1688) [Java] Fail build on checkstyle warnings
[ https://issues.apache.org/jira/browse/ARROW-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530248#comment-16530248 ] Siddharth Teotia commented on ARROW-1688: - [~wesmckinn], I am not entirely sure if I will get to it in the next week or so. Definitely shooting for it though. > [Java] Fail build on checkstyle warnings > > > Key: ARROW-1688 > URL: https://issues.apache.org/jira/browse/ARROW-1688 > Project: Apache Arrow > Issue Type: Improvement > Components: Java - Vectors >Reporter: Wes McKinney >Assignee: Siddharth Teotia >Priority: Major > Fix For: 0.10.0 > > > see discussion in ARROW-1474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
