[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-11-07 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242582#comment-16242582
 ] 

Ted Yu commented on ARROW-1694:
---

Makes sense - reader is closed in execute().

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-11-04 Thread Li Jin (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239168#comment-16239168
 ] 

Li Jin commented on ARROW-1694:
---

I don't think this is a bug. From my understanding, dictionary vectors should 
be kept open if the reader is open. Closing the root here:
https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/file/json/JsonFileReader.java#L154

will close the dictionary vectors.

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-11-03 Thread Wes McKinney (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238660#comment-16238660
 ] 

Wes McKinney commented on ARROW-1694:
-

Can someone submit a patch for this?

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-10-28 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223730#comment-16223730
 ] 

Ted Yu commented on ARROW-1694:
---

After reading / parsing, the VectorSchemaRoot is no longer needed. Hence root 
should be closed before returning from method.

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-10-20 Thread Li Jin (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212982#comment-16212982
 ] 

Li Jin commented on ARROW-1694:
---

[~tedxu], why do you think the root should be closed here? 

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-10-20 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212969#comment-16212969
 ] 

Ted Yu commented on ARROW-1694:
---

java/vector/src/main/java/org/apache/arrow/vector/file/json/JsonFileReader.java

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-10-20 Thread Li Jin (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212965#comment-16212965
 ] 

Li Jin commented on ARROW-1694:
---

If the code example is existing code, can you link to the source code?

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARROW-1694) [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()

2017-10-20 Thread Li Jin (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARROW-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212963#comment-16212963
 ] 

Li Jin commented on ARROW-1694:
---

[~tedxu] can you be more explicit about the code example here? What is "read" 
here?

> [Java] Unclosed VectorSchemaRoot in JsonFileReader#readDictionaryBatches()
> --
>
> Key: ARROW-1694
> URL: https://issues.apache.org/jira/browse/ARROW-1694
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: Java - Vectors
>Reporter: Ted Yu
>Priority: Minor
> Fix For: 0.8.0
>
>
> {code}
>   VectorSchemaRoot root = new VectorSchemaRoot(fields, vectors, 
> vector.getAccessor().getValueCount());
>   read(root);
> {code}
> root should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)