[jira] [Commented] (ARROW-1717) [Java] Decide what to do with public static helper method in vector classes for JSONReader/Writer
[ https://issues.apache.org/jira/browse/ARROW-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242586#comment-16242586 ] ASF GitHub Bot commented on ARROW-1717: --- BryanCutler commented on issue #1290: [ARROW-1717] Refactor JsonReader URL: https://github.com/apache/arrow/pull/1290#issuecomment-342577047 +1, I prefer it this way to keep the vector classes cleaner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Java] Decide what to do with public static helper method in vector classes > for JSONReader/Writer > - > > Key: ARROW-1717 > URL: https://issues.apache.org/jira/browse/ARROW-1717 > Project: Apache Arrow > Issue Type: Sub-task >Reporter: Li Jin > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1717) [Java] Decide what to do with public static helper method in vector classes for JSONReader/Writer
[ https://issues.apache.org/jira/browse/ARROW-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242564#comment-16242564 ] ASF GitHub Bot commented on ARROW-1717: --- icexelloss commented on issue #1290: [ARROW-1717] Refactor JsonReader URL: https://github.com/apache/arrow/pull/1290#issuecomment-342574257 cc @BryanCutler @siddharthteotia This patch cleans up JsonReader. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Java] Decide what to do with public static helper method in vector classes > for JSONReader/Writer > - > > Key: ARROW-1717 > URL: https://issues.apache.org/jira/browse/ARROW-1717 > Project: Apache Arrow > Issue Type: Sub-task >Reporter: Li Jin > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARROW-1717) [Java] Decide what to do with public static helper method in vector classes for JSONReader/Writer
[ https://issues.apache.org/jira/browse/ARROW-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242553#comment-16242553 ] ASF GitHub Bot commented on ARROW-1717: --- icexelloss opened a new pull request #1290: [ARROW-1717] Refactor JsonReader URL: https://github.com/apache/arrow/pull/1290 This patch: * Refactor JsonReader and remove static helper function in vector classes * Fix integration test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Java] Decide what to do with public static helper method in vector classes > for JSONReader/Writer > - > > Key: ARROW-1717 > URL: https://issues.apache.org/jira/browse/ARROW-1717 > Project: Apache Arrow > Issue Type: Sub-task >Reporter: Li Jin > Labels: pull-request-available > Fix For: 0.8.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
