[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[
https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570203#comment-16570203
]
Antoine Pitrou commented on ARROW-2061:
---
I'd estimate we spend 1-2 minutes in {{test_plasma.py}} indeed:
[https://travis-ci.org/apache/arrow/jobs/412563130#L9303]
> [C++] Run ASAN builds in Travis CI
> --
>
> Key: ARROW-2061
> URL: https://issues.apache.org/jira/browse/ARROW-2061
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Wes McKinney
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.11.0
>
>
> [Address
> Sanitizer|https://github.com/google/sanitizers/wiki/AddressSanitizer] might
> be a better alternative to valgrind in clang or gcc builds. As part of this,
> we should also document how users can run their own local ASAN builds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[
https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570166#comment-16570166
]
Wes McKinney commented on ARROW-2061:
-
The {{PLASMA_VALGRIND=1}} option has a significant impact also
> [C++] Run ASAN builds in Travis CI
> --
>
> Key: ARROW-2061
> URL: https://issues.apache.org/jira/browse/ARROW-2061
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Wes McKinney
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.11.0
>
>
> [Address
> Sanitizer|https://github.com/google/sanitizers/wiki/AddressSanitizer] might
> be a better alternative to valgrind in clang or gcc builds. As part of this,
> we should also document how users can run their own local ASAN builds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[ https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570158#comment-16570158 ] Antoine Pitrou commented on ARROW-2061: --- Note the current testing duration with Valgrind is 3 minutes, which isn't enormous either: https://travis-ci.org/apache/arrow/jobs/412563130#L2044 > [C++] Run ASAN builds in Travis CI > -- > > Key: ARROW-2061 > URL: https://issues.apache.org/jira/browse/ARROW-2061 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Uwe L. Korn >Priority: Major > Fix For: 0.11.0 > > > [Address > Sanitizer|https://github.com/google/sanitizers/wiki/AddressSanitizer] might > be a better alternative to valgrind in clang or gcc builds. As part of this, > we should also document how users can run their own local ASAN builds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[
https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570143#comment-16570143
]
Wes McKinney commented on ARROW-2061:
-
I see. Valgrind is pretty useful, then. We might want to see if there's a way
to opt in to valgrind (using {{[valgrind]}} or some tag in commit messages) if
we decide to cut build times by turning off valgrind by default
> [C++] Run ASAN builds in Travis CI
> --
>
> Key: ARROW-2061
> URL: https://issues.apache.org/jira/browse/ARROW-2061
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Wes McKinney
>Assignee: Uwe L. Korn
>Priority: Major
> Fix For: 0.11.0
>
>
> [Address
> Sanitizer|https://github.com/google/sanitizers/wiki/AddressSanitizer] might
> be a better alternative to valgrind in clang or gcc builds. As part of this,
> we should also document how users can run their own local ASAN builds
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[ https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570114#comment-16570114 ] Antoine Pitrou commented on ARROW-2061: --- According to [AddressSanitizerComparisonOfMemoryTools|https://github.com/google/sanitizers/wiki/AddressSanitizerComparisonOfMemoryTools], ASAN won't detect reads of uninitialized memory, unlike Valgrind. Such detection can be done by [Memory Sanitizer|https://github.com/google/sanitizers/wiki/MemorySanitizer], which unfortunately requires rebuilding all dependencies including libstdc++. > [C++] Run ASAN builds in Travis CI > -- > > Key: ARROW-2061 > URL: https://issues.apache.org/jira/browse/ARROW-2061 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Uwe L. Korn >Priority: Major > Fix For: 0.11.0 > > > [Address > Sanitizer|https://github.com/google/sanitizers/wiki/AddressSanitizer] might > be a better alternative to valgrind in clang or gcc builds. As part of this, > we should also document how users can run their own local ASAN builds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[ https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528758#comment-16528758 ] Uwe L. Korn commented on ARROW-2061: Having ASAN in PR builds and valgrind in nightlies sounds fine. ASAN is much faster but I still have the feeling that valgrind highlights a bit more memory issues. > [C++] Run ASAN builds in Travis CI > -- > > Key: ARROW-2061 > URL: https://issues.apache.org/jira/browse/ARROW-2061 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Uwe L. Korn >Priority: Major > Fix For: 0.10.0 > > > ASAN might be a better alternative to valgrind in builds where we have clang > available. As part of this, we should also document how users can run their > own local ASAN builds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2061) [C++] Run ASAN builds in Travis CI
[ https://issues.apache.org/jira/browse/ARROW-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527853#comment-16527853 ] Wes McKinney commented on ARROW-2061: - We are using clang in our builds now. Any objections to switching to ASAN from valgrind? > [C++] Run ASAN builds in Travis CI > -- > > Key: ARROW-2061 > URL: https://issues.apache.org/jira/browse/ARROW-2061 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Uwe L. Korn >Priority: Major > Fix For: 0.10.0 > > > ASAN might be a better alternative to valgrind in builds where we have clang > available. As part of this, we should also document how users can run their > own local ASAN builds -- This message was sent by Atlassian JIRA (v7.6.3#76005)
