[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381217#comment-16381217
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

cpcloud closed pull request #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/appveyor.yml b/appveyor.yml
index 22d6158be..42c0ae34c 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -26,56 +26,69 @@ only_commits:
 - cpp/
 - python/
 
+cache:
+  - C:\Users\Appveyor\clcache
+
 environment:
   matrix:
+# NOTE: clcache seems to work best with Ninja and worst with msbuild
+# (as generated by cmake)
 - JOB: "Build"
-  GENERATOR: Visual Studio 15 2017 Win64
-  PYTHON: "3.5"
+  GENERATOR: Ninja
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Release"
   APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
   BOOST_ROOT: C:\Libraries\boost_1_64_0
 - JOB: "Build_Debug"
-  GENERATOR: Visual Studio 14 2015 Win64
-  PYTHON: "3.5"
+  GENERATOR: Ninja
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Debug"
 - JOB: "Build"
-  GENERATOR: Visual Studio 14 2015 Win64
-  PYTHON: "3.5"
+  GENERATOR: Ninja
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Release"
 - JOB: "Static_Crt_Build"
-  GENERATOR: Visual Studio 14 2015 Win64
-  PYTHON: "3.5"
+  GENERATOR: Ninja
+  PYTHON: "3.6"
   ARCH: "64"
 - JOB: "Toolchain"
   GENERATOR: Visual Studio 14 2015 Win64
-  PYTHON: "3.5"
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Release"
 - JOB: "Cmake_Script_Tests"
   GENERATOR: NMake Makefiles
-  PYTHON: "3.5"
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Release"
 - JOB: "Build"
   GENERATOR: NMake Makefiles
-  PYTHON: "3.5"
+  PYTHON: "3.6"
   ARCH: "64"
   CONFIGURATION: "Release"
 
   MSVC_DEFAULT_OPTIONS: ON
   BOOST_ROOT: C:\Libraries\boost_1_63_0
   BOOST_LIBRARYDIR: C:\Libraries\boost_1_63_0\lib64-msvc-14.0
+  APPVEYOR_SAVE_CACHE_ON_ERROR: true
+  USE_CLCACHE: true
 
-init:
-  - set MINICONDA=C:\Miniconda35-x64
+install:
+  - set MINICONDA=C:\Miniconda36-x64
   - set PATH=%MINICONDA%;%MINICONDA%/Scripts;%MINICONDA%/Library/bin;%PATH%
-  - if "%GENERATOR%"=="NMake Makefiles" call "C:\Program Files (x86)\Microsoft 
Visual Studio 14.0\VC\vcvarsall.bat" amd64
+  - call ci\appveyor-setup.bat
 
 build_script:
   - git config core.symlinks true
   - git reset --hard
   - if "%JOB%"=="Cmake_Script_Tests" call ci\test-cmake-build-script.bat
   - if NOT "%JOB%"=="Cmake_Script_Tests" call ci\msvc-build.bat
+
+# Disable test discovery
+test: off
+
+after_build:
+  - if "%USE_CLCACHE%" == "true" clcache -s
diff --git a/ci/appveyor-setup.bat b/ci/appveyor-setup.bat
new file mode 100644
index 0..34f8f1d33
--- /dev/null
+++ b/ci/appveyor-setup.bat
@@ -0,0 +1,56 @@
+@rem Licensed to the Apache Software Foundation (ASF) under one
+@rem or more contributor license agreements.  See the NOTICE file
+@rem distributed with this work for additional information
+@rem regarding copyright ownership.  The ASF licenses this file
+@rem to you under the Apache License, Version 2.0 (the
+@rem "License"); you may not use this file except in compliance
+@rem with the License.  You may obtain a copy of the License at
+@rem
+@rem   http://www.apache.org/licenses/LICENSE-2.0
+@rem
+@rem Unless required by applicable law or agreed to in writing,
+@rem software distributed under the License is distributed on an
+@rem "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+@rem KIND, either express or implied.  See the License for the
+@rem specific language governing permissions and limitations
+@rem under the License.
+
+@echo on
+
+conda update -y -q conda
+conda config --set auto_update_conda false
+conda info -a
+
+conda config --set show_channel_urls True
+
+@rem Help with SSL timeouts to S3
+conda config --set remote_connect_timeout_secs 12
+
+conda config --add channels https://repo.continuum.io/pkgs/free
+conda config --add channels conda-forge
+conda info -a
+
+if "%GENERATOR%"=="NMake Makefiles" set need_vcvarsall=1
+if "%GENERATOR%"=="Ninja" set need_vcvarsall=1
+
+if defined need_vcvarsall (
+@rem Select desired compiler version
+if "%APPVEYOR_BUILD_WORKER_IMAGE%" == "Visual Studio 2017" (
+call "C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64
+) else (
+call "C:\Program Files (x86)\Microsoft Visual Studio 
14.0\VC\vcvarsall.bat" amd64
+)
+)
+
+if "%GENERA

[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380985#comment-16380985
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

pitrou commented on issue #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679#issuecomment-369370219
 
 
   No preference from me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
> Environment: Windows
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: CI, pull-request-available, windows
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380982#comment-16380982
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

wesm commented on issue #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679#issuecomment-369369767
 
 
   Let me know if you'd like to do that work here or in a follow up patch, in 
the latter case I can merge this 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
> Environment: Windows
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: CI, pull-request-available, windows
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380755#comment-16380755
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

wesm commented on issue #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679#issuecomment-369325377
 
 
   I think on, but disable silently if clcache is unavailable. We could make 
the behavior identical to ccache, where we use it whenever it's available 
(https://github.com/apache/arrow/blob/master/cpp/CMakeLists.txt#L68)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
> Environment: Windows
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: CI, pull-request-available, windows
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380724#comment-16380724
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

pitrou commented on issue #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679#issuecomment-369320260
 
 
   > Would it be possible to have a clcache-related option to toggle it on/off 
in the cmake setup?
   
   Probably. Should it be on or off by default?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
> Environment: Windows
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: CI, pull-request-available, windows
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380184#comment-16380184
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

pitrou commented on issue #1679: ARROW-2231: [CI] Use clcache on AppVeyor for 
faster builds
URL: https://github.com/apache/arrow/pull/1679#issuecomment-369219386
 
 
   It would also be possible to integrate clcache in the cmake configuration 
(but would make it more difficult to disable). Thoughts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: pull-request-available
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2231) [CI] Use clcache on AppVeyor

2018-02-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380173#comment-16380173
 ] 

ASF GitHub Bot commented on ARROW-2231:
---

pitrou opened a new pull request #1679: ARROW-2231: [CI] Use clcache on 
AppVeyor for faster builds
URL: https://github.com/apache/arrow/pull/1679
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [CI] Use clcache on AppVeyor
> 
>
> Key: ARROW-2231
> URL: https://issues.apache.org/jira/browse/ARROW-2231
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Continuous Integration
>Affects Versions: 0.8.0
>Reporter: Antoine Pitrou
>Assignee: Antoine Pitrou
>Priority: Major
>  Labels: pull-request-available
>
> There's a ccache equivalent for Windows named clcache that could be used to 
> speed up AppVeyor builds: https://github.com/frerich/clcache/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)