[jira] [Commented] (ARROW-2464) [Python] Use a python_version marker instead of a condition
[
https://issues.apache.org/jira/browse/ARROW-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439591#comment-16439591
]
ASF GitHub Bot commented on ARROW-2464:
---
pitrou closed pull request #1879: ARROW-2464: [Python] Use a python_version
marker instead of a condition
URL: https://github.com/apache/arrow/pull/1879
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 20b2416da4..8d26e092bc 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -447,10 +447,11 @@ def has_ext_modules(foo):
return True
-install_requires = ['numpy >= 1.10', 'six >= 1.0.0']
-
-if sys.version_info.major == 2:
-install_requires.append('futures')
+install_requires = (
+'numpy >= 1.10',
+'six >= 1.0.0',
+'futures;python_version<"3.2"'
+)
def parse_version(root):
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Use a python_version marker instead of a condition
> ---
>
> Key: ARROW-2464
> URL: https://issues.apache.org/jira/browse/ARROW-2464
> Project: Apache Arrow
> Issue Type: Task
> Components: Packaging, Python
>Affects Versions: 0.9.0
>Reporter: Omer Katz
>Priority: Minor
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> When installing pyarrow 0.9.0 pipenv complains that futures has no matching
> versions.
> While that may be a bug in pipenv it does not matter. The standard way to
> specify a conditional dependency is using a marker.
> We should use the python_version marker to tell pip if it should install
> futures or not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2464) [Python] Use a python_version marker instead of a condition
[ https://issues.apache.org/jira/browse/ARROW-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439590#comment-16439590 ] ASF GitHub Bot commented on ARROW-2464: --- pitrou commented on issue #1879: ARROW-2464: [Python] Use a python_version marker instead of a condition URL: https://github.com/apache/arrow/pull/1879#issuecomment-381646788 Yes, it should be ok. Also thanks for explaining the bug on the JIRA issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Use a python_version marker instead of a condition > --- > > Key: ARROW-2464 > URL: https://issues.apache.org/jira/browse/ARROW-2464 > Project: Apache Arrow > Issue Type: Task > Components: Packaging, Python >Affects Versions: 0.9.0 >Reporter: Omer Katz >Priority: Minor > Labels: pull-request-available > > When installing pyarrow 0.9.0 pipenv complains that futures has no matching > versions. > While that may be a bug in pipenv it does not matter. The standard way to > specify a conditional dependency is using a marker. > We should use the python_version marker to tell pip if it should install > futures or not. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARROW-2464) [Python] Use a python_version marker instead of a condition
[ https://issues.apache.org/jira/browse/ARROW-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439407#comment-16439407 ] ASF GitHub Bot commented on ARROW-2464: --- thedrow commented on issue #1879: ARROW-2464: [Python] Use a python_version marker instead of a condition URL: https://github.com/apache/arrow/pull/1879#issuecomment-381591253 I opened a ticket. I can't change the branch name without opening a new PR. Is this sufficient? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Use a python_version marker instead of a condition > --- > > Key: ARROW-2464 > URL: https://issues.apache.org/jira/browse/ARROW-2464 > Project: Apache Arrow > Issue Type: Task > Components: Packaging, Python >Affects Versions: 0.9.0 >Reporter: Omer Katz >Priority: Minor > Labels: pull-request-available > > When installing pyarrow 0.9.0 pipenv complains that futures has no matching > versions. > While that may be a bug in pipenv it does not matter. The standard way to > specify a conditional dependency is using a marker. > We should use the python_version marker to tell pip if it should install > futures or not. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
