[jira] [Commented] (ARROW-2487) [C++] Provide a variant of AppendValues that takes bytemaps for the nullability
[
https://issues.apache.org/jira/browse/ARROW-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697788#comment-16697788
]
Kouhei Sutou commented on ARROW-2487:
-
I think that we can close this.
We need {{AppendValues(const value_type* values, int64_t length, const int32_t*
valid_bytes = NULLPTR)}} for my use case. But it's not suitable to handle in
this issue. Because existing {{AppendValues()}} variants already accept
bytemap. They just don't accept 4bytemap.
> [C++] Provide a variant of AppendValues that takes bytemaps for the
> nullability
> ---
>
> Key: ARROW-2487
> URL: https://issues.apache.org/jira/browse/ARROW-2487
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Uwe L. Korn
>Priority: Major
> Labels: beginner
> Fix For: 0.13.0
>
>
> Instead of only accepting bitmaps, we should provide users with a variant of
> {{AppendValues}} that can work on bytemaps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2487) [C++] Provide a variant of AppendValues that takes bytemaps for the nullability
[
https://issues.apache.org/jira/browse/ARROW-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692162#comment-16692162
]
Wes McKinney commented on ARROW-2487:
-
Is this still an issue? We have AppendValues methods that accepts a byte vector
argument for the validity markers
> [C++] Provide a variant of AppendValues that takes bytemaps for the
> nullability
> ---
>
> Key: ARROW-2487
> URL: https://issues.apache.org/jira/browse/ARROW-2487
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Uwe L. Korn
>Priority: Major
> Labels: beginner
> Fix For: 0.13.0
>
>
> Instead of only accepting bitmaps, we should provide users with a variant of
> {{AppendValues}} that can work on bytemaps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-2487) [C++] Provide a variant of AppendValues that takes bytemaps for the nullability
[
https://issues.apache.org/jira/browse/ARROW-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447439#comment-16447439
]
Kouhei Sutou commented on ARROW-2487:
-
There is already one use case.
C GLib bindings use {{gboolean}} for boolean value. {{bool}} in C99 is 1byte.
So we can use {{bool}} value for the current {{valid_bytes}}. But {{gboolean}}
isn't 1byte. It uses {{int}} (*1) as the real type.
(*1) https://developer.gnome.org/glib/stable/glib-Basic-Types.html#gboolean
If {{AppendValues}} accepts {{const int*}} for {{valid_bytes}}, we can remove
type conversion ({{gboolean}} -> {{uint8_t}}) from C GLib bindings.
> [C++] Provide a variant of AppendValues that takes bytemaps for the
> nullability
> ---
>
> Key: ARROW-2487
> URL: https://issues.apache.org/jira/browse/ARROW-2487
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Uwe L. Korn
>Priority: Major
> Labels: beginner
> Fix For: 0.11.0
>
>
> Instead of only accepting bitmaps, we should provide users with a variant of
> {{AppendValues}} that can work on bytemaps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
