[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073925#comment-17073925
]
Wes McKinney commented on ARROW-5473:
-
This has been occurring in the last week, seen in build failures here
https://github.com/apache/arrow/pull/6813
We should try [~rip@gmail.com]'s proposed fix
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.17.0
>
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013937#comment-17013937
]
Renat Valiullin commented on ARROW-5473:
the following change fixes issue for me:
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1412,7 +1412,7 @@ macro(build_gtest)
set(GTEST_CMAKE_CXX_FLAGS "${GTEST_CMAKE_CXX_FLAGS}
-DGTEST_CREATE_SHARED_LIBRARY=1")
endif()
- set(GTEST_PREFIX
"${CMAKE_CURRENT_BINARY_DIR}/googletest_ep-prefix/src/googletest_ep")
+ set(GTEST_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/googletest_ep-prefix")
set(GTEST_INCLUDE_DIR "${GTEST_PREFIX}/include")
set(_GTEST_RUNTIME_DIR ${BUILD_OUTPUT_ROOT_DIRECTORY})
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907536#comment-16907536
]
Wes McKinney commented on ARROW-5473:
-
As Ben said the workaround of doing
{code}
ninja googletest_ep
ninja
{code}
works. It definitely there is something misconfigured in CMake, though
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907533#comment-16907533
]
Wes McKinney commented on ARROW-5473:
-
This is still an issue AFAICT.
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884144#comment-16884144
]
Benjamin Kietzman commented on ARROW-5473:
--
I've seen this too, I can usually work around it by explicitly building just
googletest_ep then building the rest of the project
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854593#comment-16854593
]
Antoine Pitrou commented on ARROW-5473:
---
I think that line is necessary to workaround a CMake bug when non-existent
directories are referenced.
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.14.0
>
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854594#comment-16854594
]
Antoine Pitrou commented on ARROW-5473:
---
See e.g. https://gitlab.kitware.com/cmake/cmake/issues/15052
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.14.0
>
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-5473) [C++] Build failure on googletest_ep on Windows when using Ninja
[
https://issues.apache.org/jira/browse/ARROW-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853341#comment-16853341
]
Wes McKinney commented on ARROW-5473:
-
The suspicious line is
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L1259
> [C++] Build failure on googletest_ep on Windows when using Ninja
>
>
> Key: ARROW-5473
> URL: https://issues.apache.org/jira/browse/ARROW-5473
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Reporter: Wes McKinney
>Priority: Major
> Fix For: 0.14.0
>
>
> I consistently get this error when trying to use Ninja locally:
> {code}
> -- extracting...
>
> src='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/release-1.8.1.tar.gz'
>
> dst='C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep'
> -- extracting... [tar xfz]
> -- extracting... [analysis]
> -- extracting... [rename]
> CMake Error at googletest_ep-stamp/extract-googletest_ep.cmake:51 (file):
> file RENAME failed to rename
>
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/ex-googletest_ep1234/googletest-release-1.8.1
> to
> C:/Users/wesmc/code/arrow/cpp/build/googletest_ep-prefix/src/googletest_ep
> because: Directory not empty
> [179/623] Building CXX object
> src\arrow\CMakeFiles\arrow_static.dir\array\builder_dict.cc.obj
> ninja: build stopped: subcommand failed.
> {code}
> I'm running within cmdr terminal emulator so it's conceivable there's some
> path modifications that are causing issues.
> The CMake invocation is
> {code}
> cmake -G "Ninja" ^ -DCMAKE_BUILD_TYPE=Release ^
> -DARROW_BUILD_TESTS=on ^ -DARROW_CXXFLAGS="/WX /MP" ^
> -DARROW_FLIGHT=off -DARROW_PARQUET=on -DARROW_GANDIVA=ON
> -DARROW_VERBOSE_THIRDPARTY_BUILD=on ..
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
