[jira] [Commented] (ARROW-5500) [R] read_csv_arrow() signature should match readr::read_csv()

2019-06-03 Thread Neal Richardson (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855271#comment-16855271
 ] 

Neal Richardson commented on ARROW-5500:


Perhaps it does. IMO the idea that we would want two R packages–one that just 
wraps the C++ library for developers, and a separate one that provides an 
interface for analysts to work with datasets–is YAGNI. There's no reason we 
can't have the lower-level C++ API wrappers and the analyst-centric interface 
in the same package, and no value at this point to splitting them. 

Currently there already is a lower-level `csv_table_reader`, and all the 
`read_csv_arrow()` function does is invoke it: 
[https://github.com/apache/arrow/blob/master/r/R/csv.R#L179-L181]

I'm proposing adding R-flavored substance to `read_csv_arrow()` (and 
documenting it). I'm not proposing removing or making private the classes and 
methods that invoke the C++ library, so a "developer" could choose to write 
something at that layer if it were useful. 

> [R] read_csv_arrow() signature should match readr::read_csv()
> -
>
> Key: ARROW-5500
> URL: https://issues.apache.org/jira/browse/ARROW-5500
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: R
>Reporter: Neal Richardson
>Priority: Major
> Fix For: 0.14.0
>
>
> So that using it is natural for R users. Internally handle all of the logic 
> needed to map those onto csv_convert_options, csv_read_options, and 
> csv_parse_options. And give a useful error message if a user requests a 
> setting that readr supports but arrow does not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-5500) [R] read_csv_arrow() signature should match readr::read_csv()

2019-06-03 Thread Wes McKinney (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855180#comment-16855180
 ] 

Wes McKinney commented on ARROW-5500:
-

This brings up a bigger question of whether the `arrow` library as it is being 
developed now is the desired "front end" for end-users. 

> [R] read_csv_arrow() signature should match readr::read_csv()
> -
>
> Key: ARROW-5500
> URL: https://issues.apache.org/jira/browse/ARROW-5500
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: R
>Reporter: Neal Richardson
>Priority: Major
> Fix For: 0.14.0
>
>
> So that using it is natural for R users. Internally handle all of the logic 
> needed to map those onto csv_convert_options, csv_read_options, and 
> csv_parse_options. And give a useful error message if a user requests a 
> setting that readr supports but arrow does not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)