[jira] [Commented] (ARROW-5695) [C#][Release] Run sourcelink test in verify-release-candidate.sh

2019-06-26 Thread Yosuke Shiro (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873631#comment-16873631
 ] 

Yosuke Shiro commented on ARROW-5695:
-

Thank you so much for your lucid instructions. I’ll work on it.

> [C#][Release] Run sourcelink test in verify-release-candidate.sh
> 
>
> Key: ARROW-5695
> URL: https://issues.apache.org/jira/browse/ARROW-5695
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C#
>Reporter: Yosuke Shiro
>Assignee: Yosuke Shiro
>Priority: Blocker
> Fix For: 0.14.0
>
>
> Follow up of 
> https://github.com/apache/arrow/pull/4488#pullrequestreview-253110667.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARROW-5695) [C#][Release] Run sourcelink test in verify-release-candidate.sh

2019-06-25 Thread Yosuke Shiro (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872593#comment-16872593
 ] 

Yosuke Shiro commented on ARROW-5695:
-

[~kou]

I'll add `test_package_csharp()` in verify-release-candidate.sh.
Is my understanding correct?

 
{code:java}
test_package_csharp() {
  pushd csharp

  dotnet test
  mv dummy.git ../.git
  dotnet pack -c Release
  mv ../.git dummy.git
  ~/.dotnet/tools/sourcelink test 
artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb
  ~/.dotnet/tools/sourcelink test 
artifacts/Apache.Arrow/Release/netcoreapp2.1/Apache.Arrow.pdb

  popd
}
{code}
 

 

> [C#][Release] Run sourcelink test in verify-release-candidate.sh
> 
>
> Key: ARROW-5695
> URL: https://issues.apache.org/jira/browse/ARROW-5695
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C#
>Reporter: Yosuke Shiro
>Assignee: Yosuke Shiro
>Priority: Blocker
> Fix For: 0.14.0
>
>
> Follow up of 
> https://github.com/apache/arrow/pull/4488#pullrequestreview-253110667.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARROW-5695) [C#][Release] Run sourcelink test in verify-release-candidate.sh

2019-06-24 Thread Sutou Kouhei (JIRA) 


[ 
https://issues.apache.org/jira/browse/ARROW-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871792#comment-16871792
 ] 

Sutou Kouhei commented on ARROW-5695:
-

Please wait until I finish ARROW-5054. This will be conflicted.

> [C#][Release] Run sourcelink test in verify-release-candidate.sh
> 
>
> Key: ARROW-5695
> URL: https://issues.apache.org/jira/browse/ARROW-5695
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C#
>Reporter: Yosuke Shiro
>Assignee: Yosuke Shiro
>Priority: Blocker
> Fix For: 0.14.0
>
>
> Follow up of 
> https://github.com/apache/arrow/pull/4488#pullrequestreview-253110667.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)