[jira] [Commented] (ARROW-6718) [Rust] packed_simd requires nightly

2019-12-24 Thread Paddy Horan (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002842#comment-17002842
 ] 

Paddy Horan commented on ARROW-6718:


I would love to get back on stable.  I added a feature to disable explicit SIMD 
to try and make progress toward this goal.  Although the main thing we need is 
specialization on stable.

 

If we can get the same level of performance then I'm all for removing 
packed_simd.  At the time we adopted it, the author was trying to get it 
adopted into std.  Since then he has stopped driving this forward until other 
features land.

 

I'll take a look in the next few days to compare performance, etc. 

> [Rust] packed_simd requires nightly 
> 
>
> Key: ARROW-6718
> URL: https://issues.apache.org/jira/browse/ARROW-6718
> Project: Apache Arrow
>  Issue Type: Sub-task
>  Components: Rust
>Reporter: Andy Grove
>Priority: Major
>
> See [https://github.com/rust-lang/rfcs/pull/2366] for more info on 
> stabilization of this crate.
>  
> {code:java}
> error[E0554]: `#![feature]` may not be used on the stable release channel
>--> 
> /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/packed_simd-0.3.3/src/lib.rs:202:1
> |
> 202 | / #![feature(
> 203 | | repr_simd,
> 204 | | const_fn,
> 205 | | platform_intrinsics,
> ...   |
> 215 | | custom_inner_attributes
> 216 | | )]
> | |__^
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6718) [Rust] packed_simd requires nightly

2019-12-22 Thread Neville Dipale (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002089#comment-17002089
 ] 

Neville Dipale commented on ARROW-6718:
---

If everyone's happy with the performance of arithmetic and compute kernels 
after the improvements to the non-SIMD functions (ARROW-7460), I'd like to 
propose removing packed_simd [~paddyhoran]

> [Rust] packed_simd requires nightly 
> 
>
> Key: ARROW-6718
> URL: https://issues.apache.org/jira/browse/ARROW-6718
> Project: Apache Arrow
>  Issue Type: Sub-task
>  Components: Rust
>Reporter: Andy Grove
>Priority: Major
>
> See [https://github.com/rust-lang/rfcs/pull/2366] for more info on 
> stabilization of this crate.
>  
> {code:java}
> error[E0554]: `#![feature]` may not be used on the stable release channel
>--> 
> /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/packed_simd-0.3.3/src/lib.rs:202:1
> |
> 202 | / #![feature(
> 203 | | repr_simd,
> 204 | | const_fn,
> 205 | | platform_intrinsics,
> ...   |
> 215 | | custom_inner_attributes
> 216 | | )]
> | |__^
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)