[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-24 Thread Francois Saint-Jacques (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958862#comment-16958862
 ] 

Francois Saint-Jacques commented on ARROW-6925:
---

Noted, I found out how to do it from now on.

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Assignee: John Norris
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-23 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958312#comment-16958312
 ] 

Wes McKinney commented on ARROW-6925:
-

[~fsaintjacques] John needed to be added to the "Contributor" role on JIRA -- 
done now. You are already an admin in JIRA for Apache Arrow so you should get 
familiar with how to do this from the JIRA administration page starting from 
the top right

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Assignee: John Norris
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-21 Thread Francois Saint-Jacques (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956016#comment-16956016
 ] 

Francois Saint-Jacques commented on ARROW-6925:
---

[~wesm] I can't assign John to the ticket, if you can make him contributor and 
assign him.

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
>  Components: C++
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-19 Thread John Norris (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955304#comment-16955304
 ] 

John Norris commented on ARROW-6925:


Done!

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++, pull-request-available
> Fix For: 1.0.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-18 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955032#comment-16955032
 ] 

Wes McKinney commented on ARROW-6925:
-

Alright, if you want to try to submit a patch you can add a check that the 
compiler family is clang when setting that option

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++
> Fix For: 1.0.0
>
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-17 Thread John Norris (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954127#comment-16954127
 ] 

John Norris commented on ARROW-6925:


It appears to be set to gcc.

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-17 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954121#comment-16954121
 ] 

Wes McKinney commented on ARROW-6925:
-

What is {{${COMPILER_FAMILY}}} set to in the gcc case? that's the thing you 
need to check

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-17 Thread John Norris (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954118#comment-16954118
 ] 

John Norris commented on ARROW-6925:


The cmake code only checks if APPLE is true, so there doesn't seem to be a way 
for me to convince it not to add the flag.  From SetupCxxFlags.cmake:

if(APPLE)
    # Depending on the default OSX_DEPLOYMENT_TARGET (< 10.9), libstdc++ may be
    # the default standard library which does not support C++11. libc++ is the
    # default from 10.9 onward.
    set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -stdlib=libc++")
endif()

 

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARROW-6925) [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8

2019-10-17 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/ARROW-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954111#comment-16954111
 ] 

Wes McKinney commented on ARROW-6925:
-

Thanks for the report. Are you able to submit a PR to enable the build system 
to distinguish between Apple Clang and other compiles on macOS?

> [C++] Arrow fails to buld on MacOS 10.13.6 using brew gcc 7 and 8
> -
>
> Key: ARROW-6925
> URL: https://issues.apache.org/jira/browse/ARROW-6925
> Project: Apache Arrow
>  Issue Type: Bug
> Environment: MacOS 10.13.6 using both brew gcc 7 and 8.
>Reporter: John Norris
>Priority: Major
>  Labels: C++
>
> Both SetupCxxFlags.cmake and ThirdpartyToolchain.cmake add -stdlib=libc++ to 
> the compiler flags when APPLE is true, but if you're using GCC from brew (or 
> presumably from anywhere other that Apple), this flag is not recognized and 
> the build fails.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)