RyanSkraba commented on code in PR #2432:
URL: https://github.com/apache/avro/pull/2432#discussion_r1299131431


##########
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##########
@@ -1295,8 +1295,7 @@ private static class FixedSchema extends NamedSchema {
 
     public FixedSchema(Name name, String doc, int size) {
       super(Type.FIXED, name, doc);
-      if (size < 0)
-        throw new IllegalArgumentException("Invalid fixed size: " + size);
+      SystemLimitException.checkMaxBytesLength(size);

Review Comment:
   Oh pardon, I missed this comment between rebasing and cherry-picking!  I 
don't think it's a big deal, but I'll pick this up in the next change to 
Schema.  Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to