[jira] [Commented] (AVRO-3823) Show helpful error messages

2023-08-04 Thread Kousuke Saruta (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751208#comment-17751208
 ] 

Kousuke Saruta commented on AVRO-3823:
--

[~mgrigorov] Oh, I see. I didn't know anyhow works with thiserror well (and I 
noticed both are created by the same author).

> Show helpful error messages
> ---
>
> Key: AVRO-3823
> URL: https://issues.apache.org/jira/browse/AVRO-3823
> Project: Apache Avro
>  Issue Type: Bug
>  Components: rust
>Affects Versions: 1.12.0
>Reporter: Kousuke Saruta
>Assignee: Kousuke Saruta
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0, 1.11.3
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The current Rust binding doesn't show helpful error messages.
> Actually, error types are implemented with helpful error messages.
> This is an example.
> {code:java}
> #[error("No `name` field")] 
> GetNameField,  
> {code}
> But those error messages are not shown.
> Given we try to a invalid schema which contains no name field, we expect to 
> get "No `name` field" but the actual is "GetNameFIeld", which makes it 
> difficult for users to resolve the problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (AVRO-3823) Show helpful error messages

2023-08-03 Thread Martin Tzvetanov Grigorov (Jira)


[ 
https://issues.apache.org/jira/browse/AVRO-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750887#comment-17750887
 ] 

Martin Tzvetanov Grigorov commented on AVRO-3823:
-

You need to use anyhow::Result to see the user-friendly messages.

See TestResult used in the tests.

> Show helpful error messages
> ---
>
> Key: AVRO-3823
> URL: https://issues.apache.org/jira/browse/AVRO-3823
> Project: Apache Avro
>  Issue Type: Bug
>  Components: rust
>Affects Versions: 1.12.0
>Reporter: Kousuke Saruta
>Priority: Major
>
> The current Rust binding doesn't show helpful error messages.
> Actually, error types are implemented with helpful error messages.
> This is an example.
> {code:java}
> #[error("No `name` field")] 
> GetNameField,  
> {code}
> But those error messages are not shown.
> Given we try to a invalid schema which contains no name field, we expect to 
> get "No `name` field" but the actual is "GetNameFIeld", which makes it 
> difficult for users to resolve the problem.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)