[jira] [Commented] (BEAM-5907) Dataflow worker unit test suite has thread-unsafe use of mockito
[ https://issues.apache.org/jira/browse/BEAM-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344713#comment-17344713 ] Benjamin Gonzalez commented on BEAM-5907: - Is this still an issue? Can we close it? > Dataflow worker unit test suite has thread-unsafe use of mockito > > > Key: BEAM-5907 > URL: https://issues.apache.org/jira/browse/BEAM-5907 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Kenneth Knowles >Priority: P3 > Labels: beam-fixit, flake > Time Spent: 1h 10m > Remaining Estimate: 0h > > Some tests of portability bits failed in a test suite for the legacy worker. > Could be a naming problem or a configuration problem. Notably, they failed > due to changes in unshaded test jars, which no one should be using. > https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1778/#showFailuresLink -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-5907) Dataflow worker unit test suite has thread-unsafe use of mockito
[ https://issues.apache.org/jira/browse/BEAM-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668024#comment-16668024 ] Kenneth Knowles commented on BEAM-5907: --- Downgrading to minor as the basic race condition is solved and our current use doesn't seem to actually break Mockito. The tests are pretty laborious and probably test our mocking as much as the code under test, so still worth a look at some point. > Dataflow worker unit test suite has thread-unsafe use of mockito > > > Key: BEAM-5907 > URL: https://issues.apache.org/jira/browse/BEAM-5907 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Kenneth Knowles >Assignee: Kenneth Knowles >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Some tests of portability bits failed in a test suite for the legacy worker. > Could be a naming problem or a configuration problem. Notably, they failed > due to changes in unshaded test jars, which no one should be using. > https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/1778/#showFailuresLink -- This message was sent by Atlassian JIRA (v7.6.3#76005)