[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781846#comment-16781846 ] Michael Luckey commented on BEAM-6726: -- Sure. Will do. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.11.0 >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.12.0 > > Time Spent: 2h > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780756#comment-16780756 ] Ahmet Altay commented on BEAM-6726: --- Thank you [~michel]. This should be manageable. Do you mind adding a note to the release guide so that the next person doing the release would be aware of this. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.11.0 >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.12.0 > > Time Spent: 2h > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780675#comment-16780675 ] Michael Luckey commented on BEAM-6726: -- fwiw, opened [https://github.com/gradle/gradle/issues/8657|issue] against gradle. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.11.0 >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.12.0 > > Time Spent: 2h > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[
https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780440#comment-16780440
]
Michael Luckey commented on BEAM-6726:
--
After digging into that I have to confirm that, although gradle documentation
states [1]
{noformat}
Without any further configuration the gpg2 (on Windows: gpg2.exe) executable
found on the PATH will be used. The password is supplied by the gpg-agent and
the default key is used for signing.
{noformat}
this is not working anymore. I think this is an unintentional regression on
gradle side and qualifies as a bug.
Unfortunately also the provided error message is misleading. To be able to sign
with gradle 5.1+ we need to provide the to be used key. This could be done
either by adding _-Psigning.gnupg.keyName=_ - which probably has to be
done by some environment vars similar to [2] as the call to gradle is wrapped
in corresponding shell script [3] - or by adding the key id to the developers
gradle.properties file.
As I am not using default keys for signing and also always have project
specific gradle home, I have set this as
{noformat}
$ cat beam-gradle-home/gradle.properties
signing.gnupg.keyName=
signing.gnupg.executable=gpg2
{noformat}
Of course for those who sign with default key anyway, it does not make a
difference to add this to global developers gradle properties in
_~/.gradle/gradle.properties_
Do you think this will be too much of a burden?
Note: AFAICT this issue was "introduced" with gradle 5.1, i.e. 5.0 was still
working. Downgrading to 5.0 seems to be no option, though.
[1] https://docs.gradle.org/current/userguide/signing_plugin.html
[2]
https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L48-L55
[3]
https://github.com/apache/beam/blob/master/release/src/main/scripts/build_release_candidate.sh#L92-L94
> Gradle Publish fails with Gradle 5
> --
>
> Key: BEAM-6726
> URL: https://issues.apache.org/jira/browse/BEAM-6726
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Affects Versions: 2.11.0
>Reporter: Ahmet Altay
>Assignee: Michael Luckey
>Priority: Blocker
> Fix For: 2.12.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> cc: [~alanmyrvold] [~kenn]
> :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure
> error:
> (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0):
> Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values
> Signature pom-default.xml.asc:xml.asc:asc:null and Signature
> pom-default.xml.asc:xml.asc:asc:null)
> Downgrading to Gradle 4 by reverting
> https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f
> works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1684#comment-1684 ] Michael Luckey commented on BEAM-6726: -- Oh well... I guess I have to try releasing myself and see, where exactly is the problem. I did not use beams release workflow, but just signed the artifacts. And of course sign plugin needs the key to sign with... dunno how that's specified in beams release process... will have a look. Sorry for the inconvenience... > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Affects Versions: 2.11.0 >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.12.0 > > Time Spent: 2h > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777679#comment-16777679 ] Ahmet Altay commented on BEAM-6726: --- I patched this for RC2 and it is still failing. With the following error: "> Task :beam-runners-apex:buildDependencyTree See the report at: file:///usr/local/google/home/altay/build_release_candidate/beam/runners/apex/build/classes/java/main/org/apache/beam/runners/apex/dependency-tree > Task :beam-sdks-java-bom:signMavenJavaPublication FAILED FAILURE: Build failed with an exception. * What went wrong: A problem was found with the configuration of task ':beam-sdks-java-bom:signMavenJavaPublication'. > No value has been specified for property 'signatory.keyId'. " I will revert the commits back and would not use gradle 5.0 for 2.11 release. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.11.0 > > Time Spent: 2h > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775359#comment-16775359 ] Ahmet Altay commented on BEAM-6726: --- Thank you. After merging please send a cherry pick PR for the release branch. I already cut RC1, if we happen to need an RC2 I will cut it with this change. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775173#comment-16775173 ] Michael Luckey commented on BEAM-6726: -- Opened PR [https://github.com/apache/beam/pull/7925] With this change, I was able to sign projects artifacts. As [~kenn] already stated, this was triggered by improper configuration on our side. (Thx btw for those links, Kenn, as those provided the relevant information to understand this issue) [~altay] this should render it unnecessary to downgrade for the release. Hope, no other issues will show up, as I did not test the full release cycle. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774891#comment-16774891 ] Michael Luckey commented on BEAM-6726: -- I will look into that. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Assignee: Michael Luckey >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774726#comment-16774726 ] Ahmet Altay commented on BEAM-6726: --- Validation was fine, but I did the validation with gradle 5. This issue happens much when signing the artifacts. I also noticed that I can downgrade gradle just before signing the artifacts. Not sure if it is any better. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774721#comment-16774721 ] Kenneth Knowles commented on BEAM-6726: --- I think we can revert on the release branch. Even if the artifacts were different, if they validate is there a problem? > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774714#comment-16774714 ] Ahmet Altay commented on BEAM-6726: --- > https://github.com/gradle/gradle/issues/8213 This one led me to try with Gradle 4, and the first link was duplicated to this one. I could not find any other information anywhere else. I tried the suggestion on the issue (https://github.com/gradle/gradle/issues/8213#issuecomment-453278398) and it did not work weither. Question: Could we revert this change in the release branch? Would use of Gradle 4 result in different beam artifacts? I am guessing not unless our artifacts depends on the build tool we use. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774709#comment-16774709 ] Kenneth Knowles commented on BEAM-6726: --- [~michel] FYI > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (BEAM-6726) Gradle Publish fails with Gradle 5
[ https://issues.apache.org/jira/browse/BEAM-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774712#comment-16774712 ] Kenneth Knowles commented on BEAM-6726: --- Some possibly-related links I've collected: - https://sea-region.github.com/vanniktech/gradle-maven-publish-plugin/issues/38 - https://github.com/gradle/gradle/issues/8213 It may be a bug in our configuration has been triggered. > Gradle Publish fails with Gradle 5 > -- > > Key: BEAM-6726 > URL: https://issues.apache.org/jira/browse/BEAM-6726 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Ahmet Altay >Priority: Blocker > Fix For: 2.11.0 > > > cc: [~alanmyrvold] [~kenn] > :beam-sdks-java-bom:signMavenJavaPublication task fails with an obscure > error: > (https://scans.gradle.com/s/mcbb4axlx6agy/failure?openFailures=WzBd&openStackTraces=WzFd#top=0): > Duplicate key pom-default.xml.asc:xml.asc:asc:null (attempted merging values > Signature pom-default.xml.asc:xml.asc:asc:null and Signature > pom-default.xml.asc:xml.asc:asc:null) > Downgrading to Gradle 4 by reverting > https://github.com/apache/beam/commit/cadb6f7fabc6faedc6037104338306688f17652f > works. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
