[jira] [Commented] (BEAM-9079) release: gradle release task doesn't push commits upstream
[ https://issues.apache.org/jira/browse/BEAM-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012445#comment-17012445 ] Kenneth Knowles commented on BEAM-9079: --- Notably, the release scripts have needed revision almost every release. They aren't at a level of reliability where we should have them modify the repo. And it isn't necessary. But it does seem I did not update the release guide corresponding to the changes to the scripts. Sorry! > release: gradle release task doesn't push commits upstream > -- > > Key: BEAM-9079 > URL: https://issues.apache.org/jira/browse/BEAM-9079 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > The release guide and build_release_candidate.sh both mention running > "gradlew release". It should be committing 2 commits and 1 RC tag. > For example in 2.10.0: > https://github.com/apache/beam/commit/34f9c131b908453a753098e95f2d2fa8e236d188 > https://github.com/apache/beam/commit/b87b09b0339e189a0a1e344dba6abce826a12b03 > https://github.com/apache/beam/commits/v2.10.0-RC3 > This seems to be happening locally for me, but it doesn't get pushed to > github. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-9079) release: gradle release task doesn't push commits upstream
[ https://issues.apache.org/jira/browse/BEAM-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012439#comment-17012439 ] Kenneth Knowles commented on BEAM-9079: --- We should really not bother with the gradle release plugin. It doesn't add anything, and its way of operating is against how git really can work best. https://lists.apache.org/thread.html/205472bdaf3c2c5876533750d417c19b0d1078131a3dc04916082ce8%40%3Cdev.beam.apache.org%3E > release: gradle release task doesn't push commits upstream > -- > > Key: BEAM-9079 > URL: https://issues.apache.org/jira/browse/BEAM-9079 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > The release guide and build_release_candidate.sh both mention running > "gradlew release". It should be committing 2 commits and 1 RC tag. > For example in 2.10.0: > https://github.com/apache/beam/commit/34f9c131b908453a753098e95f2d2fa8e236d188 > https://github.com/apache/beam/commit/b87b09b0339e189a0a1e344dba6abce826a12b03 > https://github.com/apache/beam/commits/v2.10.0-RC3 > This seems to be happening locally for me, but it doesn't get pushed to > github. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-9079) release: gradle release task doesn't push commits upstream
[ https://issues.apache.org/jira/browse/BEAM-9079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012173#comment-17012173 ] Udi Meiri commented on BEAM-9079: - Culprit: https://issues.apache.org/jira/browse/BEAM-6595 > release: gradle release task doesn't push commits upstream > -- > > Key: BEAM-9079 > URL: https://issues.apache.org/jira/browse/BEAM-9079 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > The release guide and build_release_candidate.sh both mention running > "gradlew release". It should be committing 2 commits and 1 RC tag. > For example in 2.10.0: > https://github.com/apache/beam/commit/34f9c131b908453a753098e95f2d2fa8e236d188 > https://github.com/apache/beam/commit/b87b09b0339e189a0a1e344dba6abce826a12b03 > https://github.com/apache/beam/commits/v2.10.0-RC3 > This seems to be happening locally for me, but it doesn't get pushed to > github. -- This message was sent by Atlassian Jira (v8.3.4#803005)
