[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-01-21 Thread Udi Meiri (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020686#comment-17020686
 ] 

Udi Meiri commented on BEAM-9168:
-

Possible options (I'm not that familiar with the semantics):
1. When replacing a ParDo with RunnerAPIPTransformHolder, change the URN as 
well (add a new one?).
2. Make a special-case RunnerAPIPTransformHolder class that also inherits from 
ParDo, or make  ParDo and RunnerAPIPTransformHolder inherit from the same base 
class and assert isinstance on that base.
3. Explicitly handle cases in the code where RunnerAPIPTransformHolder may come 
instead of ParDo.


> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Chamikara Madhusanka Jayalath
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-01-21 Thread Udi Meiri (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020687#comment-17020687
 ] 

Udi Meiri commented on BEAM-9168:
-

Please add appropriate test cases that cover this assert.

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Chamikara Madhusanka Jayalath
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-01-21 Thread Udi Meiri (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020689#comment-17020689
 ] 

Udi Meiri commented on BEAM-9168:
-

Note that the output_tags attribute is required here: 
https://github.com/apache/beam/blob/6a6adc8433deff10a5594bbf77cc9148ce0a951a/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L856

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Chamikara Madhusanka Jayalath
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-06-01 Thread Kenneth Knowles (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121717#comment-17121717
 ] 

Kenneth Knowles commented on BEAM-9168:
---

This issue is assigned but has not received an update in 30 days so it has been 
labeled "stale-assigned". If you are still working on the issue, please give an 
update and remove the label. If you are no longer working on the issue, please 
unassign so someone else may work on it. In 7 days the issue will be 
automatically unassigned.

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Assignee: Chamikara Madhusanka Jayalath
>Priority: P2
>  Labels: stale-assigned
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-08-10 Thread Beam JIRA Bot (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174552#comment-17174552
 ] 

Beam JIRA Bot commented on BEAM-9168:
-

This issue is P2 but has been unassigned without any comment for 60 days so it 
has been labeled "stale-P2". If this issue is still affecting you, we care! 
Please comment and remove the label. Otherwise, in 14 days the issue will be 
moved to P3.

Please see https://beam.apache.org/contribute/jira-priorities/ for a detailed 
explanation of what these priorities mean.


> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Priority: P2
>  Labels: stale-P2
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-08-25 Thread Beam JIRA Bot (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184273#comment-17184273
 ] 

Beam JIRA Bot commented on BEAM-9168:
-

This issue was marked "stale-P2" and has not received a public comment in 14 
days. It is now automatically moved to P3. If you are still affected by it, you 
can comment and move it back to P2.

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Priority: P3
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2020-06-10 Thread Beam JIRA Bot (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17131094#comment-17131094
 ] 

Beam JIRA Bot commented on BEAM-9168:
-

This issue was marked "stale-assigned" and has not received a public comment in 
7 days. It is now automatically unassigned. If you are still working on it, you 
can assign it to yourself again. Please also give an update about the status of 
the work.

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Priority: P2
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BEAM-9168) AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with PAR_DO.urn

2022-06-04 Thread Danny McCormick (Jira)


[ 
https://issues.apache.org/jira/browse/BEAM-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17548457#comment-17548457
 ] 

Danny McCormick commented on BEAM-9168:
---

This issue has been migrated to https://github.com/apache/beam/issues/20089

> AppliedPTransform.from_runner_api fails on unexpected non-ParDo class with 
> PAR_DO.urn
> -
>
> Key: BEAM-9168
> URL: https://issues.apache.org/jira/browse/BEAM-9168
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py-core
>Reporter: Udi Meiri
>Priority: P3
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is failing on a google-internal test.
> Unexpected class is apache_beam.transforms.core.RunnerAPIPTransformHolder.
> Failed assertion: 
> https://github.com/apache/beam/blob/a59f897a64b0006ef3fcbe5a750d5f46499cfe61/sdks/python/apache_beam/pipeline.py#L1052-L1053



--
This message was sent by Atlassian Jira
(v8.20.7#820007)