[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159769
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 21:36
Start Date: 28/Oct/18 21:36
Worklog Time Spent: 10m
Work Description: lgajowy closed pull request #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
b/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
index 77dccc03261..7dd8bcb5785 100644
---
a/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
+++
b/sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
@@ -124,9 +124,13 @@ private long getDistributionMetric(String name,
DistributionType distType, long
private void checkIfMetricResultIsUnique(String name,
Iterable> metricResult)
throws IllegalStateException {
+int resultCount = Iterables.size(metricResult);
Preconditions.checkState(
-Iterables.size(metricResult) == 1,
-String.format("More than one metric matches name: %s in namespace
%s.", name, namespace));
+resultCount <= 1,
+"More than one metric result matches name: %s in namespace %s. Metric
results count: %s",
+name,
+namespace,
+resultCount);
}
/** Return the current value for a time counter, or -1 if can't be
retrieved. */
diff --git
a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
index 521317f2665..d0ad4a74524 100644
---
a/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
+++
b/sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/metrics/MetricsReaderTest.java
@@ -79,14 +79,11 @@ public void testEndTimeIsTheMaximumOfTheDistribution() {
assertEquals(5, reader.getEndTimeMetric(0, "timeDist"));
}
- @Test(expected = IllegalStateException.class)
- public void
throwsIllegalStateExceptionWhenThereAreMultipleCountersOfTheSameNameAndType() {
-Metrics.counter(NAMESPACE, "counter");
-Metrics.counter(NAMESPACE, "counter");
-
+ @Test
+ public void doesntThrowIllegalStateExceptionWhenThereIsNoMetricFound() {
PipelineResult result = testPipeline.run();
MetricsReader reader = new MetricsReader(result, NAMESPACE);
-reader.getCounterMetric("counter", -1);
+reader.getCounterMetric("nonexistent", -1);
}
@Test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159769)
Time Spent: 1h 40m (was: 1.5h)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReade
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159760
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 20:36
Start Date: 28/Oct/18 20:36
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433739176
Yes. I can wait for the results and do this if you want (not to steal your
time anymore :) )
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159760)
Time Spent: 1.5h (was: 1h 20m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159758
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 20:29
Start Date: 28/Oct/18 20:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433738669
When tests pass, looks like this is a squash and merge case, yea?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159758)
Time Spent: 1h 20m (was: 1h 10m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159757
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 20:25
Start Date: 28/Oct/18 20:25
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433738335
Thank you. I applied the suggestion. PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159757)
Time Spent: 1h 10m (was: 1h)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159755
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 20:22
Start Date: 28/Oct/18 20:22
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #6863:
[BEAM-5886] Fix incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#discussion_r228763482
##
File path:
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
##
@@ -124,9 +124,12 @@ private long getDistributionMetric(String name,
DistributionType distType, long
private void checkIfMetricResultIsUnique(String name,
Iterable> metricResult)
throws IllegalStateException {
+int resultCount = Iterables.size(metricResult);
Preconditions.checkState(
-Iterables.size(metricResult) == 1,
-String.format("More than one metric matches name: %s in namespace
%s.", name, namespace));
+resultCount <= 1,
+String.format(
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159755)
Time Spent: 1h (was: 50m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159747
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 19:46
Start Date: 28/Oct/18 19:46
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#6863: [BEAM-5886] Fix incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#discussion_r228762037
##
File path:
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricsReader.java
##
@@ -124,9 +124,12 @@ private long getDistributionMetric(String name,
DistributionType distType, long
private void checkIfMetricResultIsUnique(String name,
Iterable> metricResult)
throws IllegalStateException {
+int resultCount = Iterables.size(metricResult);
Preconditions.checkState(
-Iterables.size(metricResult) == 1,
-String.format("More than one metric matches name: %s in namespace
%s.", name, namespace));
+resultCount <= 1,
+String.format(
Review comment:
Actually this should be just `checkState(resultCount <= 1, "..", name,
namespace, resultCount)` so that it does not execute the String.format when the
check passes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159747)
Time Spent: 50m (was: 40m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159737
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 17:23
Start Date: 28/Oct/18 17:23
Worklog Time Spent: 10m
Work Description: lgajowy edited a comment on issue #6863: [BEAM-5886]
Fix incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433723542
I think that there's also a problem with creating the "fatal" metric
counter. Even though it was created using `Metrics.counter()` method, it was
not found (hence 0 counters with the name "fatal" and the error this PR fixes).
One line from the logs caught my attention (from a successful run):
```
SEVERE: Failed to get metric fatal, from namespace Query9
```
This looks analogously for every query. I can take a closer look at this
later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159737)
Time Spent: 40m (was: 0.5h)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159735
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 17:13
Start Date: 28/Oct/18 17:13
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433723542
I think that there's also a problem with creating the "fatal" metric
counter. Even though it was created using `Metrics.counter()` method, it was
not found (hence 0 counters with the name "fatal" and the error this PR fixes).
One line from the logs caught my attention (from a successful run):
```
SEVERE: Failed to get metric fatal, from namespace Query9
```
This looks analogously for every metrics. I can take a closer look at this
later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159735)
Time Spent: 0.5h (was: 20m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[
https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159733
]
ASF GitHub Bot logged work on BEAM-5886:
Author: ASF GitHub Bot
Created on: 28/Oct/18 17:05
Start Date: 28/Oct/18 17:05
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #6863: [BEAM-5886] Fix
incorrectly formulated condition in checkState method
URL: https://github.com/apache/beam/pull/6863#issuecomment-433722941
@kennknowles could you take a look again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 159733)
Time Spent: 20m (was: 10m)
> Nexmark failing due to IllegalStateException
>
>
> Key: BEAM-5886
> URL: https://issues.apache.org/jira/browse/BEAM-5886
> Project: Beam
> Issue Type: Task
> Components: test-failures, testing
>Reporter: Lukasz Gajowy
>Assignee: Lukasz Gajowy
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Nexmark fails due to the following error:
>
> {code:java}
> java.lang.RuntimeException: java.lang.IllegalStateException: More than one
> metric matches name: fatal in namespace Query0.
> 13:05:49 0012 *** not run ***
> 13:05:49
> ==
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.runAll(Main.java:144)
> 13:05:49
> 13:05:49 at org.apache.beam.sdk.nexmark.Main.main(Main.java:477)
> 13:05:49 Caused by: java.lang.IllegalStateException: More than one metric
> matches name: fatal in namespace Query0.
> 13:05:49 at
> org.apache.beam.repackaged.beam_sdks_java_test_utils.com.google.common.base.Preconditions.checkState(Preconditions.java:444)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.checkIfMetricResultIsUnique(MetricsReader.java:127)
> 13:05:49 at
> org.apache.beam.sdk.testutils.metrics.MetricsReader.getCounterMetric(MetricsReader.java:65)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.monitor(NexmarkLauncher.java:447)
> 13:05:49 at
> org.apache.beam.sdk.nexmark.NexmarkLauncher.run(NexmarkLauncher.java:1156)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:108)
> 13:05:49 at org.apache.beam.sdk.nexmark.Main$Run.call(Main.java:96)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> 13:05:49 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> 13:05:49 at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> 13:05:49 at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-5886) Nexmark failing due to IllegalStateException
[ https://issues.apache.org/jira/browse/BEAM-5886?focusedWorklogId=159732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159732 ] ASF GitHub Bot logged work on BEAM-5886: Author: ASF GitHub Bot Created on: 28/Oct/18 17:00 Start Date: 28/Oct/18 17:00 Worklog Time Spent: 10m Work Description: lgajowy opened a new pull request #6863: [BEAM-5886] Fix incorrectly formulated condition in checkState method URL: https://github.com/apache/beam/pull/6863 The suites failed because 0 counters of the same name were created. I extended the error message to include a more descriptive information about this. Other than that a test for multiple counters with the same name was deleted. The reason it passed was because 0 counters were created (false-positive). As it turned out it is nontrivial to create a test that creates two metrics of the same name and type so I skipped this for now. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitH
