[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=191592=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191592 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 29/Jan/19 10:20 Start Date: 29/Jan/19 10:20 Worklog Time Spent: 10m Work Description: mxm commented on pull request #7654: [BEAM-6439] Add PostCommit variant of PVR to build matrix URL: https://github.com/apache/beam/pull/7654 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191592) Time Spent: 5h 10m (was: 5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 5h 10m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=191196=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191196 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 28/Jan/19 18:48 Start Date: 28/Jan/19 18:48 Worklog Time Spent: 10m Work Description: mxm commented on pull request #7654: [BEAM-6439] Add PostCommit variant of PVR to build matrix URL: https://github.com/apache/beam/pull/7654 We have previously moved Python ValidatesRunner to the Precommit. We have lost the matrix entry for the PostCommit status of this test suite. Contrary to its name we still have a PostCommit variant we can add: https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/ Below for how it looks like (marked with `^^^`): Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) **^^^**| --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191196) Time Spent: 5h (was: 4h 50m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=189222=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189222 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 23/Jan/19 23:17 Start Date: 23/Jan/19 23:17 Worklog Time Spent: 10m Work Description: tweise commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-457004309 @angoenka it does not appear that the job actually runs in pre-commit. https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189222) Time Spent: 4h 50m (was: 4h 40m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4h 50m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=188634=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188634 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 23/Jan/19 03:32 Start Date: 23/Jan/19 03:32 Worklog Time Spent: 10m Work Description: tweise commented on pull request #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188634) Time Spent: 4h 40m (was: 4.5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4h 40m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=188632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188632 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 23/Jan/19 03:29 Start Date: 23/Jan/19 03:29 Worklog Time Spent: 10m Work Description: tweise commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-456656153 Hopefully pre-commit check signal will help prevent some of the build breakages we saw lately. But I don't think running all tests of a runners x SDK matrix is feasible going forward. Even just this combination, once it matches the coverage of the Java SDK, is probably no longer suitable for pre-commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188632) Time Spent: 4.5h (was: 4h 20m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4.5h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=188616=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188616 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 23/Jan/19 02:39 Start Date: 23/Jan/19 02:39 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-456646785 Now I see what you mean. Thanks! Updated the PR comments and readme to remove reference for the old postcommit job. But I would say that having these run available in post commit and visible in PR gave a lot of confidence in the system. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188616) Time Spent: 4h 20m (was: 4h 10m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4h 20m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=188508=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188508 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 22/Jan/19 22:14 Start Date: 22/Jan/19 22:14 Worklog Time Spent: 10m Work Description: tweise commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-456583943 `git grep 'beam_PostCommit_Python_VR_Flink'` - see earlier comment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188508) Time Spent: 4h 10m (was: 4h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4h 10m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=188494=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188494 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 22/Jan/19 21:33 Start Date: 22/Jan/19 21:33 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-456571685 Ping: @tweise @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188494) Time Spent: 4h (was: 3h 50m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 4h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=187296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187296 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 19/Jan/19 02:19 Start Date: 19/Jan/19 02:19 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-455740993 Ping: @tweise @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 187296) Time Spent: 3h 50m (was: 3h 40m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=186513=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186513 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 17/Jan/19 19:42 Start Date: 17/Jan/19 19:42 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-455305501 cc: @tweise @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186513) Time Spent: 3h 40m (was: 3.5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=186011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186011 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:40 Start Date: 16/Jan/19 21:40 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454953263 Need to name job to Python_**PVR**_Flink as beam_PreCommit_Python_VR_Flink_Cron already existed. We can try deleting beam_PreCommit_Python_VR_Flink_Cron and then try to use Python_VR_Flink. Successful run: https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Phrase/1/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186011) Time Spent: 3.5h (was: 3h 20m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=186001=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186001 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:26 Start Date: 16/Jan/19 21:26 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454948234 Run Python_PVR PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186001) Time Spent: 3h 10m (was: 3h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=186002=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186002 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:26 Start Date: 16/Jan/19 21:26 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454948384 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 186002) Time Spent: 3h 20m (was: 3h 10m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185995=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185995 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:15 Start Date: 16/Jan/19 21:15 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454944712 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185995) Time Spent: 3h (was: 2h 50m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 3h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185992 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:10 Start Date: 16/Jan/19 21:10 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454942661 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185992) Time Spent: 2h 50m (was: 2h 40m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185989=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185989 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 21:04 Start Date: 16/Jan/19 21:04 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454940678 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185989) Time Spent: 2h 40m (was: 2.5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185963 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 20:03 Start Date: 16/Jan/19 20:03 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454920089 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185963) Time Spent: 2.5h (was: 2h 20m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2.5h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185961 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:56 Start Date: 16/Jan/19 19:56 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454917912 Run Python_VR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185961) Time Spent: 2h 10m (was: 2h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185962=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185962 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:57 Start Date: 16/Jan/19 19:57 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454918169 Can't test the job as beam1 is down and all runs are scheduled on beam1. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185962) Time Spent: 2h 20m (was: 2h 10m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185960=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185960 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:56 Start Date: 16/Jan/19 19:56 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454917710 Run Python_VR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185960) Time Spent: 2h (was: 1h 50m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 2h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185959 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:55 Start Date: 16/Jan/19 19:55 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454917592 Run Python_VR PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185959) Time Spent: 1h 50m (was: 1h 40m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185946=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185946 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:28 Start Date: 16/Jan/19 19:28 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#discussion_r248419744 ## File path: .test-infra/jenkins/job_PreCommit_Python_ValidatesRunner_Flink.groovy ## @@ -16,25 +17,18 @@ * limitations under the License. */ -import CommonJobProperties as commonJobProperties -import PostcommitJobBuilder +import PrecommitJobBuilder // This job runs the suite of ValidatesRunner tests against the Flink runner. -PostcommitJobBuilder.postCommitJob('beam_PostCommit_Python_VR_Flink', - 'Run Python Flink ValidatesRunner', 'Python Flink ValidatesRunner Tests', this) { - description('Runs the Python ValidatesRunner suite on the Flink runner.') - - previousNames('beam_PostCommit_Python_PVR_Flink_Gradle') - - // Set common parameters. - commonJobProperties.setTopLevelMainJobProperties(delegate) - - // Execute gradle task to test Python Flink Portable Runner. - steps { -gradle { - rootBuildScriptDir(commonJobProperties.checkoutDir) - tasks(':beam-sdks-python:flinkValidatesRunner') - commonJobProperties.setGradleSwitches(delegate) -} - } -} +PrecommitJobBuilder builder = new PrecommitJobBuilder( +scope: this, +nameBase: 'Python_VR_Flink', +gradleTask: ':beam-sdks-python:flinkValidatesRunner', +triggerPathPatterns: [ +'^model/.*$', +'^runners/.*$', +'^sdks/python/.*$', +'^release/.*$', +] +) +builder.build {} Review comment: No new line at end of file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185946) Time Spent: 1h 40m (was: 1.5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185944=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185944 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:21 Start Date: 16/Jan/19 19:21 Worklog Time Spent: 10m Work Description: angoenka commented on pull request #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539 **Please** add a meaningful description for your change here Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185944) Time Spent: 1h 20m (was: 1h 10m) > Move Python Flink VR tests to PreCommit >
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185945=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185945 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 19:21 Start Date: 16/Jan/19 19:21 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7539: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit URL: https://github.com/apache/beam/pull/7539#issuecomment-454905701 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185945) Time Spent: 1.5h (was: 1h 20m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 1.5h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185832=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185832 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 15:32 Start Date: 16/Jan/19 15:32 Worklog Time Spent: 10m Work Description: mxm commented on issue #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514#issuecomment-454821670 I think having this in PreCommit is useful, so we can keep an eye on the status easily without having to run it for every PR. FYI Temporarily reverted: https://github.com/apache/beam/pull/7533 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185832) Time Spent: 1h 10m (was: 1h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185794=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185794 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 14:14 Start Date: 16/Jan/19 14:14 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514#issuecomment-454793770 TBH I didn't look at code at all. If `PreCommitJobBuilder` takes that argument, then I presume yes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185794) Time Spent: 1h (was: 50m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 1h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185650 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 09:14 Start Date: 16/Jan/19 09:14 Worklog Time Spent: 10m Work Description: robertwb commented on issue #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514#issuecomment-454706468 The beam_PreCommit_Portable_Python_Commit job just runs wordcount as a smoke test; this suite has much larger coverage. Ideally, everything would run in PreCommit, but in practice we can only run cheap(ish), non-flaky stuff there, but that shouldn't be a problem for this target anymore. Kenn: Is this as simple as putting `previousNames: ['beam_PostCommit_Python_VR_Flink']` in the arguments of `PrecommitJobBuilder`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185650) Time Spent: 50m (was: 40m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 50m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185558=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185558 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 03:45 Start Date: 16/Jan/19 03:45 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514#issuecomment-454641436 I can clean up old disabled jobs but it would be better to have `previousNames('beam_PostCommit_Python_VR_Flink')`. This only applies to the `PreCommit_Cron` variant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185558) Time Spent: 40m (was: 0.5h) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 40m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185551 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 16/Jan/19 02:40 Start Date: 16/Jan/19 02:40 Worklog Time Spent: 10m Work Description: tweise commented on issue #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514#issuecomment-454630173 The pre-commit coverage was already provided via https://builds.apache.org/job/beam_PreCommit_Portable_Python_Commit/ As we expect to expand test coverage, is it really necessary to jam all of this into pre-commit? Also, this job was part of the post-commit display and now shows as disabled.. https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185551) Time Spent: 0.5h (was: 20m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Robert Bradshaw >Priority: Major > Fix For: Not applicable > > Attachments: png.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6439) Move Python Flink VR tests to PreCommit
[ https://issues.apache.org/jira/browse/BEAM-6439?focusedWorklogId=185485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185485 ] ASF GitHub Bot logged work on BEAM-6439: Author: ASF GitHub Bot Created on: 15/Jan/19 23:06 Start Date: 15/Jan/19 23:06 Worklog Time Spent: 10m Work Description: mxm commented on pull request #7514: [BEAM-6439] Move Python Validates Runner Flink test to PreCommit. URL: https://github.com/apache/beam/pull/7514 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 185485) Time Spent: 20m (was: 10m) > Move Python Flink VR tests to PreCommit > --- > > Key: BEAM-6439 > URL: https://issues.apache.org/jira/browse/BEAM-6439 > Project: Beam > Issue Type: New Feature > Components: runner-flink, testing >Reporter: Robert Bradshaw >Assignee: Jason Kuster >Priority: Major > Attachments: png.png > > Time Spent: 20m > Remaining Estimate: 0h > > Now that they're fast and stable, it would be good to catch changes that > break this earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)