[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=211951=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211951 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 12/Mar/19 18:55 Start Date: 12/Mar/19 18:55 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 211951) Time Spent: 4h 20m (was: 4h 10m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 4h 20m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207646=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207646 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 05/Mar/19 06:27 Start Date: 05/Mar/19 06:27 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469556186 + @robertwb for merging This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207646) Time Spent: 4h 10m (was: 4h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 4h 10m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207542=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207542 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 05/Mar/19 01:02 Start Date: 05/Mar/19 01:02 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469491504 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207542) Time Spent: 4h (was: 3h 50m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 4h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207493=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207493 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 23:04 Start Date: 04/Mar/19 23:04 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469458145 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207493) Time Spent: 3h 50m (was: 3h 40m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 3h 50m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207473=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207473 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 22:27 Start Date: 04/Mar/19 22:27 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469447529 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207473) Time Spent: 3.5h (was: 3h 20m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 3.5h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207474=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207474 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 22:29 Start Date: 04/Mar/19 22:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469448054 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207474) Time Spent: 3h 40m (was: 3.5h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 3h 40m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207426=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207426 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 20:55 Start Date: 04/Mar/19 20:55 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469418073 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207426) Time Spent: 3h 20m (was: 3h 10m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 3h 20m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207419 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 20:39 Start Date: 04/Mar/19 20:39 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469412713 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207419) Time Spent: 3h 10m (was: 3h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 3h 10m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[
https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207417
]
ASF GitHub Bot logged work on BEAM-6504:
Author: ASF GitHub Bot
Created on: 04/Mar/19 20:36
Start Date: 04/Mar/19 20:36
Worklog Time Spent: 10m
Work Description: HuangLED commented on pull request #7926:
[BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2)
URL: https://github.com/apache/beam/pull/7926#discussion_r262231949
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java
##
@@ -89,6 +96,9 @@
*/
public class CreateExecutableStageNodeFunction
implements Function, Node> {
+ private static final Logger LOG =
Review comment:
Thanks for catching this. Removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 207417)
Time Spent: 3h (was: 2h 50m)
> Integration of Portabability sideInput into Dataflow
>
>
> Key: BEAM-6504
> URL: https://issues.apache.org/jira/browse/BEAM-6504
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Major
> Labels: triaged
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Underlying fn api support is done in BEAM-2929, this Jira integrates
> everything into dataflow.
>
> 1) introduce a sideInputHandler for dataflow.
> 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[
https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207330
]
ASF GitHub Bot logged work on BEAM-6504:
Author: ASF GitHub Bot
Created on: 04/Mar/19 18:07
Start Date: 04/Mar/19 18:07
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #7926:
[BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2)
URL: https://github.com/apache/beam/pull/7926#discussion_r262178023
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java
##
@@ -89,6 +96,9 @@
*/
public class CreateExecutableStageNodeFunction
implements Function, Node> {
+ private static final Logger LOG =
Review comment:
is this LOG used somewhere?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 207330)
Time Spent: 2h 50m (was: 2h 40m)
> Integration of Portabability sideInput into Dataflow
>
>
> Key: BEAM-6504
> URL: https://issues.apache.org/jira/browse/BEAM-6504
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Major
> Labels: triaged
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Underlying fn api support is done in BEAM-2929, this Jira integrates
> everything into dataflow.
>
> 1) introduce a sideInputHandler for dataflow.
> 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207321=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207321 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 17:55 Start Date: 04/Mar/19 17:55 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469350572 ping! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207321) Time Spent: 2.5h (was: 2h 20m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 2.5h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=207322=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207322 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 04/Mar/19 17:55 Start Date: 04/Mar/19 17:55 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-469350572 ping... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 207322) Time Spent: 2h 40m (was: 2.5h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 2h 40m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=203966=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203966 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 25/Feb/19 23:31 Start Date: 25/Feb/19 23:31 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-467227280 R: @boyuanzz, @rohdesamuel This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 203966) Time Spent: 2h 20m (was: 2h 10m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 2h 20m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=203965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203965 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 25/Feb/19 23:29 Start Date: 25/Feb/19 23:29 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7926: [BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) URL: https://github.com/apache/beam/pull/7926#issuecomment-467227280 R: @boyuanzz This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 203965) Time Spent: 2h 10m (was: 2h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 2h 10m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=199425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199425 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 15/Feb/19 20:54 Start Date: 15/Feb/19 20:54 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 199425) Time Spent: 2h (was: 1h 50m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 2h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=199352=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199352 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 15/Feb/19 17:43 Start Date: 15/Feb/19 17:43 Worklog Time Spent: 10m Work Description: swegner commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-464136955 Just spotless failing now. I'll submit a formatting fix and merge once the tests are green. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 199352) Time Spent: 1h 50m (was: 1h 40m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Labels: triaged > Time Spent: 1h 50m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[
https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=197166=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197166
]
ASF GitHub Bot logged work on BEAM-6504:
Author: ASF GitHub Bot
Created on: 11/Feb/19 21:16
Start Date: 11/Feb/19 21:16
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #7619: [BEAM-6504]
Create Portable sideInput handler for Dataflow (Part One)
URL: https://github.com/apache/beam/pull/7619#discussion_r255695576
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/DataflowSideInputHandlerFactory.java
##
@@ -65,7 +66,9 @@ private DataflowSideInputHandlerFactory(
RunnerApi.FunctionSpec accessPattern,
Coder elementCoder,
Coder windowCoder) {
-checkArgument(pTransformId != null, String.format("Expect a valid
PTransform ID."));
+checkArgument(
+pTransformId != null && pTransformId.length() > 0,
+String.format("Expect a valid PTransform ID."));
Review comment:
We don't need `String.format` as we are not substituting any parameters.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 197166)
Time Spent: 1h 40m (was: 1.5h)
> Integration of Portabability sideInput into Dataflow
>
>
> Key: BEAM-6504
> URL: https://issues.apache.org/jira/browse/BEAM-6504
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Major
> Labels: triaged
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Underlying fn api support is done in BEAM-2929, this Jira integrates
> everything into dataflow.
>
> 1) introduce a sideInputHandler for dataflow.
> 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=194485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194485 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 05/Feb/19 12:08 Start Date: 05/Feb/19 12:08 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-460614865 Comments addressed. PTAL. Thanks for reviewing! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 194485) Time Spent: 1.5h (was: 1h 20m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=192303=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192303 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 30/Jan/19 14:22 Start Date: 30/Jan/19 14:22 Worklog Time Spent: 10m Work Description: angoenka commented on pull request #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#discussion_r252274046 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/DataflowSideInputHandlerFactory.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.dataflow.worker.fn.control; + +import static com.google.common.base.Preconditions.checkState; Review comment: Import fix to org.apache.beam.vendor.guava.v20_0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 192303) Time Spent: 1h 10m (was: 1h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[
https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=192304=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192304
]
ASF GitHub Bot logged work on BEAM-6504:
Author: ASF GitHub Bot
Created on: 30/Jan/19 14:22
Start Date: 30/Jan/19 14:22
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #7619: [BEAM-6504]
Create Portable sideInput handler for Dataflow (Part One)
URL: https://github.com/apache/beam/pull/7619#discussion_r252269250
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/DataflowSideInputHandlerFactory.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow.worker.fn.control;
+
+import static com.google.common.base.Preconditions.checkState;
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.util.Map;
+import org.apache.beam.model.pipeline.v1.RunnerApi;
+import org.apache.beam.runners.core.SideInputReader;
+import org.apache.beam.runners.fnexecution.state.StateRequestHandlers;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.KvCoder;
+import org.apache.beam.sdk.transforms.Materializations;
+import org.apache.beam.sdk.transforms.windowing.BoundedWindow;
+import org.apache.beam.sdk.values.PCollectionView;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DataflowSideInputHandlerFactory
+implements StateRequestHandlers.SideInputHandlerFactory {
+ private static final Logger LOG =
LoggerFactory.getLogger(DataflowSideInputHandlerFactory.class);
+
+ private final Map ptransformIdToSideInputReader;
+ private final Map>
+ sideInputIdToPCollectionViewMap;
+
+ static DataflowSideInputHandlerFactory of(
+ Map ptransformIdToSideInputReader,
+ Map>
+ sideInputIdToPCollectionViewMap) {
+return new DataflowSideInputHandlerFactory(
+ptransformIdToSideInputReader, sideInputIdToPCollectionViewMap);
+ }
+
+ private DataflowSideInputHandlerFactory(
+ Map ptransformIdToSideInputReader,
+ Map>
+ sideInputIdToPCollectionViewMap) {
+this.ptransformIdToSideInputReader = ptransformIdToSideInputReader;
+this.sideInputIdToPCollectionViewMap = sideInputIdToPCollectionViewMap;
+ }
+
+ @Override
+ public
StateRequestHandlers.SideInputHandler forSideInput(
+ String pTransformId,
+ String sideInputId,
+ RunnerApi.FunctionSpec accessPattern,
+ Coder elementCoder,
+ Coder windowCoder) {
+checkArgument(pTransformId != null, String.format("Expect a valid
PTransform ID."));
Review comment:
Lets check for both null and empty string
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 192304)
> Integration of Portabability sideInput into Dataflow
>
>
> Key: BEAM-6504
> URL: https://issues.apache.org/jira/browse/BEAM-6504
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
>Reporter: Ruoyun Huang
>Assignee: Ruoyun Huang
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Underlying fn api support is done in BEAM-2929, this Jira integrates
> everything into dataflow.
>
> 1) introduce a sideInputHandler for dataflow.
> 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=192302=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192302 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 30/Jan/19 14:22 Start Date: 30/Jan/19 14:22 Worklog Time Spent: 10m Work Description: angoenka commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-458961296 Thanks @HuangLED Few minor comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 192302) Time Spent: 1h (was: 50m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=192305=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192305 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 30/Jan/19 14:22 Start Date: 30/Jan/19 14:22 Worklog Time Spent: 10m Work Description: angoenka commented on pull request #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#discussion_r252268405 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/DataflowSideInputHandlerFactory.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.dataflow.worker.fn.control; + +import static com.google.common.base.Preconditions.checkState; +import static org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkArgument; + +import java.io.ByteArrayInputStream; +import java.io.IOException; +import java.util.Map; +import org.apache.beam.model.pipeline.v1.RunnerApi; +import org.apache.beam.runners.core.SideInputReader; +import org.apache.beam.runners.fnexecution.state.StateRequestHandlers; +import org.apache.beam.sdk.coders.Coder; +import org.apache.beam.sdk.coders.KvCoder; +import org.apache.beam.sdk.transforms.Materializations; +import org.apache.beam.sdk.transforms.windowing.BoundedWindow; +import org.apache.beam.sdk.values.PCollectionView; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class DataflowSideInputHandlerFactory Review comment: Java doc for what we are doing in this file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 192305) Time Spent: 1h 20m (was: 1h 10m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=191236=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191236 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 28/Jan/19 19:53 Start Date: 28/Jan/19 19:53 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-458276702 + R: @rohdesamuel This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191236) Time Spent: 50m (was: 40m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=191168=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191168 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 28/Jan/19 18:09 Start Date: 28/Jan/19 18:09 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-457380947 R: @angoenka @boyuanzz @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191168) Time Spent: 40m (was: 0.5h) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=191167=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191167 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 28/Jan/19 18:09 Start Date: 28/Jan/19 18:09 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-457380947 R: @boyuanzz @swegner @angoenka This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 191167) Time Spent: 0.5h (was: 20m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=189717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189717 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 24/Jan/19 22:23 Start Date: 24/Jan/19 22:23 Worklog Time Spent: 10m Work Description: HuangLED commented on issue #7619: [BEAM-6504] Create Portable sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619#issuecomment-457380947 R: @boyuanzz @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189717) Time Spent: 20m (was: 10m) > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 > URL: https://issues.apache.org/jira/browse/BEAM-6504 > Project: Beam > Issue Type: New Feature > Components: runner-dataflow >Reporter: Ruoyun Huang >Assignee: Ruoyun Huang >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Underlying fn api support is done in BEAM-2929, this Jira integrates > everything into dataflow. > > 1) introduce a sideInputHandler for dataflow. > 2) wire the handler to dataflow runner (i.e. ProcessRemoteBundleOperation) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-6504) Integration of Portabability sideInput into Dataflow
[ https://issues.apache.org/jira/browse/BEAM-6504?focusedWorklogId=189666=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189666 ] ASF GitHub Bot logged work on BEAM-6504: Author: ASF GitHub Bot Created on: 24/Jan/19 20:14 Start Date: 24/Jan/19 20:14 Worklog Time Spent: 10m Work Description: HuangLED commented on pull request #7619: [BEAM-6504] Create sideInput handler for Dataflow (Part One) URL: https://github.com/apache/beam/pull/7619 Create a SideInput handler inside dataflow fnApi runner. There will be another PR to actually wire this independent module. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189666) Time Spent: 10m Remaining Estimate: 0h > Integration of Portabability sideInput into Dataflow > > > Key: BEAM-6504 >
