[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=413506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413506 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Mar/20 20:44 Start Date: 31/Mar/20 20:44 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413506) Time Spent: 24h 40m (was: 24.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 24h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=413505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413505 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Mar/20 20:43 Start Date: 31/Mar/20 20:43 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-606864502 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 413505) Time Spent: 24.5h (was: 24h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 24.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=412812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412812 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Mar/20 03:34 Start Date: 31/Mar/20 03:34 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-606378924 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 412812) Time Spent: 24h 20m (was: 24h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 24h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=412394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412394 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Mar/20 15:44 Start Date: 30/Mar/20 15:44 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-606079063 Failure is unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 412394) Time Spent: 24h 10m (was: 24h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 24h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=412348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412348 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Mar/20 14:01 Start Date: 30/Mar/20 14:01 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-606017562 Run XVR_Spark PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 412348) Time Spent: 23h 50m (was: 23h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 23h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=412349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412349 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Mar/20 14:01 Start Date: 30/Mar/20 14:01 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-606017695 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 412349) Time Spent: 24h (was: 23h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 24h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=411369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411369 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Mar/20 20:52 Start Date: 27/Mar/20 20:52 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-605309808 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 411369) Time Spent: 23.5h (was: 23h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 23.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=411370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411370 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Mar/20 20:52 Start Date: 27/Mar/20 20:52 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #11254: [BEAM-7961] Refactors X-Lang test pipelines. URL: https://github.com/apache/beam/pull/11254#issuecomment-605310044 R: @ihji This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 411370) Time Spent: 23h 40m (was: 23.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Fix For: 2.19.0 > > Time Spent: 23h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=381229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381229 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 03/Feb/20 22:55 Start Date: 03/Feb/20 22:55 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381229) Time Spent: 23h 20m (was: 23h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 23h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=381192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381192 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 03/Feb/20 21:45 Start Date: 03/Feb/20 21:45 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-581633831 @chamikaramj ready to go :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381192) Time Spent: 23h 10m (was: 23h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 23h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=380284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380284 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 01/Feb/20 01:06 Start Date: 01/Feb/20 01:06 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580972689 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380284) Time Spent: 23h (was: 22h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 23h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=380177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380177 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Jan/20 19:22 Start Date: 31/Jan/20 19:22 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580873951 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380177) Time Spent: 22h 50m (was: 22h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=380176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380176 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Jan/20 19:19 Start Date: 31/Jan/20 19:19 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580873075 @chamikaramj Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 380176) Time Spent: 22h 40m (was: 22.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379691 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 31/Jan/20 00:48 Start Date: 31/Jan/20 00:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580530365 Failures seems to be related. https://builds.apache.org/job/beam_PreCommit_Python_Phrase/1427/testReport/junit/apache_beam.transforms.external_test/ExternalTransformTest/test_pipeline_generation/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379691) Time Spent: 22.5h (was: 22h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379602 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Jan/20 21:27 Start Date: 30/Jan/20 21:27 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580467756 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379602) Time Spent: 22h 20m (was: 22h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379601 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Jan/20 21:26 Start Date: 30/Jan/20 21:26 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580467522 LGTM. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379601) Time Spent: 22h 10m (was: 22h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379122 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Jan/20 02:02 Start Date: 30/Jan/20 02:02 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580049923 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379122) Time Spent: 21h 40m (was: 21.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379124 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Jan/20 02:02 Start Date: 30/Jan/20 02:02 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580050005 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379124) Time Spent: 22h (was: 21h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 22h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=379123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379123 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Jan/20 02:02 Start Date: 30/Jan/20 02:02 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-580049972 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379123) Time Spent: 21h 50m (was: 21h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378618 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 01:44 Start Date: 29/Jan/20 01:44 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579555090 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378618) Time Spent: 21.5h (was: 21h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378595&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378595 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:35 Start Date: 29/Jan/20 00:35 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579539686 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378595) Time Spent: 21h 20m (was: 21h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378594 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:33 Start Date: 29/Jan/20 00:33 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579539395 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378594) Time Spent: 21h 10m (was: 21h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378591 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:32 Start Date: 29/Jan/20 00:32 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579539168 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378591) Time Spent: 21h (was: 20h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 21h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378590 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:32 Start Date: 29/Jan/20 00:32 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579539111 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378590) Time Spent: 20h 50m (was: 20h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378579 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:04 Start Date: 29/Jan/20 00:04 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579531901 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378579) Time Spent: 20h 40m (was: 20.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=378578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378578 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 29/Jan/20 00:03 Start Date: 29/Jan/20 00:03 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579531756 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378578) Time Spent: 20.5h (was: 20h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377957 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 01:08 Start Date: 28/Jan/20 01:08 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579032166 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377957) Time Spent: 20h 20m (was: 20h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377956 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 01:07 Start Date: 28/Jan/20 01:07 Worklog Time Spent: 10m Work Description: udim commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579031862 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377956) Time Spent: 20h 10m (was: 20h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377931 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:25 Start Date: 28/Jan/20 00:25 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579021351 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377931) Time Spent: 20h (was: 19h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 20h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377928 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:16 Start Date: 28/Jan/20 00:16 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579018961 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377928) Time Spent: 19h 50m (was: 19h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 19h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377927 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:12 Start Date: 28/Jan/20 00:12 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579018096 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377927) Time Spent: 19h 40m (was: 19.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 19h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377926 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:12 Start Date: 28/Jan/20 00:12 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579018032 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377926) Time Spent: 19.5h (was: 19h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 19.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377925 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:10 Start Date: 28/Jan/20 00:10 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579017490 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377925) Time Spent: 19h 20m (was: 19h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 19h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377924 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:10 Start Date: 28/Jan/20 00:10 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579017397 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377924) Time Spent: 19h 10m (was: 19h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 19h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377921 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 28/Jan/20 00:01 Start Date: 28/Jan/20 00:01 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371549724 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityState st
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377913 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 23:28 Start Date: 27/Jan/20 23:28 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371540025 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityState st
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377906 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 23:22 Start Date: 27/Jan/20 23:22 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579003483 @chamikaramj You can start the xlang test with `Run XVR_Flink PostCommit` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377906) Time Spent: 18h 40m (was: 18.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 18h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377905 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 23:21 Start Date: 27/Jan/20 23:21 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-579003483 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377905) Time Spent: 18.5h (was: 18h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 18.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377892 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:54 Start Date: 27/Jan/20 22:54 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371527681 ## File path: sdks/python/apache_beam/runners/portability/expansion_service_test.py ## @@ -75,39 +88,139 @@ def from_runner_api_parameter(payload, unused_context): return FilterLessThanTransform(payload.decode('utf8')) -@ptransform.PTransform.register_urn('simple', None) -class SimpleTransform(ptransform.PTransform): +@ptransform.PTransform.register_urn(TEST_PREFIX_URN, None) +@beam.typehints.with_output_types(unicode) +class PrefixTransform(ptransform.PTransform): + def __init__(self, payload): +self._payload = payload + def expand(self, pcoll): -return pcoll | 'TestLabel' >> beam.Map(lambda x: 'Simple(%s)' % x) +return pcoll | 'TestLabel' >> beam.Map( +lambda x: '{}{}'.format(self._payload, x)) def to_runner_api_parameter(self, unused_context): -return 'simple', None +return TEST_PREFIX_URN, None @staticmethod - def from_runner_api_parameter(unused_parameter, unused_context): -return SimpleTransform() + def from_runner_api_parameter(payload, unused_context): +return PrefixTransform(parse_string_payload(payload)['data']) -@ptransform.PTransform.register_urn('multi', None) +@ptransform.PTransform.register_urn(TEST_MULTI_URN, None) class MutltiTransform(ptransform.PTransform): def expand(self, pcolls): return { 'main': (pcolls['main1'], pcolls['main2']) | beam.Flatten() | beam.Map(lambda x, s: x + s, - beam.pvalue.AsSingleton(pcolls['side'])), -'side': pcolls['side'] | beam.Map(lambda x: x + x), + beam.pvalue.AsSingleton(pcolls['side']) + ).with_output_types(unicode), +'side': pcolls['side'] | beam.Map( +lambda x: x + x).with_output_types(unicode), } def to_runner_api_parameter(self, unused_context): -return 'multi', None +return TEST_MULTI_URN, None @staticmethod def from_runner_api_parameter(unused_parameter, unused_context): return MutltiTransform() +@ptransform.PTransform.register_urn(TEST_GBK_URN, None) +class GBKTransform(ptransform.PTransform): + def expand(self, pcoll): +return pcoll | 'TestLabel' >> beam.GroupByKey() + + def to_runner_api_parameter(self, unused_context): +return TEST_GBK_URN, None + + @staticmethod + def from_runner_api_parameter(unused_parameter, unused_context): +return GBKTransform() + + +@ptransform.PTransform.register_urn(TEST_CGBK_URN, None) +class CoGBKTransform(ptransform.PTransform): + class ConcatFn(beam.DoFn): +def process(self, element): + (k, v) = element + return [(k, v['col1'] + v['col2'])] + + def expand(self, pcoll): +return pcoll \ + | beam.CoGroupByKey() \ + | beam.ParDo(self.ConcatFn()).with_output_types( + typing.Tuple[int, typing.Iterable[unicode]]) + + def to_runner_api_parameter(self, unused_context): +return TEST_CGBK_URN, None + + @staticmethod + def from_runner_api_parameter(unused_parameter, unused_context): +return CoGBKTransform() + + +@ptransform.PTransform.register_urn(TEST_COMGL_URN, None) +class CombineGloballyTransform(ptransform.PTransform): + def expand(self, pcoll): +return pcoll \ Review comment: Nit: use parenthesis instead of \ for line wrap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377892) Time Spent: 18h (was: 17h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 18h > Remaining Estimate: 0h > > Add
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377890 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:54 Start Date: 27/Jan/20 22:54 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371523701 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377891 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:54 Start Date: 27/Jan/20 22:54 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371523896 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377893 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:54 Start Date: 27/Jan/20 22:54 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-578994684 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377893) Time Spent: 18h 10m (was: 18h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 18h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377894 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:54 Start Date: 27/Jan/20 22:54 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-578994771 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377894) Time Spent: 18h 20m (was: 18h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 18h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377884 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 27/Jan/20 22:33 Start Date: 27/Jan/20 22:33 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r371520636 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -261,10 +262,12 @@ class BeamModulePlugin implements Plugin { class CrossLanguageValidatesRunnerConfiguration { // Task name for cross-language validate runner case. String name = 'validatesCrossLanguageRunner' -// Fully qualified JobServerClass name to use. -String jobServerDriver -// A string representing the jobServer Configuration. -String jobServerConfig +// Job endpoint to use. +String jobEndpoint = 'localhost:8099' Review comment: Do we have to hardcode this port ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377884) Time Spent: 17.5h (was: 17h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 17.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377142 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 25/Jan/20 02:31 Start Date: 25/Jan/20 02:31 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-578368472 @chamikaramj PTAL. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 377142) Time Spent: 17h 20m (was: 17h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 17h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=377123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377123 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 25/Jan/20 01:14 Start Date: 25/Jan/20 01:14 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r370902160 ## File path: sdks/java/testing/expansion-service/src/test/java/org/apache/beam/sdk/expansion/TestExpansionService.java ## @@ -55,39 +88,154 @@ @Override public Map knownTransforms() { Schema schema = new Schema.Parser().parse(rawSchema); - return ImmutableMap.of( - TEST_COUNT_URN, spec -> Count.perElement(), + ImmutableMap.Builder builder = + ImmutableMap.builder(); + builder.put( + TEST_PREFIX_URN, + spec -> + MapElements.into(TypeDescriptors.strings()) + .via((String x) -> spec.getPayload().toStringUtf8() + x)); + builder.put(TEST_MULTI_URN, spec -> new TestMultiPTransform()); + builder.put(TEST_GBK_URN, spec -> GroupByKey.create()); + builder.put(TEST_CGBK_URN, new TestCoGroupByKeyTransformProvider()); + builder.put(TEST_COMGL_URN, spec -> Sum.longsGlobally()); + builder.put(TEST_COMPK_URN, spec -> Sum.longsPerKey()); + builder.put(TEST_FLATTEN_URN, new TestFlattenTransformProvider()); + builder.put( + TEST_PARTITION_URN, + spec -> Partition.of(2, (Long elem, int numP) -> elem % 2 == 0 ? 0 : 1)); + builder.put( + TEST_PARQUET_WRITE_URN, + spec -> + new PTransform, PCollection>() { +@Override +public PCollection expand(PCollection input) { + return input + .apply( + FileIO.write() + .via(ParquetIO.sink(schema)) + .to(spec.getPayload().toStringUtf8())) + .getPerDestinationOutputFilenames() + .apply(Values.create()); +} + }); + + builder.put(TEST_COUNT_URN, spec -> Count.perElement()); + builder.put( TEST_FILTER_URN, - spec -> - Filter.lessThanEq( - // TODO(BEAM-6587): Use strings directly rather than longs. - (long) spec.getPayload().toStringUtf8().charAt(0)), + spec -> + Filter.lessThanEq( + // TODO(BEAM-6587): Use strings directly rather than longs. + (long) spec.getPayload().toStringUtf8().charAt(0))); + builder.put( TEST_PARQUET_READ_URN, - spec -> - new PTransform>() { -@Override -public PCollection expand(PBegin input) { - return input - .apply(FileIO.match().filepattern(spec.getPayload().toStringUtf8())) - .apply(FileIO.readMatches()) - .apply(ParquetIO.readFiles(schema)) - .setCoder(AvroCoder.of(schema)); -} - }, - TEST_PARQUET_WRITE_URN, - spec -> - new PTransform, PCollection>() { -@Override -public PCollection expand(PCollection input) { - return input - .apply( - FileIO.write() - .via(ParquetIO.sink(schema)) - .to(spec.getPayload().toStringUtf8())) - .getPerDestinationOutputFilenames() - .apply(Values.create()); -} - }); + spec -> + new PTransform>() { +@Override +public PCollection expand(PBegin input) { + return input + .apply(FileIO.match().filepattern(spec.getPayload().toStringUtf8())) + .apply(FileIO.readMatches()) + .apply(ParquetIO.readFiles(schema)) + .setCoder(AvroCoder.of(schema)); +} + }); + return builder.build(); +} + +public static class TestFlattenTransformProvider +implements ExpansionService.TransformProvider, PCollection> { Review comment: Update to use `ExternalTransformRegistrar` whenever possible. This is an automated message from the Apache Git Service. To respond to the message, pleas
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=376403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376403 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 23/Jan/20 18:14 Start Date: 23/Jan/20 18:14 Worklog Time Spent: 10m Work Description: chamikaramj commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-577803289 Please let me know if this is ready for another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 376403) Time Spent: 17h (was: 16h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 17h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375958 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 22:43 Start Date: 22/Jan/20 22:43 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369846295 ## File path: sdks/python/apache_beam/transforms/external.py ## @@ -416,7 +416,8 @@ def _normalize(coder_proto): unique_name=full_label, spec=self._expanded_transform.spec, subtransforms=self._expanded_transform.subtransforms, -inputs=self._expanded_transform.inputs, +inputs={tag: pcoll_renames.get(pcoll, pcoll) Review comment: 'inputs' should be also renamed when there are two or more pcollections. It just worked because the current implementation assumes that original and expanded pcollections are the same if there's only one pcollection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375958) Time Spent: 16h 50m (was: 16h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 16h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375953 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 22:37 Start Date: 22/Jan/20 22:37 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369843663 ## File path: sdks/python/apache_beam/runners/portability/expansion_service_test.py ## @@ -73,39 +84,139 @@ def from_runner_api_parameter(payload, unused_context): return FilterLessThanTransform(payload.decode('utf8')) -@ptransform.PTransform.register_urn('simple', None) -class SimpleTransform(ptransform.PTransform): +@ptransform.PTransform.register_urn(TEST_PREFIX_URN, None) +@beam.typehints.with_output_types(unicode) +class PrefixTransform(ptransform.PTransform): + def __init__(self, payload): +self._payload = payload + def expand(self, pcoll): -return pcoll | 'TestLabel' >> beam.Map(lambda x: 'Simple(%s)' % x) +return pcoll | 'TestLabel' >> beam.Map( +lambda x: '{}{}'.format(self._payload, x)) def to_runner_api_parameter(self, unused_context): -return 'simple', None +return TEST_PREFIX_URN, None @staticmethod - def from_runner_api_parameter(unused_parameter, unused_context): -return SimpleTransform() + def from_runner_api_parameter(payload, unused_context): +return PrefixTransform(payload.decode('utf8')) -@ptransform.PTransform.register_urn('multi', None) +@ptransform.PTransform.register_urn(TEST_MULTI_URN, None) class MutltiTransform(ptransform.PTransform): def expand(self, pcolls): return { 'main': (pcolls['main1'], pcolls['main2']) | beam.Flatten() | beam.Map(lambda x, s: x + s, - beam.pvalue.AsSingleton(pcolls['side'])), -'side': pcolls['side'] | beam.Map(lambda x: x + x), + beam.pvalue.AsSingleton(pcolls['side']) + ).with_output_types(unicode), +'side': pcolls['side'] | beam.Map( +lambda x: x + x).with_output_types(unicode), } def to_runner_api_parameter(self, unused_context): -return 'multi', None +return TEST_MULTI_URN, None @staticmethod def from_runner_api_parameter(unused_parameter, unused_context): return MutltiTransform() +@ptransform.PTransform.register_urn(TEST_GBK_URN, None) +class GBKTransform(ptransform.PTransform): + def expand(self, pcoll): +return pcoll | 'TestLabel' >> beam.GroupByKey() + + def to_runner_api_parameter(self, unused_context): +return TEST_GBK_URN, None + + @staticmethod + def from_runner_api_parameter(unused_parameter, unused_context): Review comment: Default implementation won't work in most cases. It's more like a placeholder not supposed to handle any generic uses. https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/ptransform.py#L704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375953) Time Spent: 16h 40m (was: 16.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 16h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375364 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 02:06 Start Date: 22/Jan/20 02:06 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369338933 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityState st
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375363 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 02:05 Start Date: 22/Jan/20 02:05 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369338651 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; Review comment: I put the link to the design doc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375363) Time Spent: 16h 20m (was: 16h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 16h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375362 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 02:04 Start Date: 22/Jan/20 02:04 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369338544 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ExternalTest.java ## @@ -56,19 +57,18 @@ @RunWith(JUnit4.class) public class ExternalTest implements Serializable { @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; private static final String TEST_URN_SIMPLE = "simple"; private static final String TEST_URN_LE = "le"; private static final String TEST_URN_MULTI = "multi"; - private static Integer expansionPort; private static String localExpansionAddr; private static Server localExpansionServer; @BeforeClass - public static void setUp() throws IOException { -expansionPort = Integer.valueOf(System.getProperty("expansionPort")); -int localExpansionPort = expansionPort + 100; + public static void setUpClass() throws IOException { +int localExpansionPort = Integer.parseInt(System.getProperty("expansionPort")) + 100; Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375362) Time Spent: 16h 10m (was: 16h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 16h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=375354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375354 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 22/Jan/20 01:22 Start Date: 22/Jan/20 01:22 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r369329159 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -1684,22 +1688,21 @@ class BeamModulePlugin implements Plugin { args '-c', "$pythonDir/scripts/run_expansion_services.sh stop --group_id ${project.name}" } setupTask.finalizedBy cleanupTask + config.startJobServer.finalizedBy config.cleanupJobServer // Task for running testcases in Java SDK def beamJavaTestPipelineOptions = [ - "--runner=org.apache.beam.runners.portability.testing.TestPortableRunner", -"--jobServerDriver=${config.jobServerDriver}", +"--runner=PortableRunner", Review comment: The change enabled remote execution of portable pipelines. `TestPortableRunner` provides `--jobServerDriver` just for easier testing (otherwise there needs to be a separate jobserver process to run integration tests). Validate xlang test suite already implemented the setup/shutdown script managing external processes so I modified the code to adopt the original `PortableRunner`. I didn't check but OOM shouldn't happen with the new tests here even with in-process job server drivers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 375354) Time Spent: 16h (was: 15h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 16h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=373939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373939 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 17/Jan/20 23:21 Start Date: 17/Jan/20 23:21 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r368175531 ## File path: .test-infra/jenkins/job_PostCommit_CrossLanguageValidatesRunner_Flink.groovy ## @@ -34,10 +34,19 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_XVR_Flink', // Gradle goals for this job. steps { +shell('echo *** RUN CROSS-LANGUAGE FLINK USING PYTHON 2.7 ***') Review comment: Followed the same convention in https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PostCommit_Java_Nexmark_Spark.groovy#L36 Should we also need to modify those? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 373939) Time Spent: 15h 50m (was: 15h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 15h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=370155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370155 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 11/Jan/20 00:03 Start Date: 11/Jan/20 00:03 Worklog Time Spent: 10m Work Description: robertwb commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r365476453 ## File path: sdks/python/apache_beam/transforms/validate_runner_xlang_test.py ## @@ -0,0 +1,195 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +from __future__ import absolute_import + +import logging +import os +import typing +import unittest + +from nose.plugins.attrib import attr +from past.builtins import unicode + +import apache_beam as beam +from apache_beam.options.pipeline_options import DebugOptions +from apache_beam.testing.test_pipeline import TestPipeline +from apache_beam.testing.util import assert_that +from apache_beam.testing.util import equal_to + +TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix" +TEST_MULTI_URN = "beam:transforms:xlang:test:multi" +TEST_GBK_URN = "beam:transforms:xlang:test:gbk" +TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk" +TEST_COMGL_URN = "beam:transforms:xlang:test:comgl" +TEST_COMPK_URN = "beam:transforms:xlang:test:compk" +TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten" +TEST_PARTITION_URN = "beam:transforms:xlang:test:partition" + + +@attr('UsesCrossLanguageTransforms') +@unittest.skipUnless( +os.environ.get('EXPANSION_JAR'), +"EXPANSION_JAR environment variable is not set.") +@unittest.skipUnless( +os.environ.get('EXPANSION_PORT'), +"EXPANSION_PORT environment var is not provided.") +class ValidateRunnerXlangTest(unittest.TestCase): + expansion_service = 'localhost:%s' % os.environ.get('EXPANSION_PORT') + expansion_jar = os.environ.get('EXPANSION_JAR') + + def test_simple(self): +test_pipeline = TestPipeline() +test_pipeline.get_pipeline_options().view_as( +DebugOptions).experiments.append( +'jar_packages='+ValidateRunnerXlangTest.expansion_jar) +test_pipeline.not_use_test_runner_api = True +with test_pipeline as p: + res = ( + p + | beam.Create(['a', 'b']).with_output_types(unicode) + | beam.ExternalTransform( + TEST_PREFIX_URN, + b'0', + ValidateRunnerXlangTest.expansion_service)) + assert_that(res, equal_to(['0a', '0b'])) + + def test_multi(self): Review comment: Or fix the name. I'm all for (meaningfully) verbose test names. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 370155) Time Spent: 15h 40m (was: 15.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 15h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368442 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 22:16 Start Date: 08/Jan/20 22:16 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-572282808 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368442) Time Spent: 15.5h (was: 15h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 15.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368439 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 22:13 Start Date: 08/Jan/20 22:13 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-572282808 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368439) Time Spent: 15h 20m (was: 15h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 15h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368376 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r364398245 ## File path: sdks/java/testing/expansion-service/src/test/java/org/apache/beam/sdk/expansion/TestExpansionService.java ## @@ -55,39 +88,154 @@ @Override public Map knownTransforms() { Schema schema = new Schema.Parser().parse(rawSchema); - return ImmutableMap.of( - TEST_COUNT_URN, spec -> Count.perElement(), + ImmutableMap.Builder builder = + ImmutableMap.builder(); + builder.put( + TEST_PREFIX_URN, + spec -> + MapElements.into(TypeDescriptors.strings()) + .via((String x) -> spec.getPayload().toStringUtf8() + x)); + builder.put(TEST_MULTI_URN, spec -> new TestMultiPTransform()); + builder.put(TEST_GBK_URN, spec -> GroupByKey.create()); + builder.put(TEST_CGBK_URN, new TestCoGroupByKeyTransformProvider()); + builder.put(TEST_COMGL_URN, spec -> Sum.longsGlobally()); + builder.put(TEST_COMPK_URN, spec -> Sum.longsPerKey()); + builder.put(TEST_FLATTEN_URN, new TestFlattenTransformProvider()); + builder.put( + TEST_PARTITION_URN, + spec -> Partition.of(2, (Long elem, int numP) -> elem % 2 == 0 ? 0 : 1)); + builder.put( + TEST_PARQUET_WRITE_URN, + spec -> + new PTransform, PCollection>() { +@Override +public PCollection expand(PCollection input) { + return input + .apply( + FileIO.write() + .via(ParquetIO.sink(schema)) + .to(spec.getPayload().toStringUtf8())) + .getPerDestinationOutputFilenames() + .apply(Values.create()); +} + }); + + builder.put(TEST_COUNT_URN, spec -> Count.perElement()); + builder.put( TEST_FILTER_URN, - spec -> - Filter.lessThanEq( - // TODO(BEAM-6587): Use strings directly rather than longs. - (long) spec.getPayload().toStringUtf8().charAt(0)), + spec -> + Filter.lessThanEq( + // TODO(BEAM-6587): Use strings directly rather than longs. + (long) spec.getPayload().toStringUtf8().charAt(0))); + builder.put( TEST_PARQUET_READ_URN, - spec -> - new PTransform>() { -@Override -public PCollection expand(PBegin input) { - return input - .apply(FileIO.match().filepattern(spec.getPayload().toStringUtf8())) - .apply(FileIO.readMatches()) - .apply(ParquetIO.readFiles(schema)) - .setCoder(AvroCoder.of(schema)); -} - }, - TEST_PARQUET_WRITE_URN, - spec -> - new PTransform, PCollection>() { -@Override -public PCollection expand(PCollection input) { - return input - .apply( - FileIO.write() - .via(ParquetIO.sink(schema)) - .to(spec.getPayload().toStringUtf8())) - .getPerDestinationOutputFilenames() - .apply(Values.create()); -} - }); + spec -> + new PTransform>() { +@Override +public PCollection expand(PBegin input) { + return input + .apply(FileIO.match().filepattern(spec.getPayload().toStringUtf8())) + .apply(FileIO.readMatches()) + .apply(ParquetIO.readFiles(schema)) + .setCoder(AvroCoder.of(schema)); +} + }); + return builder.build(); +} + +public static class TestFlattenTransformProvider +implements ExpansionService.TransformProvider, PCollection> { Review comment: Instead of implementing TransformProviders can we implement TransformRegistrar and TransformBuilder combination which is our public API for transform authors ? I think using low level API here will make this co
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368368 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r364404753 ## File path: sdks/python/apache_beam/runners/portability/expansion_service_test.py ## @@ -73,39 +84,139 @@ def from_runner_api_parameter(payload, unused_context): return FilterLessThanTransform(payload.decode('utf8')) -@ptransform.PTransform.register_urn('simple', None) -class SimpleTransform(ptransform.PTransform): +@ptransform.PTransform.register_urn(TEST_PREFIX_URN, None) +@beam.typehints.with_output_types(unicode) +class PrefixTransform(ptransform.PTransform): + def __init__(self, payload): +self._payload = payload + def expand(self, pcoll): -return pcoll | 'TestLabel' >> beam.Map(lambda x: 'Simple(%s)' % x) +return pcoll | 'TestLabel' >> beam.Map( +lambda x: '{}{}'.format(self._payload, x)) def to_runner_api_parameter(self, unused_context): -return 'simple', None +return TEST_PREFIX_URN, None @staticmethod - def from_runner_api_parameter(unused_parameter, unused_context): -return SimpleTransform() + def from_runner_api_parameter(payload, unused_context): +return PrefixTransform(payload.decode('utf8')) -@ptransform.PTransform.register_urn('multi', None) +@ptransform.PTransform.register_urn(TEST_MULTI_URN, None) class MutltiTransform(ptransform.PTransform): def expand(self, pcolls): return { 'main': (pcolls['main1'], pcolls['main2']) | beam.Flatten() | beam.Map(lambda x, s: x + s, - beam.pvalue.AsSingleton(pcolls['side'])), -'side': pcolls['side'] | beam.Map(lambda x: x + x), + beam.pvalue.AsSingleton(pcolls['side']) + ).with_output_types(unicode), +'side': pcolls['side'] | beam.Map( +lambda x: x + x).with_output_types(unicode), } def to_runner_api_parameter(self, unused_context): -return 'multi', None +return TEST_MULTI_URN, None @staticmethod def from_runner_api_parameter(unused_parameter, unused_context): return MutltiTransform() +@ptransform.PTransform.register_urn(TEST_GBK_URN, None) +class GBKTransform(ptransform.PTransform): + def expand(self, pcoll): +return pcoll | 'TestLabel' >> beam.GroupByKey() + + def to_runner_api_parameter(self, unused_context): +return TEST_GBK_URN, None + + @staticmethod + def from_runner_api_parameter(unused_parameter, unused_context): Review comment: Do we need to implement from_runner_api_parameter() and to_runner_api_parameter() methods here and below ? don't the default implementation work ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368368) Time Spent: 14.5h (was: 14h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368374 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363905348 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368372 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r364044791 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368375 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r364407654 ## File path: sdks/python/apache_beam/transforms/validate_runner_xlang_test.py ## @@ -0,0 +1,195 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +from __future__ import absolute_import + +import logging +import os +import typing +import unittest + +from nose.plugins.attrib import attr +from past.builtins import unicode + +import apache_beam as beam +from apache_beam.options.pipeline_options import DebugOptions +from apache_beam.testing.test_pipeline import TestPipeline +from apache_beam.testing.util import assert_that +from apache_beam.testing.util import equal_to + +TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix" +TEST_MULTI_URN = "beam:transforms:xlang:test:multi" +TEST_GBK_URN = "beam:transforms:xlang:test:gbk" +TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk" +TEST_COMGL_URN = "beam:transforms:xlang:test:comgl" +TEST_COMPK_URN = "beam:transforms:xlang:test:compk" +TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten" +TEST_PARTITION_URN = "beam:transforms:xlang:test:partition" + + +@attr('UsesCrossLanguageTransforms') +@unittest.skipUnless( +os.environ.get('EXPANSION_JAR'), +"EXPANSION_JAR environment variable is not set.") +@unittest.skipUnless( +os.environ.get('EXPANSION_PORT'), +"EXPANSION_PORT environment var is not provided.") +class ValidateRunnerXlangTest(unittest.TestCase): + expansion_service = 'localhost:%s' % os.environ.get('EXPANSION_PORT') + expansion_jar = os.environ.get('EXPANSION_JAR') + + def test_simple(self): +test_pipeline = TestPipeline() +test_pipeline.get_pipeline_options().view_as( +DebugOptions).experiments.append( +'jar_packages='+ValidateRunnerXlangTest.expansion_jar) +test_pipeline.not_use_test_runner_api = True +with test_pipeline as p: + res = ( + p + | beam.Create(['a', 'b']).with_output_types(unicode) + | beam.ExternalTransform( + TEST_PREFIX_URN, + b'0', + ValidateRunnerXlangTest.expansion_service)) + assert_that(res, equal_to(['0a', '0b'])) + + def test_multi(self): Review comment: Please add comments describing tests that are not obvious by name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368375) Time Spent: 15h (was: 14h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 15h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368367 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363902674 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; Review comment: Prob. add a brief (one sentence) description of each transform here ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368367) Time Spent: 14.5h (was: 14h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368371 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363904794 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368369 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363905813 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.core.construction; + +import static org.hamcrest.Matchers.equalTo; +import static org.junit.Assert.assertThat; + +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; +import org.apache.beam.sdk.PipelineResult; +import org.apache.beam.sdk.options.ExperimentalOptions; +import org.apache.beam.sdk.testing.PAssert; +import org.apache.beam.sdk.testing.TestPipeline; +import org.apache.beam.sdk.testing.UsesCrossLanguageTransforms; +import org.apache.beam.sdk.testing.ValidatesRunner; +import org.apache.beam.sdk.transforms.Create; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.join.KeyedPCollectionTuple; +import org.apache.beam.sdk.values.KV; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionList; +import org.apache.beam.sdk.values.PCollectionTuple; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ConnectivityState; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannel; +import org.apache.beam.vendor.grpc.v1p21p0.io.grpc.ManagedChannelBuilder; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.Iterables; +import org.junit.After; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; + +/** Test External transforms. */ +@RunWith(JUnit4.class) +public class ValidateRunnerXlangTest implements Serializable { + @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; + + private static final String TEST_PREFIX_URN = "beam:transforms:xlang:test:prefix"; + private static final String TEST_MULTI_URN = "beam:transforms:xlang:test:multi"; + private static final String TEST_GBK_URN = "beam:transforms:xlang:test:gbk"; + private static final String TEST_CGBK_URN = "beam:transforms:xlang:test:cgbk"; + private static final String TEST_COMGL_URN = "beam:transforms:xlang:test:comgl"; + private static final String TEST_COMPK_URN = "beam:transforms:xlang:test:compk"; + private static final String TEST_FLATTEN_URN = "beam:transforms:xlang:test:flatten"; + private static final String TEST_PARTITION_URN = "beam:transforms:xlang:test:partition"; + + private static String expansionAddr; + private static String expansionJar; + + @BeforeClass + public static void setUpClass() { +expansionAddr = +String.format("localhost:%s", Integer.valueOf(System.getProperty("expansionPort"))); +expansionJar = System.getProperty("expansionJar"); + } + + @Before + public void setUp() { +testPipeline +.getOptions() +.as(ExperimentalOptions.class) +.setExperiments(ImmutableList.of("jar_packages=" + expansionJar)); +waitForReady(); + } + + @After + public void tearDown() { +pipelineResult.waitUntilFinish(); +assertThat(pipelineResult.getState(), equalTo(PipelineResult.State.DONE)); + } + + private void waitForReady() { +try { + ManagedChannel channel = ManagedChannelBuilder.forTarget(expansionAddr).build(); + ConnectivityS
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368366 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363894634 ## File path: runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ExternalTest.java ## @@ -56,19 +57,18 @@ @RunWith(JUnit4.class) public class ExternalTest implements Serializable { @Rule public transient TestPipeline testPipeline = TestPipeline.create(); + private PipelineResult pipelineResult; private static final String TEST_URN_SIMPLE = "simple"; private static final String TEST_URN_LE = "le"; private static final String TEST_URN_MULTI = "multi"; - private static Integer expansionPort; private static String localExpansionAddr; private static Server localExpansionServer; @BeforeClass - public static void setUp() throws IOException { -expansionPort = Integer.valueOf(System.getProperty("expansionPort")); -int localExpansionPort = expansionPort + 100; + public static void setUpClass() throws IOException { +int localExpansionPort = Integer.parseInt(System.getProperty("expansionPort")) + 100; Review comment: Can we dynamically a find an unused port ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368366) Time Spent: 14h 20m (was: 14h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368370 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r364405632 ## File path: sdks/python/apache_beam/transforms/external.py ## @@ -416,7 +416,8 @@ def _normalize(coder_proto): unique_name=full_label, spec=self._expanded_transform.spec, subtransforms=self._expanded_transform.subtransforms, -inputs=self._expanded_transform.inputs, +inputs={tag: pcoll_renames.get(pcoll, pcoll) Review comment: Was this needed for some specific case ? (just for my information) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368370) Time Spent: 14h 40m (was: 14.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368373 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363893939 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -1684,22 +1688,21 @@ class BeamModulePlugin implements Plugin { args '-c', "$pythonDir/scripts/run_expansion_services.sh stop --group_id ${project.name}" } setupTask.finalizedBy cleanupTask + config.startJobServer.finalizedBy config.cleanupJobServer // Task for running testcases in Java SDK def beamJavaTestPipelineOptions = [ - "--runner=org.apache.beam.runners.portability.testing.TestPortableRunner", -"--jobServerDriver=${config.jobServerDriver}", +"--runner=PortableRunner", Review comment: This change was required due to OOMs, right ? Prob. add a comment so that someone does not revert this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368373) Time Spent: 14h 50m (was: 14h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368365 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363870290 ## File path: .test-infra/jenkins/job_PostCommit_CrossLanguageValidatesRunner_Flink.groovy ## @@ -34,10 +34,19 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_XVR_Flink', // Gradle goals for this job. steps { +shell('echo *** RUN CROSS-LANGUAGE FLINK USING PYTHON 2.7 ***') gradle { rootBuildScriptDir(commonJobProperties.checkoutDir) tasks(':runners:flink:1.9:job-server:validatesCrossLanguageRunner') commonJobProperties.setGradleSwitches(delegate) + switches('-PpythonVersion=2.7') +} +shell('echo *** RUN CROSS-LANGUAGE FLINK USING PYTHON 3.5 ***') Review comment: Ditto This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368365) Time Spent: 14h 10m (was: 14h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=368364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368364 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 08/Jan/20 19:48 Start Date: 08/Jan/20 19:48 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r363870233 ## File path: .test-infra/jenkins/job_PostCommit_CrossLanguageValidatesRunner_Flink.groovy ## @@ -34,10 +34,19 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_XVR_Flink', // Gradle goals for this job. steps { +shell('echo *** RUN CROSS-LANGUAGE FLINK USING PYTHON 2.7 ***') Review comment: "RUNNING" ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368364) Time Spent: 14h (was: 13h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 14h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=367590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367590 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 07/Jan/20 17:48 Start Date: 07/Jan/20 17:48 Worklog Time Spent: 10m Work Description: markflyhigh commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-571696285 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367590) Time Spent: 13h 50m (was: 13h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=367589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-367589 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 07/Jan/20 17:44 Start Date: 07/Jan/20 17:44 Worklog Time Spent: 10m Work Description: markflyhigh commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-571694401 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 367589) Time Spent: 13h 40m (was: 13.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=366143&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366143 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 04/Jan/20 01:07 Start Date: 04/Jan/20 01:07 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570742930 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 366143) Time Spent: 13.5h (was: 13h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=366142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366142 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 04/Jan/20 01:07 Start Date: 04/Jan/20 01:07 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570742930 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 366142) Time Spent: 13h 20m (was: 13h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365578 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 03/Jan/20 00:43 Start Date: 03/Jan/20 00:43 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570417955 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365578) Time Spent: 13h 10m (was: 13h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365577 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 03/Jan/20 00:43 Start Date: 03/Jan/20 00:43 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570417955 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365577) Time Spent: 13h (was: 12h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 13h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365531 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 02/Jan/20 23:16 Start Date: 02/Jan/20 23:16 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570394176 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365531) Time Spent: 12h 50m (was: 12h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365530 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 02/Jan/20 23:16 Start Date: 02/Jan/20 23:16 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570394176 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365530) Time Spent: 12h 40m (was: 12.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365520&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365520 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 02/Jan/20 22:29 Start Date: 02/Jan/20 22:29 Worklog Time Spent: 10m Work Description: ihji commented on pull request #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#discussion_r362654300 ## File path: sdks/python/test-suites/portable/py2/build.gradle ## @@ -87,7 +87,7 @@ task crossLanguagePythonJavaDirect { ] exec { executable 'sh' - args '-c', ". ${envdir}/bin/activate && cd ${pythonRootDir} && pip install -e .[test] && python -m apache_beam.transforms.external_test ${options.join(' ')}" + args '-c', ". ${envdir}/bin/activate && cd ${pythonRootDir} && pip install -e .[test] && python -m apache_beam.transforms.external_java ${options.join(' ')}" Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365520) Time Spent: 12.5h (was: 12h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=365519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365519 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 02/Jan/20 22:29 Start Date: 02/Jan/20 22:29 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-570378798 R: @chamikaramj @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 365519) Time Spent: 12h 20m (was: 12h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=364799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364799 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Dec/19 23:45 Start Date: 30/Dec/19 23:45 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568606886 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 364799) Time Spent: 11h 50m (was: 11h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=364798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364798 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Dec/19 23:45 Start Date: 30/Dec/19 23:45 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-569828720 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 364798) Time Spent: 11h 40m (was: 11.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=364800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364800 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Dec/19 23:45 Start Date: 30/Dec/19 23:45 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-569828774 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 364800) Time Spent: 12h (was: 11h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=364801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-364801 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 30/Dec/19 23:45 Start Date: 30/Dec/19 23:45 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-569828774 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 364801) Time Spent: 12h 10m (was: 12h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 12h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=362791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362791 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 23/Dec/19 23:39 Start Date: 23/Dec/19 23:39 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568606886 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 362791) Time Spent: 11h 20m (was: 11h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=362792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362792 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 23/Dec/19 23:39 Start Date: 23/Dec/19 23:39 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568600405 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 362792) Time Spent: 11.5h (was: 11h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=362777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362777 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 23/Dec/19 22:56 Start Date: 23/Dec/19 22:56 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568138206 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 362777) Time Spent: 11h 10m (was: 11h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=362776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362776 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 23/Dec/19 22:56 Start Date: 23/Dec/19 22:56 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568600405 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 362776) Time Spent: 11h (was: 10h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 11h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361993 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 21/Dec/19 01:10 Start Date: 21/Dec/19 01:10 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-568138206 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361993) Time Spent: 10h 40m (was: 10.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361994 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 21/Dec/19 01:10 Start Date: 21/Dec/19 01:10 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-567742923 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361994) Time Spent: 10h 50m (was: 10h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361244 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 18/Dec/19 01:20 Start Date: 18/Dec/19 01:20 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-566823427 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361244) Time Spent: 10h 20m (was: 10h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361245 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 18/Dec/19 01:20 Start Date: 18/Dec/19 01:20 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-566699073 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361245) Time Spent: 10.5h (was: 10h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361059 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 17/Dec/19 18:54 Start Date: 17/Dec/19 18:54 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-564776828 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361059) Time Spent: 10h 10m (was: 10h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=361058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361058 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 17/Dec/19 18:54 Start Date: 17/Dec/19 18:54 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-566699073 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 361058) Time Spent: 10h (was: 9h 50m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 10h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=358174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358174 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 11/Dec/19 23:18 Start Date: 11/Dec/19 23:18 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-564769963 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358174) Time Spent: 9h 50m (was: 9h 40m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 9h 50m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=358173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358173 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 11/Dec/19 23:18 Start Date: 11/Dec/19 23:18 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-564776828 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358173) Time Spent: 9h 40m (was: 9.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 9h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=358158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358158 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 11/Dec/19 22:54 Start Date: 11/Dec/19 22:54 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-561948521 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358158) Time Spent: 9.5h (was: 9h 20m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 9.5h > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=358157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358157 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 11/Dec/19 22:54 Start Date: 11/Dec/19 22:54 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-564769963 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 358157) Time Spent: 9h 20m (was: 9h 10m) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 9h 20m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=355535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355535 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 07/Dec/19 02:09 Start Date: 07/Dec/19 02:09 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-562803863 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 355535) Time Spent: 8h 40m (was: 8.5h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7961) Add tests for all runner native transforms and some widely used composite transforms to cross-language validates runner test suite
[ https://issues.apache.org/jira/browse/BEAM-7961?focusedWorklogId=355538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355538 ] ASF GitHub Bot logged work on BEAM-7961: Author: ASF GitHub Bot Created on: 07/Dec/19 02:09 Start Date: 07/Dec/19 02:09 Worklog Time Spent: 10m Work Description: ihji commented on issue #10051: [BEAM-7961] Add tests for all runner native transforms for XLang URL: https://github.com/apache/beam/pull/10051#issuecomment-562803886 Run XVR_Flink PostCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 355538) Time Spent: 9h 10m (was: 9h) > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite > -- > > Key: BEAM-7961 > URL: https://issues.apache.org/jira/browse/BEAM-7961 > Project: Beam > Issue Type: Improvement > Components: testing >Reporter: Heejong Lee >Assignee: Heejong Lee >Priority: Major > Time Spent: 9h 10m > Remaining Estimate: 0h > > Add tests for all runner native transforms and some widely used composite > transforms to cross-language validates runner test suite -- This message was sent by Atlassian Jira (v8.3.4#803005)